fix: regex usage in w3c extraction #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of std::regex_match was problematic for traceparent with trailing spaces. The overload use is `std::regex_match(str, str + std::char_traits<CharT>::length(str), m, e, flags)`, which resolves as the whole input instead of the trimmed input. Changes: - Fix std::regex_match usage. - Add unit test.
dmehala
requested review from
cataphract and
pablomartinezbernardo
and removed request for
a team and
cataphract
pablomartinezbernardo
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Usage of std::regex_match was problematic for traceparent with trailing spaces. The overload use is
std::regex_match(str, str + std::char_traits<CharT>::length(str), m, e, flags), which resolves as the whole input instead of the trimmed input.This regression has been introduced in #119
Changes: