fix: DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS support floating point input
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Remote Configuration specification, `DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS` support floating point input and can be set to `0`.
dmehala
commented
May 23, 2024
| @@ -21,7 +21,7 @@ Expected<DatadogAgentConfig> load_datadog_agent_env_config() { | |||
|
|
|||
| if (auto raw_rc_poll_interval_value = | |||
| lookup(environment::DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS)) { | |||
| auto res = parse_int(*raw_rc_poll_interval_value, 10); | |||
| auto res = parse_double(*raw_rc_poll_interval_value); | |||
There was a problem hiding this comment.
Note to myself: a double is too big but I don't have time (don't want yet) to write (and test) a parse_float function.
pablomartinezbernardo
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the Remote Configuration specification,
DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDSsupport floating point input and can be set to0.Motivation
System-tests use sub-seconds value for fast iteration. In order to test the library against remote configuration tests, the library must support sub-seconds inputs.
Additional Notes
Jira ticket: [PROJ-IDENT]