fix: trace sampling rules order #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset trace sampling rules legacy order.
dmehala
commented
May 27, 2024
BenchmarksBenchmark execution time: 2024-05-28 09:18:43 Comparing candidate commit cb02455 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
pablomartinezbernardo
approved these changes
May 28, 2024
Comment on lines
+48
to
+49
| return Error{Error::TRACE_SAMPLING_RULES_INVALID_JSON, | ||
| "Missing \"sample_rate\" field"}; |
There was a problem hiding this comment.
qq for this and other new error handling: Is a default value set somewhere? Or will parsing now fail when it didn't before?
There was a problem hiding this comment.
Parsing will fail, those fields are mandatory.
Co-authored-by: pablomartinezbernardo <134320516+pablomartinezbernardo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reset trace sampling rules legacy order.