Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to include maintainers doc #145

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Update README to include maintainers doc #145

merged 1 commit into from
Aug 19, 2024

Conversation

bm1549
Copy link
Contributor

@bm1549 bm1549 commented Aug 19, 2024

Description

Add maintainers doc as a link from the repository README

Motivation

Increases discoverability of the maintainers doc since it's very useful for new engs starting in dd-trace-cpp

Additional Notes

Jira ticket: [PROJ-IDENT]

@bm1549 bm1549 requested a review from a team as a code owner August 19, 2024 14:22
@bm1549 bm1549 requested review from zacharycmontoya and removed request for a team August 19, 2024 14:22
@pr-commenter
Copy link

pr-commenter bot commented Aug 19, 2024

Benchmarks

Benchmark execution time: 2024-08-19 14:24:20

Comparing candidate commit 4d300c0 in PR branch bm1549-patch-1 with baseline commit dc5e762 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Copy link
Collaborator

@dmehala dmehala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (dc5e762) to head (4d300c0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files          73       73           
  Lines        3811     3811           
=======================================
  Hits         3600     3600           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bm1549 bm1549 merged commit aa037a9 into main Aug 19, 2024
22 checks passed
@bm1549 bm1549 deleted the bm1549-patch-1 branch August 19, 2024 14:30
@bm1549 bm1549 changed the title Update README.md Update README to include maintainers doc Aug 19, 2024
cataphract pushed a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants