Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "additional_payload" from telemetry #68

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

cgilmour
Copy link
Contributor

@cgilmour cgilmour commented Nov 9, 2023

This was requested by the team involved in instrumentation telemetry.

This was requested by the team involved in instrumentation telemetry.
@cgilmour cgilmour requested review from dmehala and dgoffredo November 9, 2023 19:50
@pr-commenter
Copy link

pr-commenter bot commented Nov 9, 2023

Benchmarks

Benchmark execution time: 2023-11-09 19:53:07

Comparing candidate commit 05d3d89 in PR branch cgilmour/telemetry-remove-additional with baseline commit 2ee2a7f in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

scenario:BM_TraceTinyCCSource

  • 🟥 execution_time [+3.287ms; +3.376ms] or [+4.162%; +4.274%]

Copy link
Contributor

@dgoffredo dgoffredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm-shipit-RdYWGunNxpZ-kvXG6fq_gOM 1400x1400

@cgilmour cgilmour merged commit f9e4217 into main Nov 9, 2023
2 checks passed
@cgilmour cgilmour deleted the cgilmour/telemetry-remove-additional branch November 9, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants