Configure parametric test to get the cpp tracer in same way as system-tests #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-01-08 10:49:26 Comparing candidate commit 5985edc in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
robertomonteromiguel
requested review from
dmehala and
cgilmour
and removed request for
dmehala
dmehala
reviewed
Jan 8, 2024
dmehala
reviewed
Jan 8, 2024
| environment: | ||
| TEST_LIBRARY: cpp | ||
| DD_TRACE_CPP_COMMIT: << pipeline.git.revision >> | ||
| command: cd system-tests && ./build.sh -i runner && ./run.sh PARAMETRIC --log-cli-level=DEBUG | ||
| command: | | ||
| echo "https://github.com/DataDog/dd-trace-cpp@$DD_TRACE_CPP_COMMIT" > ~/project/system-tests/binaries/cpp-load-from-git |
There was a problem hiding this comment.
If it will work once we merge the PR: DataDog/system-tests#1983
There was a problem hiding this comment.
Could you just set the version of dd-trace-cpp instead of the whole github url?
There was a problem hiding this comment.
It is to maintain a certain similarity with other tracers. ie: https://github.com/DataDog/system-tests/blob/main/utils/scripts/load-binary.sh#L230
Co-authored-by: Damien Mehala <damien.mehala@datadoghq.com>
robertomonteromiguel
deleted the
robertomonteromiguel/parameric_tests_set_cpp_tracer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure parametric test to get the cpp tracer in same way as system-tests
Related with system-tests PR: DataDog/system-tests#1983