add http method to the resource name (#126)

DataDog · Sep 13, 2018 · ec43ce1 · ec43ce1
1 parent 658d531
commit ec43ce1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/Datadog.Trace.ClrProfiler.Managed/Integrations/AspNetCoreMvc2Integration.cs b/src/Datadog.Trace.ClrProfiler.Managed/Integrations/AspNetCoreMvc2Integration.cs
@@ -31,7 +31,6 @@ public AspNetCoreMvc2Integration(object actionDescriptorObj, object httpContextO
                 dynamic actionDescriptor = actionDescriptorObj;
                 string controllerName = (actionDescriptor.ControllerName as string)?.ToLowerInvariant();
                 string actionName = (actionDescriptor.ActionName as string)?.ToLowerInvariant();
-                string resourceName = $"{controllerName}.{actionName}";
 
                 _httpContext = httpContextObj;
                 string httpMethod = _httpContext.Request.Method.ToUpperInvariant();
@@ -40,7 +39,7 @@ public AspNetCoreMvc2Integration(object actionDescriptorObj, object httpContextO
                 _scope = Tracer.Instance.StartActive(RequestOperationName);
                 Span span = _scope.Span;
                 span.Type = SpanTypes.Web;
-                span.ResourceName = resourceName;
+                span.ResourceName = $"{httpMethod} {controllerName}.{actionName}";
                 span.SetTag(Tags.HttpMethod, httpMethod);
                 span.SetTag(Tags.HttpUrl, url);
                 span.SetTag(Tags.AspNetController, controllerName);

diff --git a/src/Datadog.Trace.ClrProfiler.Managed/Integrations/AspNetMvc5Integration.cs b/src/Datadog.Trace.ClrProfiler.Managed/Integrations/AspNetMvc5Integration.cs
@@ -70,7 +70,7 @@ public AspNetMvc5Integration(object controllerContextObj)
                 IDictionary<string, object> routeValues = controllerContext.RouteData.Values;
                 string controllerName = (routeValues.GetValueOrDefault("controller") as string)?.ToLowerInvariant();
                 string actionName = (routeValues.GetValueOrDefault("action") as string)?.ToLowerInvariant();
-                string resourceName = $"{controllerName}.{actionName}";
+                string resourceName = $"{httpMethod} {controllerName}.{actionName}";
 
                 _scope = Tracer.Instance.StartActive(RequestOperationName);
                 Span span = _scope.Span;