[Dynamic Instrumentation] DEBUG-2256 Do not create ProbeProcessor when LiveDebugger isn't fully initialized #6092

dudikeleti · 2024-09-27T11:07:01Z

Summary of changes

ProbeProcessor can be inialized from various places and it do a low of work. If the LiveDebugger isn't fully initialized, it useless to create it. This PR verify this.

datadog-ddstaging · 2024-09-27T11:29:17Z

Datadog Report

Branch report: dudik/probeprocessor-guard
Commit report: 420a812
Test service: dd-trace-dotnet

❌ 1 Failed (1 Known Flaky), 466078 Passed, 3593 Skipped, 32h 29m 38.21s Total Time

❌ Failed Tests (1)

WorkingWithContinuousProfiler - Datadog.Trace.Tools.dd_dotnet.ArtifactTests.Checks.ProcessBasicChecksTests - ❄️ Known flaky - Details

Expand for error

 
 
 With StandardOutput:
 Running checks on process 3976 Process name: Samples.Console  ---- STARTING TRACER SETUP CHECKS ----- Target process is running with .NET Framework 1. Checking Modules Needed so the Tracer Loads:  [SUCCESS]: The native library version 3.6.0.0 is loaded into the process.  [WARNING]: Found multiple instances of Datadog.Trace.dll in the target process. Detected versions: 3.6.0.0  2. Checking DD_DOTNET_TRACER_HOME and related configuration value:  [SUCCESS]: DD_DOTNET_TRACER_HOME is set to 'D:\a\1\s\shared\bin\monitoring-home' and the directory was found correctly. 3. Checking COR_PROFILER_PATH and related configuration value:  [SUCCESS]: The environment variable COR_PROFILER_PATH is set to the correct value of D:\a\1\s\shared\bin\monitoring-home\win-x64\Datadog.Trace.ClrProfiler.Native.dll . 4. Checking COR_PROFILER and related configuration value:  [SUCCESS]: The environment variable COR_PROFILER is set to the correct value of {846F5F1C-F9AE-4B07-969E-05C26BC060D8}. 5. Checking COR_ENABLE_PROFILING and related configuration value:  [SUCCESS]: The environment variable COR_ENABLE_PROFILING is set to the correct value of 1.  ---- CONFIGURATION CHECKS ----- 1. Checking if tracing is disabled using DD_TRACE_ENABLED.  [INFO]: DD_TRACE_ENABLED is not set, the default value is true. 2. Checking if profiling is enabled using DD_PROFILING_ENABLED.  [SUCCESS]: DD_PROFILING_ENABLED is set.  ---- DATADOG AGENT CHECKS ----- Detected agent url: http://127.0.0.1:52185/. Note: this url may be incorrect if you configured the application through a configuration file. Connecting to Agent at endpoint http://127.0.0.1:52185/ using HTTP  [WARNING]: Could not detect the agent version. It may be running with a version older than 7.27.0.  [SUCCESS]: No issue found with the target process. 
 With ErrorOutput:
 
 With ExitCode:
 0acer version 3.6.0.0 is loaded into the process."}.

GreenMatan

LGTM

andrewlock · 2024-11-15T00:05:10Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (71ms)  : 64, 79
     .   : milestone, 71,
    master - mean (72ms)  : 64, 79
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (1,106ms)  : 1090, 1123
     .   : milestone, 1106,
    master - mean (1,113ms)  : 1088, 1138
     .   : milestone, 1113,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (109ms)  : 107, 110
     .   : milestone, 109,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (769ms)  : 752, 786
     .   : milestone, 769,
    master - mean (766ms)  : 751, 781
     .   : milestone, 766,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (94ms)  : 83, 105
     .   : milestone, 94,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (726ms)  : 708, 745
     .   : milestone, 726,
    master - mean (726ms)  : 710, 743
     .   : milestone, 726,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (192ms)  : 186, 198
     .   : milestone, 192,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (1,213ms)  : 1190, 1237
     .   : milestone, 1213,
    master - mean (1,211ms)  : 1180, 1242
     .   : milestone, 1211,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (278ms)  : 275, 282
     .   : milestone, 278,
    master - mean (276ms)  : 272, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (947ms)  : 930, 965
     .   : milestone, 947,
    master - mean (947ms)  : 924, 969
     .   : milestone, 947,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (267ms)  : 263, 270
     .   : milestone, 267,
    master - mean (267ms)  : 262, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (933ms)  : 913, 953
     .   : milestone, 933,
    master - mean (928ms)  : 914, 942
     .   : milestone, 928,

andrewlock · 2024-11-15T02:01:07Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6092) (11.026M)   : 0, 11025931
    master (11.152M)   : 0, 11152338
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6092) (7.217M)   : 0, 7217426
    master (7.244M)   : 0, 7243660
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.518M)   : 0, 7517768

    section Manual
    master (11.069M)   : 0, 11069227

    section Manual + Automatic
    This PR (6092) (6.627M)   : 0, 6626907
    master (6.654M)   : 0, 6654084

    section DD_TRACE_ENABLED=0
    master (10.167M)   : 0, 10167208

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6092) (9.605M)   : 0, 9604909
    master (9.526M)   : 0, 9526248
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6092) (6.255M)   : 0, 6254994
    master (6.498M)   : 0, 6497687

    section Trace stats
    master (6.721M)   : 0, 6720904

    section Manual
    master (9.319M)   : 0, 9318756

    section Manual + Automatic
    This PR (6092) (5.925M)   : 0, 5925220
    master (5.950M)   : 0, 5950309

    section DD_TRACE_ENABLED=0
    master (8.828M)   : 0, 8827707

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6092) (9.834M)   : 0, 9834287
    master (9.687M)   : 0, 9686574
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6092) (6.435M)   : 0, 6435443
    master (6.271M)   : 0, 6271452
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.878M)   : 0, 6878067

    section Manual
    master (9.591M)   : 0, 9591403

    section Manual + Automatic
    This PR (6092) (5.927M)   : 0, 5927413
    master (5.878M)   : 0, 5877708

    section DD_TRACE_ENABLED=0
    master (8.841M)   : 0, 8841473

andrewlock · 2024-11-15T03:32:57Z

Benchmarks Report for tracer 🐌

Benchmarks for #6092 compared to master:

2 benchmarks are slower, with geometric mean 1.123
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.91μs	41.8ns	209ns	0.0156	0.0078	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	50.8ns	309ns	0.0195	0.00973	0	5.8 KB
master	`StartStopWithChild`	net472	16.5μs	52.4ns	203ns	1.05	0.313	0.0907	6.2 KB
#6092	`StartStopWithChild`	net6.0	7.94μs	44.6ns	312ns	0.0117	0.00391	0	5.61 KB
#6092	`StartStopWithChild`	netcoreapp3.1	10μs	53.6ns	278ns	0.0148	0.00494	0	5.8 KB
#6092	`StartStopWithChild`	net472	16μs	49.9ns	193ns	1.05	0.335	0.104	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	488μs	354ns	1.32μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	657μs	328ns	1.27μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	862μs	251ns	904ns	0.428	3.3 KB
#6092	`WriteAndFlushEnrichedTraces`	net6.0	501μs	284ns	1.1μs	0	2.7 KB
#6092	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	655μs	343ns	1.33μs	0	2.7 KB
#6092	`WriteAndFlushEnrichedTraces`	net472	865μs	421ns	1.63μs	0.431	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	192μs	1E+03ns	5.1μs	0.207	18.73 KB
master	`SendRequest`	netcoreapp3.1	219μs	1.22μs	8.46μs	0.216	20.89 KB
master	`SendRequest`	net472	0.00131ns	0.000487ns	0.00182ns	0	0 b
#6092	`SendRequest`	net6.0	193μs	1.06μs	7.49μs	0.186	18.73 KB
#6092	`SendRequest`	netcoreapp3.1	222μs	1.26μs	9.86μs	0.216	20.89 KB
#6092	`SendRequest`	net472	0.00231ns	0.000614ns	0.00238ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	543μs	1.4μs	5.23μs	0.543	0	0	41.57 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	670μs	2.05μs	7.66μs	0.334	0	0	41.71 KB
master	`WriteAndFlushEnrichedTraces`	net472	859μs	2.41μs	9.34μs	8.28	2.48	0.414	53.31 KB
#6092	`WriteAndFlushEnrichedTraces`	net6.0	565μs	1.5μs	5.6μs	0.556	0	0	41.7 KB
#6092	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	665μs	3.03μs	15.1μs	0.329	0	0	41.65 KB
#6092	`WriteAndFlushEnrichedTraces`	net472	872μs	2.29μs	8.89μs	8.39	2.52	0.419	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.23μs	0.763ns	2.96ns	0.0147	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.7μs	2.79ns	10.8ns	0.0136	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.08μs	1.89ns	7.07ns	0.157	0.00104	987 B
#6092	`ExecuteNonQuery`	net6.0	1.17μs	0.591ns	2.21ns	0.014	0	1.02 KB
#6092	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	0.984ns	3.68ns	0.013	0	1.02 KB
#6092	`ExecuteNonQuery`	net472	1.98μs	2.03ns	7.85ns	0.157	0.000986	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6092

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.123	1,262.02	1,417.63

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.17μs	0.922ns	3.45ns	0.0139	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.231ns	0.8ns	0.0131	976 B
master	`CallElasticsearch`	net472	2.55μs	1.88ns	7.29ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.26μs	0.907ns	3.39ns	0.0132	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	1.11ns	4.31ns	0.0134	1.02 KB
master	`CallElasticsearchAsync`	net472	2.55μs	1.27ns	4.74ns	0.167	1.05 KB
#6092	`CallElasticsearch`	net6.0	1.13μs	0.38ns	1.31ns	0.0136	976 B
#6092	`CallElasticsearch`	netcoreapp3.1	1.51μs	0.693ns	2.59ns	0.0135	976 B
#6092	`CallElasticsearch`	net472	2.46μs	2.55ns	9.88ns	0.157	995 B
#6092	`CallElasticsearchAsync`	net6.0	1.42μs	0.503ns	1.95ns	0.0128	952 B
#6092	`CallElasticsearchAsync`	netcoreapp3.1	1.71μs	0.95ns	3.68ns	0.0137	1.02 KB
#6092	`CallElasticsearchAsync`	net472	2.55μs	0.952ns	3.69ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.21μs	0.954ns	3.57ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.6μs	0.824ns	3.19ns	0.0127	952 B
master	`ExecuteAsync`	net472	1.83μs	0.498ns	1.86ns	0.145	915 B
#6092	`ExecuteAsync`	net6.0	1.24μs	0.476ns	1.78ns	0.013	952 B
#6092	`ExecuteAsync`	netcoreapp3.1	1.71μs	0.558ns	2.09ns	0.0129	952 B
#6092	`ExecuteAsync`	net472	1.82μs	0.415ns	1.61ns	0.144	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.28μs	1.15ns	4.31ns	0.0321	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.32μs	6.54ns	23.6ns	0.0369	2.85 KB
master	`SendAsync`	net472	7.19μs	2.12ns	7.93ns	0.494	3.12 KB
#6092	`SendAsync`	net6.0	4.42μs	2.04ns	7.64ns	0.0309	2.31 KB
#6092	`SendAsync`	netcoreapp3.1	5.31μs	1.66ns	6.42ns	0.0373	2.85 KB
#6092	`SendAsync`	net472	7.46μs	2.26ns	8.75ns	0.496	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.51μs	1.01ns	3.64ns	0.0226	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.22μs	0.901ns	3.37ns	0.0221	1.64 KB
master	`EnrichedLog`	net472	2.64μs	1.22ns	4.39ns	0.249	1.57 KB
#6092	`EnrichedLog`	net6.0	1.61μs	1.37ns	5.12ns	0.0226	1.64 KB
#6092	`EnrichedLog`	netcoreapp3.1	2.22μs	0.955ns	3.7ns	0.0222	1.64 KB
#6092	`EnrichedLog`	net472	2.62μs	1.69ns	6.32ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	202ns	782ns	0.0601	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	124μs	117ns	455ns	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	148ns	573ns	0.683	0.228	4.46 KB
#6092	`EnrichedLog`	net6.0	121μs	144ns	537ns	0.06	0	4.28 KB
#6092	`EnrichedLog`	netcoreapp3.1	124μs	123ns	475ns	0	0	4.28 KB
#6092	`EnrichedLog`	net472	150μs	176ns	680ns	0.671	0.224	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.09μs	1.44ns	5.2ns	0.031	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.16μs	1.53ns	5.5ns	0.0292	2.2 KB
master	`EnrichedLog`	net472	4.94μs	2.13ns	8.25ns	0.321	2.02 KB
#6092	`EnrichedLog`	net6.0	2.99μs	8.88ns	34.4ns	0.0314	2.2 KB
#6092	`EnrichedLog`	netcoreapp3.1	4.19μs	2.63ns	10.2ns	0.0293	2.2 KB
#6092	`EnrichedLog`	net472	4.75μs	0.988ns	3.7ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6092

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0	1.122	1,306.04	1,465.58

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.31μs	1.05ns	4.06ns	0.0163	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.75μs	0.515ns	1.93ns	0.0151	1.14 KB
master	`SendReceive`	net472	2.06μs	2.21ns	8.55ns	0.183	1.16 KB
#6092	`SendReceive`	net6.0	1.47μs	0.68ns	2.63ns	0.0161	1.14 KB
#6092	`SendReceive`	netcoreapp3.1	1.82μs	0.336ns	1.16ns	0.0155	1.14 KB
#6092	`SendReceive`	net472	2.15μs	0.592ns	2.21ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.63μs	0.921ns	3.44ns	0.0223	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.96μs	1.97ns	7.64ns	0.0217	1.65 KB
master	`EnrichedLog`	net472	4.36μs	1.35ns	5.04ns	0.323	2.04 KB
#6092	`EnrichedLog`	net6.0	2.72μs	0.61ns	2.36ns	0.0218	1.6 KB
#6092	`EnrichedLog`	netcoreapp3.1	3.88μs	1.19ns	4.46ns	0.0213	1.65 KB
#6092	`EnrichedLog`	net472	4.52μs	6.29ns	23.5ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	400ns	0.272ns	1.05ns	0.00803	576 B
master	`StartFinishSpan`	netcoreapp3.1	624ns	0.728ns	2.63ns	0.00768	576 B
master	`StartFinishSpan`	net472	657ns	0.713ns	2.76ns	0.0916	578 B
master	`StartFinishScope`	net6.0	496ns	0.235ns	0.911ns	0.00986	696 B
master	`StartFinishScope`	netcoreapp3.1	648ns	0.543ns	2.1ns	0.00943	696 B
master	`StartFinishScope`	net472	907ns	1.01ns	3.92ns	0.104	658 B
#6092	`StartFinishSpan`	net6.0	400ns	0.391ns	1.51ns	0.00803	576 B
#6092	`StartFinishSpan`	netcoreapp3.1	560ns	0.748ns	2.9ns	0.00778	576 B
#6092	`StartFinishSpan`	net472	670ns	0.58ns	2.25ns	0.0917	578 B
#6092	`StartFinishScope`	net6.0	545ns	0.69ns	2.67ns	0.00986	696 B
#6092	`StartFinishScope`	netcoreapp3.1	712ns	0.777ns	3.01ns	0.00938	696 B
#6092	`StartFinishScope`	net472	910ns	0.914ns	3.54ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	709ns	0.474ns	1.84ns	0.0099	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	918ns	0.85ns	3.29ns	0.00922	696 B
master	`RunOnMethodBegin`	net472	1.2μs	0.745ns	2.79ns	0.104	658 B
#6092	`RunOnMethodBegin`	net6.0	684ns	0.559ns	2.16ns	0.00959	696 B
#6092	`RunOnMethodBegin`	netcoreapp3.1	942ns	0.634ns	2.46ns	0.00941	696 B
#6092	`RunOnMethodBegin`	net472	1.19μs	1.14ns	4.42ns	0.104	658 B

dudikeleti requested a review from a team as a code owner September 27, 2024 11:07

github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels Sep 27, 2024

dudikeleti requested a review from GreenMatan October 1, 2024 12:10

GreenMatan approved these changes Nov 11, 2024

View reviewed changes

dudikeleti force-pushed the dudik/probeprocessor-guard branch 9 times, most recently from 09789c3 to 684cda6 Compare November 14, 2024 23:25

dudikeleti force-pushed the dudik/probeprocessor-guard branch 3 times, most recently from a6036d8 to 5f0d297 Compare November 15, 2024 15:53

dudikeleti added 2 commits November 17, 2024 10:54

Do not add probe processor when LiveDebugger isn't fully initialized

19fdcb3

fix build

420a812

dudikeleti force-pushed the dudik/probeprocessor-guard branch from 5f0d297 to 420a812 Compare November 17, 2024 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] DEBUG-2256 Do not create ProbeProcessor when LiveDebugger isn't fully initialized #6092

[Dynamic Instrumentation] DEBUG-2256 Do not create ProbeProcessor when LiveDebugger isn't fully initialized #6092

dudikeleti commented Sep 27, 2024

datadog-ddstaging bot commented Sep 27, 2024 •

edited

Loading

GreenMatan left a comment

andrewlock commented Nov 15, 2024 •

edited

Loading

andrewlock commented Nov 15, 2024 •

edited

Loading

andrewlock commented Nov 15, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6092

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6092

Raw results

Raw results

Raw results

Raw results

[Dynamic Instrumentation] DEBUG-2256 Do not create ProbeProcessor when LiveDebugger isn't fully initialized #6092

Are you sure you want to change the base?

[Dynamic Instrumentation] DEBUG-2256 Do not create ProbeProcessor when LiveDebugger isn't fully initialized #6092

Conversation

dudikeleti commented Sep 27, 2024

Summary of changes

datadog-ddstaging bot commented Sep 27, 2024 • edited Loading

Datadog Report

❌ Failed Tests (1)

GreenMatan left a comment

Choose a reason for hiding this comment

andrewlock commented Nov 15, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Nov 15, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Nov 15, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6092

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6092

Raw results

Raw results

Raw results

Raw results

datadog-ddstaging bot commented Sep 27, 2024 •

edited

Loading

andrewlock commented Nov 15, 2024 •

edited

Loading

andrewlock commented Nov 15, 2024 •

edited

Loading

andrewlock commented Nov 15, 2024 •

edited

Loading