[ASM] Native CallTarget definitions

Datadog.Trace.sln

@@ -587,6 +587,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Generated", "Generated", "{
 		tracer\build\PackageVersionsLatestMajors.g.props = tracer\build\PackageVersionsLatestMajors.g.props
 		tracer\build\PackageVersionsLatestMinors.g.props = tracer\build\PackageVersionsLatestMinors.g.props
 		tracer\build\PackageVersionsLatestSpecific.g.props = tracer\build\PackageVersionsLatestSpecific.g.props
+		tracer\build\supported_calltargets.g.json = tracer\build\supported_calltargets.g.json
 	EndProjectSection
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Samples.AWS.EventBridge", "tracer\test\test-applications\integrations\Samples.AWS.EventBridge\Samples.AWS.EventBridge.csproj", "{D6155F26-8245-4B66-8944-79C3DF9F9DA3}"

tracer/build/_build/Build.Steps.cs

@@ -437,9 +437,9 @@ bool RequiresThoroughTesting()
 
             var nativeGeneratedFilesOutputPath = NativeTracerProject.Directory / "Generated";
             CallSitesGenerator.GenerateCallSites(TargetFrameworks, tfm => DatadogTraceDirectory / "bin" / BuildConfiguration / tfm / Projects.DatadogTrace + ".dll", nativeGeneratedFilesOutputPath);
+            CallTargetsGenerator.GenerateCallTargets(TargetFrameworks, tfm => DatadogTraceDirectory / "bin" / BuildConfiguration / tfm / Projects.DatadogTrace + ".dll", nativeGeneratedFilesOutputPath, Version, BuildDirectory);
         });
 
-
     Target CompileTracerNativeTestsWindows => _ => _
         .Unlisted()
         .OnlyWhenStatic(() => IsWin)

tracer/build/_build/Build.Utilities.cs

@@ -224,6 +224,7 @@ partial class Build
 
            var testDir = Solution.GetProject(Projects.ClrProfilerIntegrationTests).Directory;
            var dependabotProj = TracerDirectory / "dependabot" / "Datadog.Dependabot.Integrations.csproj";
+           var definitionsFile = BuildDirectory / FileNames.DefinitionsJson;
            var currentDependencies = DependabotFileManager.GetCurrentlyTestedVersions(dependabotProj);
            var excludedFromUpdates = ((IncludePackages, ExcludePackages) switch
                                          {
@@ -245,7 +246,7 @@ partial class Build
                            .Select(x => x.ToString())
                            .ToList();
 
-           var integrations = GenerateIntegrationDefinitions.GetAllIntegrations(assemblies);
+           var integrations = GenerateIntegrationDefinitions.GetAllIntegrations(assemblies, definitionsFile);
            var distinctIntegrations = await DependabotFileManager.BuildDistinctIntegrationMaps(integrations, testedVersions);
 
            await DependabotFileManager.UpdateIntegrations(dependabotProj, distinctIntegrations);

tracer/build/_build/Build.cs

@@ -2,6 +2,7 @@
 using System.IO;
 using System.Linq;
 using System.Runtime.InteropServices;
+using CodeGenerators;
 using Colorful;
 using Nuke.Common;
 using Nuke.Common.CI;
@@ -593,4 +594,19 @@ void DeleteReparsePoints(string path)
     /// Run the default build
     /// </summary>
     public static int Main() => Execute<Build>(x => x.BuildTracerHome);
+
+    // For nuke step debugging, comment previous line and uncomment the following lines
+    /*
+        public static int Main() => Execute<Build>(x => x.Debug);
+
+        Target Debug => _ => _
+            .Unlisted()
+            .Executes(() =>
+            {
+                Logger.Information("Debugging...");
+                // Execute whatever you want to debug here
+                var nativeGeneratedFilesOutputPath = NativeTracerProject.Directory / "Generated";
+                CallTargetsGenerator.GenerateCallTargets(TargetFrameworks, tfm => DatadogTraceDirectory / "bin" / BuildConfiguration / tfm / Projects.DatadogTrace + ".dll", nativeGeneratedFilesOutputPath, Version);
+            });
+    //*/
 }

tracer/build/_build/CodeGenerators/CallSitesGenerator.cs

@@ -16,14 +16,14 @@ public static void GenerateCallSites(IEnumerable<TargetFramework> targetFramewor
         {
             Serilog.Log.Debug("Generating CallSite definitions file ...");
 
-            Dictionary<string, AspectClass> aspectClasses = new Dictionary<string, AspectClass>();
+            var aspectClasses = new Dictionary<string, AspectClass>();
             foreach(var tfm in targetFrameworks)
             {
                 var dllPath = getDllPath(tfm);
                 RetrieveCallSites(aspectClasses, dllPath, tfm);
             }
 
-            GenerateCallSites(aspectClasses, outputPath);
+            GenerateFile(aspectClasses, outputPath);
         }
 
         internal static void RetrieveCallSites(Dictionary<string, AspectClass> aspectClasses, string dllPath, TargetFramework tfm)
@@ -37,17 +37,17 @@ internal static void RetrieveCallSites(Dictionary<string, AspectClass> aspectCla
             var tfmCategory = GetCategory(tfm);
 
             // Open dll to extract all AspectsClass attributes.
-            using var asmDefinition = Mono.Cecil.AssemblyDefinition.ReadAssembly(dllPath);
+            using var asmDefinition = AssemblyDefinition.ReadAssembly(dllPath);
 
-            foreach (var aspectClassType in asmDefinition.MainModule.Types)
+            foreach (var type in asmDefinition.MainModule.Types)
             {
-                var aspectClassAttribute = aspectClassType.CustomAttributes.FirstOrDefault(IsAspectClass);
+                var aspectClassAttribute = type.CustomAttributes.FirstOrDefault(IsAspectClass);
                 if (aspectClassAttribute is null)
                 {
                     continue;
                 }
 
-                var aspectClassLine = $"{GetAspectLine(aspectClassAttribute, out var category)} {aspectClassType.FullName}";
+                var aspectClassLine = $"{GetAspectLine(aspectClassAttribute, out var category)} {type.FullName}";
                 if (!aspectClasses.TryGetValue(aspectClassLine, out var aspectClass))
                 {
                     aspectClass = new AspectClass();
@@ -56,7 +56,7 @@ internal static void RetrieveCallSites(Dictionary<string, AspectClass> aspectCla
                 }
 
                 // Retrieve aspects
-                foreach(var method in aspectClassType.Methods)
+                foreach(var method in type.Methods)
                 {
                     foreach(var aspectAttribute in method.CustomAttributes.Where(IsAspect))
                     {
@@ -235,7 +235,7 @@ static string GetArgument(Mono.Cecil.CustomAttributeArgument customAttributeArgu
             }
         }
 
-        internal static void GenerateCallSites(Dictionary<string, AspectClass> aspectClasses, AbsolutePath outputPath)
+        internal static void GenerateFile(Dictionary<string, AspectClass> aspectClasses, AbsolutePath outputPath)
         {
             var sb = new StringBuilder();
             sb.AppendLine("""
@@ -254,11 +254,11 @@ namespace trace
                 {
                 """);
 
-            foreach (var aspectClass in aspectClasses.OrderBy(k => k.Key.ToString(), StringComparer.OrdinalIgnoreCase))
+            foreach (var aspectClass in aspectClasses.OrderBy(static k => k.Key.ToString(), StringComparer.OrdinalIgnoreCase))
             {
                 sb.AppendLine(Format(aspectClass.Key + aspectClass.Value.Subfix()));
 
-                foreach (var method in aspectClass.Value.Aspects.OrderBy(k => k.Key.ToString(), StringComparer.OrdinalIgnoreCase))
+                foreach (var method in aspectClass.Value.Aspects.OrderBy(static k => k.Key.ToString(), StringComparer.OrdinalIgnoreCase))
                 {
                     sb.AppendLine(Format("  " + method.Key + method.Value.Subfix()));
                 }
@@ -287,7 +287,7 @@ internal static TargetFrameworks GetCategory(TargetFramework tfm)
             return (TargetFrameworks)Enum.Parse<TargetFrameworks>(tfm.ToString().ToUpper().Replace('.', '_'));
         }
 
-        internal struct AspectClass
+        internal record AspectClass
         {
             public AspectClass() {}
 
@@ -300,7 +300,7 @@ public string Subfix()
             }
         }
 
-        internal struct Aspect
+        internal record Aspect
         {
             public Aspect() { }