Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Exclude windows only definitions from non windows dlls #6270

Open
wants to merge 3 commits into
base: dani/apm/NativeCallTargets
Choose a base branch
from
Open

[APM] Exclude windows only definitions from non windows dlls #6270

wants to merge 3 commits into from

Conversation

daniel-romano-DD
Copy link
Contributor

@daniel-romano-DD daniel-romano-DD commented Nov 11, 2024 •
edited
Loading

Summary of changes

Remove windows only definitions from non windows dlls

Reason for change

Defs take up space. Removing non needed ones will help keep package size as low as possible

Implementation details

Surround windows only defs in #if _WIN32 clauses

Test coverage

Other details

@daniel-romano-DD daniel-romano-DD changed the base branch from master to dani/apm/NativeCallTargets November 11, 2024 16:59
This was referenced Nov 11, 2024
Open
Open
@daniel-romano-DD Graphite App
Copy link
Contributor Author

daniel-romano-DD commented Nov 11, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@daniel-romano-DD daniel-romano-DD added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native) area:asm-iast area:builds project files, build scripts, pipelines, versioning, releases, packages labels Nov 11, 2024
@daniel-romano-DD daniel-romano-DD marked this pull request as ready for review November 11, 2024 17:06
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 11, 2024 •
edited
Loading

Datadog Report

Branch report: dani/apm/SkipNetFxDefsInLinux
Commit report: 05ae16a
Test service: dd-trace-dotnet

❌ 6 Failed (0 Known Flaky), 571757 Passed, 4778 Skipped, 47h 39m 47.95s Total Time

❌ Failed Tests (6)

This report shows up to 5 failed tests.

  • AllCycleMoreComplexBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details

  • AllCycleMoreComplexBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details

  • AllCycleMoreComplexBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details

  • AllCycleSimpleBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details

  • AllCycleSimpleBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details

@andrewlock
Copy link
Member

andrewlock commented Nov 11, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6270) - mean (72ms)  : 63, 82
     .   : milestone, 72,
    master - mean (72ms)  : 64, 80
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (6270) - mean (985ms)  : 961, 1010
     .   : milestone, 985,
    master - mean (1,107ms)  : 1088, 1127
     .   : milestone, 1107,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6270) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (107ms)  : 105, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6270) - mean (688ms)  : 673, 703
     .   : milestone, 688,
    master - mean (767ms)  : 746, 787
     .   : milestone, 767,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6270) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6270) - mean (634ms)  : 615, 653
     .   : milestone, 634,
    master - mean (722ms)  : 711, 733
     .   : milestone, 722,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6270) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 185, 196
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6270) - mean (1,094ms)  : 1067, 1121
     .   : milestone, 1094,
    master - mean (1,212ms)  : 1193, 1232
     .   : milestone, 1212,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6270) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6270) - mean (875ms)  : 841, 908
     .   : milestone, 875,
    master - mean (946ms)  : 923, 969
     .   : milestone, 946,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6270) - mean (265ms)  : 262, 269
     .   : milestone, 265,
    master - mean (265ms)  : 260, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6270) - mean (845ms)  : 809, 882
     .   : milestone, 845,
    master - mean (926ms)  : 910, 942
     .   : milestone, 926,
Loading

@andrewlock
Copy link
Member

andrewlock commented Nov 11, 2024 •
edited
Loading

Benchmarks Report for appsec 🐌

Benchmarks for #6270 compared to master:

  • All benchmarks have the same speed
  • 2 benchmarks have fewer allocations
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 72.3μs 67.8ns 263ns 0.0716 0 0 6 KB
master AllCycleSimpleBody netcoreapp3.1 62.5μs 58.7ns 220ns 0.0938 0 0 6.95 KB
master AllCycleSimpleBody net472 49.1μs 72ns 279ns 1.31 0 0 8.33 KB
master AllCycleMoreComplexBody net6.0 78.4μs 55ns 213ns 0.117 0 0 9.51 KB
master AllCycleMoreComplexBody netcoreapp3.1 69.4μs 56.4ns 211ns 0.139 0 0 10.36 KB
master AllCycleMoreComplexBody net472 56.5μs 85.2ns 330ns 1.87 0.0283 0 11.85 KB
master ObjectExtractorSimpleBody net6.0 145ns 0.12ns 0.448ns 0.00395 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 209ns 0.137ns 0.494ns 0.00369 0 0 272 B
master ObjectExtractorSimpleBody net472 171ns 0.0861ns 0.334ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.04μs 2.64ns 9.86ns 0.0533 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.91μs 3.08ns 11.9ns 0.0507 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 4.36μs 1.92ns 7.44ns 0.601 0.00656 0 3.8 KB
#6270 AllCycleSimpleBody net6.0 73.2μs 125ns 484ns 0.0747 0 0 6.01 KB
#6270 AllCycleSimpleBody netcoreapp3.1 63.1μs 65.6ns 245ns 0.0939 0 0 6.95 KB
#6270 AllCycleSimpleBody net472 49.2μs 44.1ns 165ns 1.32 0 0 8.34 KB
#6270 AllCycleMoreComplexBody net6.0 79.5μs 58.9ns 228ns 0.119 0 0 9.51 KB
#6270 AllCycleMoreComplexBody netcoreapp3.1 71.1μs 74.4ns 288ns 0.107 0 0 10.37 KB
#6270 AllCycleMoreComplexBody net472 55.6μs 42.8ns 160ns 1.86 0.0278 0 11.85 KB
#6270 ObjectExtractorSimpleBody net6.0 150ns 0.132ns 0.512ns 0.00392 0 0 280 B
#6270 ObjectExtractorSimpleBody netcoreapp3.1 209ns 0.267ns 0.999ns 0.00377 0 0 272 B
#6270 ObjectExtractorSimpleBody net472 165ns 0.099ns 0.383ns 0.0446 0 0 281 B
#6270 ObjectExtractorMoreComplexBody net6.0 3.12μs 2.03ns 7.6ns 0.0531 0 0 3.78 KB
#6270 ObjectExtractorMoreComplexBody netcoreapp3.1 3.87μs 2.76ns 9.96ns 0.0506 0 0 3.69 KB
#6270 ObjectExtractorMoreComplexBody net472 4.46μs 3.52ns 13.6ns 0.602 0.00666 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 38.2μs 26.2ns 102ns 0.454 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 54.3μs 36.7ns 142ns 0.432 0 0 32.4 KB
master EncodeArgs net472 66.4μs 27.9ns 104ns 5.15 0.0661 0 32.5 KB
master EncodeLegacyArgs net6.0 76.2μs 407ns 2.11μs 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 109μs 254ns 983ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 154μs 97.1ns 376ns 0.31 0 0 2.15 KB
#6270 EncodeArgs net6.0 37.4μs 23.7ns 88.7ns 0.45 0 0 32.4 KB
#6270 EncodeArgs netcoreapp3.1 54μs 44.6ns 167ns 0.44 0 0 32.4 KB
#6270 EncodeArgs net472 67.6μs 19ns 65.8ns 5.16 0.0675 0 32.5 KB
#6270 EncodeLegacyArgs net6.0 73μs 123ns 478ns 0 0 0 2.14 KB
#6270 EncodeLegacyArgs netcoreapp3.1 105μs 174ns 674ns 0 0 0 2.14 KB
#6270 EncodeLegacyArgs net472 154μs 154ns 597ns 0.308 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 185μs 60.9ns 236ns 0 0 0 2.44 KB
master RunWafRealisticBenchmark netcoreapp3.1 198μs 238ns 921ns 0 0 0 2.39 KB
master RunWafRealisticBenchmark net472 210μs 141ns 545ns 0.315 0 0 2.46 KB
master RunWafRealisticBenchmarkWithAttack net6.0 122μs 106ns 381ns 0 0 0 1.47 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 130μs 155ns 598ns 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack net472 138μs 42.5ns 153ns 0.208 0 0 1.49 KB
#6270 RunWafRealisticBenchmark net6.0 185μs 242ns 938ns 0 0 0 2.44 KB
#6270 RunWafRealisticBenchmark netcoreapp3.1 198μs 208ns 805ns 0 0 0 2.39 KB
#6270 RunWafRealisticBenchmark net472 211μs 221ns 856ns 0.314 0 0 2.46 KB
#6270 RunWafRealisticBenchmarkWithAttack net6.0 122μs 53.6ns 201ns 0 0 0 1.47 KB
#6270 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 131μs 323ns 1.25μs 0 0 0 1.46 KB
#6270 RunWafRealisticBenchmarkWithAttack net472 139μs 108ns 418ns 0.207 0 0 1.49 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6270

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 253.95 KB 265.42 KB 11.47 KB 4.52%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 272.91 KB 278.53 KB 5.62 KB 2.06%

Fewer allocations 🎉 in #6270

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 255.27 KB 252.41 KB -2.86 KB -1.12%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 60.49 KB 59.07 KB -1.42 KB -2.34%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 52.9μs 209ns 782ns 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 54.2μs 287ns 1.38μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 38μs 165ns 616ns 0 0 0 60.49 KB
master StringConcatAspectBenchmark net6.0 295μs 4.71μs 43.7μs 0 0 0 253.95 KB
master StringConcatAspectBenchmark netcoreapp3.1 354μs 1.97μs 12.1μs 0 0 0 255.27 KB
master StringConcatAspectBenchmark net472 278μs 6.14μs 58.9μs 0 0 0 272.91 KB
#6270 StringConcatBenchmark net6.0 52.7μs 275ns 1.29μs 0 0 0 43.44 KB
#6270 StringConcatBenchmark netcoreapp3.1 62.4μs 777ns 7.65μs 0 0 0 42.64 KB
#6270 StringConcatBenchmark net472 37.3μs 80.7ns 291ns 0 0 0 59.07 KB
#6270 StringConcatAspectBenchmark net6.0 325μs 1.84μs 12.2μs 0 0 0 265.42 KB
#6270 StringConcatAspectBenchmark netcoreapp3.1 333μs 1.72μs 9.75μs 0 0 0 252.41 KB
#6270 StringConcatAspectBenchmark net472 243μs 1.19μs 5.03μs 0 0 0 278.53 KB

@andrewlock
Copy link
Member

andrewlock commented Nov 11, 2024 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6270 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.254
  • 1 benchmarks are slower, with geometric mean 1.116
  • 2 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.94μs 40.8ns 200ns 0.0155 0.00777 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 57.2ns 370ns 0.015 0.00499 0 5.8 KB
master StartStopWithChild net472 16.1μs 41.1ns 159ns 1.04 0.294 0.0875 6.21 KB
#6270 StartStopWithChild net6.0 8.06μs 46.5ns 372ns 0.027 0.0116 0 5.61 KB
#6270 StartStopWithChild netcoreapp3.1 10.3μs 57.6ns 355ns 0.0149 0.00498 0 5.8 KB
#6270 StartStopWithChild net472 16.2μs 45.7ns 171ns 1.03 0.297 0.0991 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 506μs 215ns 806ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 648μs 312ns 1.12μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 875μs 753ns 2.91μs 0.431 0 0 3.3 KB
#6270 WriteAndFlushEnrichedTraces net6.0 494μs 203ns 786ns 0 0 0 2.7 KB
#6270 WriteAndFlushEnrichedTraces netcoreapp3.1 655μs 225ns 842ns 0 0 0 2.7 KB
#6270 WriteAndFlushEnrichedTraces net472 853μs 619ns 2.32μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Faster 🎉 Fewer allocations 🎉

Faster 🎉 in #6270

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑net6.0 1.336 196,032.01 146,709.63
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑netcoreapp3.1 1.317 220,789.94 167,621.91

Fewer allocations 🎉 in #6270

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑netcoreapp3.1 20.89 KB 17.27 KB -3.62 KB -17.32%
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑net6.0 18.73 KB 14.47 KB -4.26 KB -22.74%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 197μs 1.13μs 8.13μs 0.198 0 0 18.73 KB
master SendRequest netcoreapp3.1 222μs 1.18μs 9μs 0.206 0 0 20.89 KB
master SendRequest net472 0.00052ns 0.000242ns 0.000907ns 0 0 0 0 b
#6270 SendRequest net6.0 149μs 857ns 6.75μs 0.14 0 0 14.47 KB
#6270 SendRequest netcoreapp3.1 170μs 970ns 8.51μs 0.173 0 0 17.27 KB
#6270 SendRequest net472 0.000417ns 0.000249ns 0.000932ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 575μs 2.78μs 13μs 0.579 0 0 41.55 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 675μs 3.17μs 12.3μs 0.324 0 0 41.87 KB
master WriteAndFlushEnrichedTraces net472 858μs 3.67μs 14.2μs 8.39 2.52 0.419 53.29 KB
#6270 WriteAndFlushEnrichedTraces net6.0 558μs 2.45μs 9.49μs 0.581 0 0 41.73 KB
#6270 WriteAndFlushEnrichedTraces netcoreapp3.1 693μs 3.63μs 26.9μs 0.347 0 0 41.88 KB
#6270 WriteAndFlushEnrichedTraces net472 873μs 3.37μs 13.1μs 8.25 2.6 0.434 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.32μs 1.31ns 5.06ns 0.0146 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 1.3ns 4.69ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.01μs 1.54ns 5.96ns 0.156 0.00101 0 987 B
#6270 ExecuteNonQuery net6.0 1.23μs 1.74ns 6.74ns 0.0143 0 0 1.02 KB
#6270 ExecuteNonQuery netcoreapp3.1 1.73μs 2.35ns 8.78ns 0.0138 0 0 1.02 KB
#6270 ExecuteNonQuery net472 2.07μs 1.66ns 6.22ns 0.157 0.00103 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.15μs 0.379ns 1.42ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.49μs 0.517ns 1.93ns 0.0134 0 0 976 B
master CallElasticsearch net472 2.48μs 1.06ns 3.95ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.28μs 0.475ns 1.78ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 0.8ns 3.1ns 0.0133 0 0 1.02 KB
master CallElasticsearchAsync net472 2.63μs 0.664ns 2.39ns 0.166 0 0 1.05 KB
#6270 CallElasticsearch net6.0 1.23μs 0.59ns 2.29ns 0.014 0 0 976 B
#6270 CallElasticsearch netcoreapp3.1 1.58μs 0.955ns 3.57ns 0.0133 0 0 976 B
#6270 CallElasticsearch net472 2.53μs 0.952ns 3.56ns 0.157 0 0 995 B
#6270 CallElasticsearchAsync net6.0 1.38μs 0.737ns 2.85ns 0.0131 0 0 952 B
#6270 CallElasticsearchAsync netcoreapp3.1 1.62μs 1.05ns 4.08ns 0.0139 0 0 1.02 KB
#6270 CallElasticsearchAsync net472 2.61μs 0.449ns 1.68ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.15μs 0.63ns 2.36ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.73μs 0.229ns 0.857ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.84μs 0.377ns 1.36ns 0.145 0 0 915 B
#6270 ExecuteAsync net6.0 1.13μs 1.9ns 7.09ns 0.0131 0 0 952 B
#6270 ExecuteAsync netcoreapp3.1 1.57μs 2.04ns 7.63ns 0.0131 0 0 952 B
#6270 ExecuteAsync net472 1.8μs 0.705ns 2.73ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.47μs 1.08ns 4.04ns 0.0314 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.15μs 1.92ns 7.17ns 0.0385 0 0 2.85 KB
master SendAsync net472 7.35μs 1.79ns 6.94ns 0.495 0 0 3.12 KB
#6270 SendAsync net6.0 4.45μs 2.59ns 9.7ns 0.0313 0 0 2.31 KB
#6270 SendAsync netcoreapp3.1 5.63μs 1.88ns 7.26ns 0.0367 0 0 2.85 KB
#6270 SendAsync net472 7.27μs 2.94ns 11.4ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 2.82ns 10.9ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.35μs 1.44ns 5.38ns 0.0224 0 0 1.64 KB
master EnrichedLog net472 2.69μs 2.11ns 8.17ns 0.25 0 0 1.57 KB
#6270 EnrichedLog net6.0 1.59μs 0.881ns 3.3ns 0.0232 0 0 1.64 KB
#6270 EnrichedLog netcoreapp3.1 2.14μs 1.66ns 6.2ns 0.022 0 0 1.64 KB
#6270 EnrichedLog net472 2.49μs 2.44ns 9.46ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 119μs 103ns 400ns 0.0599 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 125μs 107ns 386ns 0 0 0 4.28 KB
master EnrichedLog net472 152μs 137ns 532ns 0.681 0.227 0 4.46 KB
#6270 EnrichedLog net6.0 118μs 147ns 569ns 0.059 0 0 4.28 KB
#6270 EnrichedLog netcoreapp3.1 121μs 198ns 768ns 0 0 0 4.28 KB
#6270 EnrichedLog net472 152μs 177ns 686ns 0.684 0.228 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.23μs 0.93ns 3.6ns 0.0313 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.18μs 1.33ns 5.13ns 0.0293 0 0 2.2 KB
master EnrichedLog net472 4.89μs 2.3ns 8.61ns 0.32 0 0 2.02 KB
#6270 EnrichedLog net6.0 3.05μs 0.597ns 2.31ns 0.0305 0 0 2.2 KB
#6270 EnrichedLog netcoreapp3.1 4.2μs 1.56ns 6.03ns 0.0292 0 0 2.2 KB
#6270 EnrichedLog net472 4.93μs 1.59ns 6.17ns 0.318 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.31μs 1.72ns 6.66ns 0.0157 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.83μs 1.26ns 4.71ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.02μs 1.06ns 3.67ns 0.183 0 0 1.16 KB
#6270 SendReceive net6.0 1.37μs 0.591ns 2.29ns 0.0164 0 0 1.14 KB
#6270 SendReceive netcoreapp3.1 1.76μs 0.397ns 1.49ns 0.015 0 0 1.14 KB
#6270 SendReceive net472 2.03μs 1.49ns 5.58ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.62μs 0.737ns 2.86ns 0.0221 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.93μs 2.07ns 8.02ns 0.0216 0 0 1.65 KB
master EnrichedLog net472 4.46μs 2.62ns 10.1ns 0.323 0 0 2.04 KB
#6270 EnrichedLog net6.0 2.79μs 0.849ns 3.29ns 0.0222 0 0 1.6 KB
#6270 EnrichedLog netcoreapp3.1 3.98μs 1.64ns 6.36ns 0.0219 0 0 1.65 KB
#6270 EnrichedLog net472 4.48μs 1.45ns 5.41ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6270

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.116 560.16 624.91

Faster 🎉 in #6270

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.119 799.13 713.87

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 398ns 0.233ns 0.903ns 0.00805 0 0 576 B
master StartFinishSpan netcoreapp3.1 561ns 0.48ns 1.86ns 0.00776 0 0 576 B
master StartFinishSpan net472 621ns 0.231ns 0.893ns 0.0916 0 0 578 B
master StartFinishScope net6.0 501ns 0.409ns 1.58ns 0.00978 0 0 696 B
master StartFinishScope netcoreapp3.1 799ns 0.426ns 1.65ns 0.0095 0 0 696 B
master StartFinishScope net472 908ns 0.452ns 1.75ns 0.104 0 0 658 B
#6270 StartFinishSpan net6.0 399ns 0.242ns 0.936ns 0.00818 0 0 576 B
#6270 StartFinishSpan netcoreapp3.1 625ns 0.41ns 1.54ns 0.00783 0 0 576 B
#6270 StartFinishSpan net472 672ns 0.87ns 3.37ns 0.0917 0 0 578 B
#6270 StartFinishScope net6.0 544ns 0.258ns 0.967ns 0.00987 0 0 696 B
#6270 StartFinishScope netcoreapp3.1 715ns 1.42ns 5.51ns 0.00944 0 0 696 B
#6270 StartFinishScope net472 899ns 0.811ns 3.14ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 602ns 0.221ns 0.855ns 0.00987 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 975ns 0.49ns 1.83ns 0.00927 0 0 696 B
master RunOnMethodBegin net472 1.18μs 0.483ns 1.87ns 0.104 0 0 658 B
#6270 RunOnMethodBegin net6.0 645ns 0.502ns 1.95ns 0.00994 0 0 696 B
#6270 RunOnMethodBegin netcoreapp3.1 890ns 0.61ns 2.36ns 0.00923 0 0 696 B
#6270 RunOnMethodBegin net472 1.12μs 0.909ns 3.52ns 0.104 0 0 658 B

@daniel-romano-DD daniel-romano-DD requested a review from a team as a code owner November 11, 2024 21:59
@andrewlock
Copy link
Member

andrewlock commented Nov 11, 2024 •
edited
Loading

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6270) (11.054M)   : 0, 11053747
    master (11.197M)   : 0, 11197381
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6270) (7.231M)   : 0, 7230698
    master (7.192M)   : 0, 7192384
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.476M)   : 0, 7475872

    section Manual
    master (11.271M)   : 0, 11270878

    section Manual + Automatic
    This PR (6270) (6.674M)   : 0, 6674322
    master (6.621M)   : 0, 6620931

    section DD_TRACE_ENABLED=0
    master (10.177M)   : 0, 10176556
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6270) (9.492M)   : 0, 9492019
    master (9.640M)   : 0, 9639769
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6270) (6.302M)   : 0, 6302301
    master (6.385M)   : 0, 6384570

    section Trace stats
    master (6.740M)   : 0, 6739552

    section Manual
    master (9.612M)   : 0, 9611974

    section Manual + Automatic
    This PR (6270) (5.904M)   : 0, 5904140
    master (5.891M)   : 0, 5890550

    section DD_TRACE_ENABLED=0
    master (8.839M)   : 0, 8838985
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6270) (10.399M)   : 0, 10399018
    master (10.121M)   : 0, 10120763
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6270) (6.606M)   : 0, 6606363
    master (6.469M)   : 0, 6469072
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.864M)   : 0, 6863851

    section Manual
    master (9.854M)   : 0, 9854162

    section Manual + Automatic
    This PR (6270) (6.285M)   : 0, 6284730
    master (5.906M)   : 0, 5906154

    section DD_TRACE_ENABLED=0
    master (9.224M)   : 0, 9224050
Loading

NachoEchevarria
NachoEchevarria approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@NachoEchevarria NachoEchevarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daniel-romano-DD daniel-romano-DD force-pushed the dani/apm/SkipNetFxDefsInLinux branch 2 times, most recently from 14e921b to 8c9d6b8 Compare November 15, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees
No one assigned
Labels
area:asm-iast area:builds project files, build scripts, pipelines, versioning, releases, packages area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native) area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-romano-DD @andrewlock @NachoEchevarria