-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Package Versions Bump] Updating package versions #6279
base: master
Are you sure you want to change the base?
Conversation
Datadog ReportBranch report: ❌ 48 Failed (0 Known Flaky), 450448 Passed, 2751 Skipped, 19h 13m 19.05s Total Time ❌ Failed Tests (48)
⌛ Performance Regressions vs Default Branch (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6279) - mean (72ms) : 64, 80
. : milestone, 72,
master - mean (72ms) : 63, 81
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (6279) - mean (1,108ms) : 1092, 1125
. : milestone, 1108,
master - mean (1,107ms) : 1087, 1128
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6279) - mean (108ms) : 106, 111
. : milestone, 108,
master - mean (109ms) : 107, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (6279) - mean (771ms) : 755, 788
. : milestone, 771,
master - mean (764ms) : 749, 779
. : milestone, 764,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6279) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (92ms) : 90, 93
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6279) - mean (724ms) : 709, 738
. : milestone, 724,
master - mean (723ms) : 709, 737
. : milestone, 723,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6279) - mean (191ms) : 186, 196
. : milestone, 191,
master - mean (190ms) : 186, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6279) - mean (1,212ms) : 1195, 1229
. : milestone, 1212,
master - mean (1,210ms) : 1185, 1234
. : milestone, 1210,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6279) - mean (277ms) : 273, 281
. : milestone, 277,
master - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6279) - mean (942ms) : 924, 959
. : milestone, 942,
master - mean (943ms) : 927, 960
. : milestone, 943,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6279) - mean (266ms) : 262, 269
. : milestone, 266,
master - mean (264ms) : 261, 268
. : milestone, 264,
section CallTarget+Inlining+NGEN
This PR (6279) - mean (930ms) : 911, 950
. : milestone, 930,
master - mean (929ms) : 911, 947
. : milestone, 929,
|
|
||
<!-- Integration: Microsoft.Extensions.Telemetry --> | ||
<!-- Assembly: Microsoft.Extensions.Telemetry --> | ||
<!-- Latest package https://www.nuget.org/packages/Microsoft.Extensions.Telemetry/8.10.0 --> | ||
<!-- Latest package https://www.nuget.org/packages/Microsoft.Extensions.Telemetry/9.0.0 --> | ||
<PackageReference Include="Microsoft.Extensions.Telemetry" Version="8.10.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one probably needs updating
<!-- Latest package https://www.nuget.org/packages/System.Data.SqlClient/4.8.6 --> | ||
<PackageReference Include="System.Data.SqlClient" Version="4.8.6" /> | ||
<!-- Latest package https://www.nuget.org/packages/System.Data.SqlClient/4.9.0 --> | ||
<PackageReference Include="System.Data.SqlClient" Version="4.9.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing some strange failures here, haven't looked into them
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
18:16:34 [DBG] ---> System.PlatformNotSupportedException: System.Data.SqlClient is not supported on this platform.
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6279) (11.162M) : 0, 11162055
master (11.178M) : 0, 11177881
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6279) (7.094M) : 0, 7093830
master (7.256M) : 0, 7255711
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.492M) : 0, 7492468
section Manual
master (11.100M) : 0, 11099883
section Manual + Automatic
This PR (6279) (6.673M) : 0, 6673352
master (6.651M) : 0, 6650806
section DD_TRACE_ENABLED=0
master (10.208M) : 0, 10207541
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6279) (9.261M) : 0, 9260819
master (9.416M) : 0, 9415676
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6279) (6.230M) : 0, 6229730
master (6.382M) : 0, 6381532
section Trace stats
master (6.663M) : 0, 6663276
section Manual
master (9.408M) : 0, 9408039
section Manual + Automatic
This PR (6279) (5.955M) : 0, 5955425
master (5.973M) : 0, 5972585
section DD_TRACE_ENABLED=0
master (8.832M) : 0, 8832446
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6279) (10.085M) : 0, 10084581
master (9.752M) : 0, 9751917
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6279) (6.326M) : 0, 6326234
master (6.475M) : 0, 6475378
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.987M) : 0, 6986817
section Manual
master (9.584M) : 0, 9583927
section Manual + Automatic
This PR (6279) (5.950M) : 0, 5950328
master (5.924M) : 0, 5924227
section DD_TRACE_ENABLED=0
master (8.855M) : 0, 8855119
|
316c2ad
to
9e10789
Compare
Benchmarks Report for tracer 🐌Benchmarks for #6279 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 | 1.130 | 1,153.01 | 1,302.98 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.15μs | 0.63ns | 2.36ns | 0.0132 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.73μs | 0.229ns | 0.857ns | 0.0129 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.84μs | 0.377ns | 1.36ns | 0.145 | 0 | 0 | 915 B |
#6279 | ExecuteAsync |
net6.0 | 1.3μs | 0.659ns | 2.55ns | 0.013 | 0 | 0 | 952 B |
#6279 | ExecuteAsync |
netcoreapp3.1 | 1.61μs | 1.42ns | 5.31ns | 0.0128 | 0 | 0 | 952 B |
#6279 | ExecuteAsync |
net472 | 1.8μs | 0.754ns | 2.92ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.47μs | 1.08ns | 4.04ns | 0.0314 | 0 | 0 | 2.31 KB |
master | SendAsync |
netcoreapp3.1 | 5.15μs | 1.92ns | 7.17ns | 0.0385 | 0 | 0 | 2.85 KB |
master | SendAsync |
net472 | 7.35μs | 1.79ns | 6.94ns | 0.495 | 0 | 0 | 3.12 KB |
#6279 | SendAsync |
net6.0 | 4.53μs | 3.23ns | 12.5ns | 0.0317 | 0 | 0 | 2.31 KB |
#6279 | SendAsync |
netcoreapp3.1 | 5.3μs | 1.99ns | 7.71ns | 0.0373 | 0 | 0 | 2.85 KB |
#6279 | SendAsync |
net472 | 7.29μs | 2.03ns | 7.31ns | 0.496 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.54μs | 2.82ns | 10.9ns | 0.0229 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.35μs | 1.44ns | 5.38ns | 0.0224 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.69μs | 2.11ns | 8.17ns | 0.25 | 0 | 0 | 1.57 KB |
#6279 | EnrichedLog |
net6.0 | 1.6μs | 0.977ns | 3.78ns | 0.0233 | 0 | 0 | 1.64 KB |
#6279 | EnrichedLog |
netcoreapp3.1 | 2.22μs | 1.26ns | 4.87ns | 0.0222 | 0 | 0 | 1.64 KB |
#6279 | EnrichedLog |
net472 | 2.56μs | 1.47ns | 5.69ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 119μs | 103ns | 400ns | 0.0599 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 125μs | 107ns | 386ns | 0 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 152μs | 137ns | 532ns | 0.681 | 0.227 | 0 | 4.46 KB |
#6279 | EnrichedLog |
net6.0 | 120μs | 245ns | 883ns | 0 | 0 | 0 | 4.28 KB |
#6279 | EnrichedLog |
netcoreapp3.1 | 121μs | 132ns | 476ns | 0 | 0 | 0 | 4.28 KB |
#6279 | EnrichedLog |
net472 | 151μs | 133ns | 514ns | 0.678 | 0.226 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.23μs | 0.93ns | 3.6ns | 0.0313 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.18μs | 1.33ns | 5.13ns | 0.0293 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.89μs | 2.3ns | 8.61ns | 0.32 | 0 | 0 | 2.02 KB |
#6279 | EnrichedLog |
net6.0 | 3.03μs | 1.12ns | 4.33ns | 0.0303 | 0 | 0 | 2.2 KB |
#6279 | EnrichedLog |
netcoreapp3.1 | 4.2μs | 1.94ns | 7.25ns | 0.0293 | 0 | 0 | 2.2 KB |
#6279 | EnrichedLog |
net472 | 4.99μs | 1.91ns | 7.4ns | 0.32 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.31μs | 1.72ns | 6.66ns | 0.0157 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.83μs | 1.26ns | 4.71ns | 0.0155 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.02μs | 1.06ns | 3.67ns | 0.183 | 0 | 0 | 1.16 KB |
#6279 | SendReceive |
net6.0 | 1.36μs | 1.62ns | 6.28ns | 0.0162 | 0 | 0 | 1.14 KB |
#6279 | SendReceive |
netcoreapp3.1 | 1.71μs | 3.29ns | 12.7ns | 0.0154 | 0 | 0 | 1.14 KB |
#6279 | SendReceive |
net472 | 2.04μs | 1ns | 3.88ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.62μs | 0.737ns | 2.86ns | 0.0221 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.93μs | 2.07ns | 8.02ns | 0.0216 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.46μs | 2.62ns | 10.1ns | 0.323 | 0 | 0 | 2.04 KB |
#6279 | EnrichedLog |
net6.0 | 2.78μs | 0.958ns | 3.71ns | 0.0222 | 0 | 0 | 1.6 KB |
#6279 | EnrichedLog |
netcoreapp3.1 | 3.77μs | 1.69ns | 6.32ns | 0.0207 | 0 | 0 | 1.65 KB |
#6279 | EnrichedLog |
net472 | 4.51μs | 2.92ns | 10.9ns | 0.322 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6279
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0
1.120
398.42
446.17
Faster 🎉 in #6279
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1
1.198
799.13
667.30
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.120 | 398.42 | 446.17 |
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.198 | 799.13 | 667.30 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 398ns | 0.233ns | 0.903ns | 0.00805 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 561ns | 0.48ns | 1.86ns | 0.00776 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 621ns | 0.231ns | 0.893ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 501ns | 0.409ns | 1.58ns | 0.00978 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 799ns | 0.426ns | 1.65ns | 0.0095 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 908ns | 0.452ns | 1.75ns | 0.104 | 0 | 0 | 658 B |
#6279 | StartFinishSpan |
net6.0 | 446ns | 0.335ns | 1.3ns | 0.00807 | 0 | 0 | 576 B |
#6279 | StartFinishSpan |
netcoreapp3.1 | 609ns | 0.619ns | 2.4ns | 0.00796 | 0 | 0 | 576 B |
#6279 | StartFinishSpan |
net472 | 591ns | 1.12ns | 4.35ns | 0.0915 | 0 | 0 | 578 B |
#6279 | StartFinishScope |
net6.0 | 487ns | 0.557ns | 2.16ns | 0.00966 | 0 | 0 | 696 B |
#6279 | StartFinishScope |
netcoreapp3.1 | 667ns | 0.64ns | 2.31ns | 0.00923 | 0 | 0 | 696 B |
#6279 | StartFinishScope |
net472 | 981ns | 0.947ns | 3.67ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6279
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.143
602.41
688.67
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.143 | 602.41 | 688.67 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 602ns | 0.221ns | 0.855ns | 0.00987 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 975ns | 0.49ns | 1.83ns | 0.00927 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.18μs | 0.483ns | 1.87ns | 0.104 | 0 | 0 | 658 B |
#6279 | RunOnMethodBegin |
net6.0 | 688ns | 0.638ns | 2.47ns | 0.00962 | 0 | 0 | 696 B |
#6279 | RunOnMethodBegin |
netcoreapp3.1 | 934ns | 0.642ns | 2.32ns | 0.00934 | 0 | 0 | 696 B |
#6279 | RunOnMethodBegin |
net472 | 1.11μs | 0.957ns | 3.71ns | 0.104 | 0 | 0 | 658 B |
Updates the package versions for integration tests.