Add additional exclusions for dependency collection #6282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
force-pushed
the
andrew/add-more-excludes-to-dependency-collector
branch
from
c81313f
to
42843f5
Compare
Datadog ReportBranch report: ✅ 0 Failed, 452249 Passed, 2739 Skipped, 19h 23m 6.47s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6282) - mean (71ms) : 65, 78
. : milestone, 71,
master - mean (72ms) : 64, 80
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (6282) - mean (1,107ms) : 1086, 1128
. : milestone, 1107,
master - mean (1,106ms) : 1085, 1127
. : milestone, 1106,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6282) - mean (108ms) : 106, 111
. : milestone, 108,
master - mean (108ms) : 106, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6282) - mean (767ms) : 743, 791
. : milestone, 767,
master - mean (771ms) : 736, 805
. : milestone, 771,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6282) - mean (91ms) : 90, 93
. : milestone, 91,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6282) - mean (720ms) : 707, 734
. : milestone, 720,
master - mean (725ms) : 709, 741
. : milestone, 725,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6282) - mean (193ms) : 182, 204
. : milestone, 193,
master - mean (191ms) : 186, 197
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6282) - mean (1,214ms) : 1190, 1238
. : milestone, 1214,
master - mean (1,211ms) : 1187, 1235
. : milestone, 1211,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6282) - mean (276ms) : 271, 281
. : milestone, 276,
master - mean (276ms) : 272, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6282) - mean (942ms) : 917, 967
. : milestone, 942,
master - mean (943ms) : 927, 959
. : milestone, 943,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6282) - mean (266ms) : 262, 270
. : milestone, 266,
master - mean (265ms) : 261, 268
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6282) - mean (922ms) : 906, 937
. : milestone, 922,
master - mean (929ms) : 911, 947
. : milestone, 929,
|
Benchmarks Report for tracer 🐌Benchmarks for #6282 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6282) (11.109M) : 0, 11109181
master (11.120M) : 0, 11120201
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6282) (7.292M) : 0, 7292012
master (7.143M) : 0, 7143247
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.563M) : 0, 7562834
section Manual
master (11.052M) : 0, 11051540
section Manual + Automatic
This PR (6282) (6.635M) : 0, 6635140
master (6.532M) : 0, 6532471
section DD_TRACE_ENABLED=0
master (10.176M) : 0, 10176174
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6282) (9.706M) : 0, 9706492
master (9.435M) : 0, 9435139
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6282) (6.394M) : 0, 6394204
master (6.301M) : 0, 6300608
section Trace stats
master (6.646M) : 0, 6646045
section Manual
master (9.564M) : 0, 9563833
section Manual + Automatic
This PR (6282) (5.878M) : 0, 5877603
master (5.897M) : 0, 5897193
section DD_TRACE_ENABLED=0
master (8.862M) : 0, 8862065
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6282) (9.669M) : 0, 9668840
master (9.832M) : 0, 9832351
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6282) (6.152M) : 0, 6152056
master (6.258M) : 0, 6258447
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.950M) : 0, 6950057
section Manual
master (9.945M) : 0, 9945109
section Manual + Automatic
This PR (6282) (5.713M) : 0, 5712638
master (5.742M) : 0, 5742033
section DD_TRACE_ENABLED=0
master (9.091M) : 0, 9091089
|
| && IsBase32Char(assemblyName[5]) | ||
| && IsBase32Char(assemblyName[6]) | ||
| && IsBase32Char(assemblyName[7])) | ||
| || (assemblyName.Length == 32 && IsHexString(assemblyName, 0)); |
There was a problem hiding this comment.
What do you think of something like assemblyName.Length >= 16? I'm thinking after a certain number of characters, if they are all hexadecimal digits, then the risk of false positives like Cafe.dll or Beef.dll is very low. Just trying to avoid having to come back and add other lengths aside from 32 later.
There was a problem hiding this comment.
Or >= 32 if you think 16 is not enough.
There was a problem hiding this comment.
Yeah, I toyed with that. I think 16+ is almost certainly going to be ok, but will use 32 for now, just for safety. In reality I wonder if we even need this check at all for Version = 0.0.0.0 🤷♂️ Whatever we do, there's going to be a certain amount of whackamole. But I guess we're unlikely to have ABadCafeFedDeafBeesBeef.dll 😄
Suggested change
| || (assemblyName.Length == 32 && IsHexString(assemblyName, 0)); | |
| || (assemblyName.Length >= 32 && IsHexString(assemblyName, 0)); |
lucaspimentel
approved these changes
Nov 14, 2024
kevingosse
approved these changes
Nov 15, 2024
andrewlock
deleted the
andrew/add-more-excludes-to-dependency-collector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Excludes 32-long hex strings with a 0.0.0.0 version number
Reason for change
We recently saw an explosion of these (we're not sure exactly what's generating them)
Implementation details
Add additional exclusion pattern for 0 version dependencies
Test coverage
Added some test cases
Other details
We could make this more general (i.e. don't worry about the 0.0.0.0 version bit), my concern is excluding "valid" assemblies accidentally