-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI Visibility] Catch some gitinfo exceptions. #6297
base: master
Are you sure you want to change the base?
[CI Visibility] Catch some gitinfo exceptions. #6297
Conversation
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 453840 Passed, 2754 Skipped, 19h 22m 25.86s Total Time ❌ Failed Tests (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6297) - mean (72ms) : 63, 81
. : milestone, 72,
master - mean (71ms) : 64, 78
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (6297) - mean (1,109ms) : 1090, 1128
. : milestone, 1109,
master - mean (1,110ms) : 1093, 1127
. : milestone, 1110,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6297) - mean (108ms) : 106, 111
. : milestone, 108,
master - mean (109ms) : 105, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (6297) - mean (765ms) : 750, 779
. : milestone, 765,
master - mean (765ms) : 749, 781
. : milestone, 765,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6297) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6297) - mean (724ms) : 708, 739
. : milestone, 724,
master - mean (726ms) : 709, 742
. : milestone, 726,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6297) - mean (191ms) : 185, 196
. : milestone, 191,
master - mean (192ms) : 186, 197
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (6297) - mean (1,208ms) : 1186, 1230
. : milestone, 1208,
master - mean (1,213ms) : 1188, 1238
. : milestone, 1213,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6297) - mean (276ms) : 273, 280
. : milestone, 276,
master - mean (277ms) : 272, 282
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6297) - mean (942ms) : 925, 959
. : milestone, 942,
master - mean (945ms) : 923, 968
. : milestone, 945,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6297) - mean (266ms) : 262, 269
. : milestone, 266,
master - mean (266ms) : 262, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6297) - mean (927ms) : 908, 945
. : milestone, 927,
master - mean (930ms) : 910, 950
. : milestone, 930,
|
Benchmarks Report for tracer 🐌Benchmarks for #6297 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 | 1.123 | 901.33 | 1,012.03 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 656ns | 0.344ns | 1.29ns | 0.0098 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 901ns | 0.432ns | 1.67ns | 0.0095 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.12μs | 1.24ns | 4.81ns | 0.104 | 0 | 0 | 658 B |
#6297 | RunOnMethodBegin |
net6.0 | 653ns | 0.623ns | 2.41ns | 0.00949 | 0 | 0 | 696 B |
#6297 | RunOnMethodBegin |
netcoreapp3.1 | 1.01μs | 0.463ns | 1.67ns | 0.00926 | 0 | 0 | 696 B |
#6297 | RunOnMethodBegin |
net472 | 1.14μs | 0.724ns | 2.8ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6297) (11.258M) : 0, 11258279
master (11.176M) : 0, 11175683
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6297) (7.296M) : 0, 7295553
master (7.160M) : 0, 7159539
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.525M) : 0, 7524795
section Manual
master (11.175M) : 0, 11174586
section Manual + Automatic
This PR (6297) (6.788M) : 0, 6787652
master (6.674M) : 0, 6673710
section DD_TRACE_ENABLED=0
master (10.161M) : 0, 10160529
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6297) (9.595M) : 0, 9595224
master (9.707M) : 0, 9707387
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6297) (6.428M) : 0, 6427972
master (6.410M) : 0, 6409836
section Trace stats
master (6.699M) : 0, 6698791
section Manual
master (9.608M) : 0, 9608059
section Manual + Automatic
This PR (6297) (5.883M) : 0, 5883455
master (5.927M) : 0, 5926951
section DD_TRACE_ENABLED=0
master (8.718M) : 0, 8718018
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6297) (10.407M) : 0, 10406611
master (9.917M) : 0, 9916570
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6297) (6.903M) : 0, 6903181
master (6.435M) : 0, 6435340
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.241M) : 0, 7241272
section Manual
master (9.897M) : 0, 9897359
section Manual + Automatic
This PR (6297) (6.122M) : 0, 6121637
master (5.894M) : 0, 5894026
section DD_TRACE_ENABLED=0
master (9.318M) : 0, 9317576
|
Summary of changes
This PR ensures we capture all possible exception while doing
GetParentGitFolder
Reason for change
I've seen some exceptions in the Error tracking page.
Implementation details
try/catch everywhere....