Add support for npgsql 10 #7855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added
area:automatic-instrumentation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7855) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7855) - mean (75ms) : 72, 79
master - mean (75ms) : 70, 81
section Bailout
This PR (7855) - mean (81ms) : 75, 87
master - mean (79ms) : 75, 83
section CallTarget+Inlining+NGEN
This PR (7855) - mean (1,068ms) : 981, 1154
master - mean (1,060ms) : 992, 1127
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7855) - mean (118ms) : 111, 125
master - mean (117ms) : 111, 123
section Bailout
This PR (7855) - mean (120ms) : 112, 128
master - mean (120ms) : 114, 125
section CallTarget+Inlining+NGEN
This PR (7855) - mean (757ms) : 710, 804
master - mean (753ms) : 720, 786
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7855) - mean (106ms) : 98, 113
master - mean (106ms) : 100, 113
section Bailout
This PR (7855) - mean (106ms) : 100, 112
master - mean (106ms) : 100, 111
section CallTarget+Inlining+NGEN
This PR (7855) - mean (707ms) : 672, 743
master - mean (704ms) : 670, 738
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7855) - mean (104ms) : 95, 113
master - mean (104ms) : 97, 111
section Bailout
This PR (7855) - mean (105ms) : 98, 111
master - mean (105ms) : 99, 110
section CallTarget+Inlining+NGEN
This PR (7855) - mean (684ms) : 656, 713
master - mean (681ms) : 649, 714
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7855) - mean (192ms) : 188, 196
master - mean (192ms) : 188, 195
section Bailout
This PR (7855) - mean (195ms) : 193, 198
master - mean (196ms) : 192, 200
section CallTarget+Inlining+NGEN
This PR (7855) - mean (1,114ms) : 1040, 1187
master - mean (1,112ms) : 1040, 1184
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7855) - mean (275ms) : 271, 280
master - mean (275ms) : 270, 280
section Bailout
This PR (7855) - mean (276ms) : 272, 279
master - mean (276ms) : 272, 280
section CallTarget+Inlining+NGEN
This PR (7855) - mean (902ms) : 849, 956
master - mean (901ms) : 854, 947
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7855) - mean (268ms) : 264, 272
master - mean (270ms) : 265, 274
section Bailout
This PR (7855) - mean (268ms) : 265, 271
master - mean (268ms) : 266, 270
section CallTarget+Inlining+NGEN
This PR (7855) - mean (886ms) : 837, 934
master - mean (888ms) : 830, 946
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7855) - mean (268ms) : 262, 274
master - mean (269ms) : 264, 274
section Bailout
This PR (7855) - mean (267ms) : 265, 270
master - mean (268ms) : 265, 271
section CallTarget+Inlining+NGEN
This PR (7855) - mean (819ms) : 797, 841
master - mean (821ms) : 798, 844
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
NachoEchevarria
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds support for recently release Npgsql 10
Reason for change
We want to support the latest versions
Implementation details
Just bump some version numbers. Note that it looks like IAST was incorrectly not supporting 9.0.0, so bumped that to latest as well.
Test coverage
Removed 8.0.0 (2 major versions back) from regular testing, as it seems unnecessary at this point (we already test 4 major versions)
Other details
10.0.0 dropped support for <= .NET 8, so updated that too