process tags : extra-careful normalization #7856

vandonr · 2025-11-24T14:35:01Z

Summary of changes

replace optential : in values before we call the normalize method, so that it can squash them with other special chars if present
truncate to 100 char to avoid transmitting unnecessary bytes

Reason for change

Implementation details

Test coverage

I need to find a way to inject arbitrary values 😬

Other details

dd-trace-dotnet-ci-bot · 2025-11-24T15:16:13Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7856) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	74.99 ± (74.96 - 75.69) ms	74.61 ± (74.61 - 75.31) ms	-0.5%	✅
.NET Framework 4.8 - Bailout
duration	79.50 ± (79.08 - 79.63) ms	79.01 ± (79.07 - 79.82) ms	-0.6%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1054.21 ± (1054.88 - 1064.33) ms	1058.23 ± (1064.75 - 1076.94) ms	+0.4%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	22.98 ± (22.90 - 23.06) ms	23.02 ± (22.94 - 23.10) ms	+0.2%	✅⬆️
process.time_to_main_ms	86.72 ± (86.39 - 87.04) ms	87.75 ± (87.34 - 88.17) ms	+1.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.92 ± (10.92 - 10.93) MB	10.93 ± (10.93 - 10.93) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	22.88 ± (22.82 - 22.94) ms	23.07 ± (23.01 - 23.13) ms	+0.8%	✅⬆️
process.time_to_main_ms	89.60 ± (89.25 - 89.94) ms	89.97 ± (89.62 - 90.32) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.96 ± (10.96 - 10.97) MB	10.98 ± (10.98 - 10.98) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	219.28 ± (218.00 - 220.56) ms	222.70 ± (221.42 - 223.98) ms	+1.6%	✅⬆️
process.time_to_main_ms	497.57 ± (496.51 - 498.63) ms	502.88 ± (501.40 - 504.36) ms	+1.1%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	47.73 ± (47.70 - 47.75) MB	47.80 ± (47.78 - 47.83) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.0%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	21.93 ± (21.85 - 22.00) ms	21.65 ± (21.58 - 21.73) ms	-1.3%	✅
process.time_to_main_ms	77.47 ± (77.12 - 77.82) ms	76.68 ± (76.29 - 77.08) ms	-1.0%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.60 ± (10.59 - 10.60) MB	10.65 ± (10.65 - 10.66) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	21.67 ± (21.61 - 21.73) ms	21.64 ± (21.57 - 21.72) ms	-0.1%	✅
process.time_to_main_ms	76.84 ± (76.51 - 77.18) ms	77.38 ± (76.98 - 77.78) ms	+0.7%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.64 ± (10.64 - 10.65) MB	10.69 ± (10.69 - 10.69) MB	+0.4%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	210.56 ± (209.19 - 211.93) ms	209.60 ± (208.25 - 210.95) ms	-0.5%	✅
process.time_to_main_ms	465.15 ± (464.20 - 466.09) ms	467.14 ± (466.00 - 468.29) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	48.04 ± (48.02 - 48.07) MB	48.09 ± (48.06 - 48.12) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.0%	✅
.NET 8 - Baseline
process.internal_duration_ms	20.00 ± (19.92 - 20.07) ms	20.04 ± (19.98 - 20.11) ms	+0.2%	✅⬆️
process.time_to_main_ms	75.42 ± (75.06 - 75.78) ms	76.52 ± (76.18 - 76.86) ms	+1.5%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.65 ± (7.65 - 7.66) MB	7.66 ± (7.65 - 7.66) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	19.90 ± (19.84 - 19.95) ms	19.87 ± (19.79 - 19.94) ms	-0.1%	✅
process.time_to_main_ms	76.06 ± (75.78 - 76.33) ms	76.62 ± (76.29 - 76.95) ms	+0.7%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.70 ± (7.70 - 7.71) MB	7.72 ± (7.71 - 7.73) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	191.06 ± (190.13 - 191.98) ms	192.71 ± (191.87 - 193.55) ms	+0.9%	✅⬆️
process.time_to_main_ms	453.35 ± (452.57 - 454.14) ms	458.97 ± (457.89 - 460.05) ms	+1.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	36.36 ± (36.31 - 36.40) MB	36.37 ± (36.33 - 36.41) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	-0.0%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	191.33 ± (191.17 - 191.92) ms	192.60 ± (192.55 - 193.30) ms	+0.7%	✅⬆️
.NET Framework 4.8 - Bailout
duration	195.81 ± (195.54 - 196.39) ms	205.72 ± (203.38 - 204.83) ms	+5.1%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1102.50 ± (1107.10 - 1116.52) ms	1126.51 ± (1127.31 - 1137.30) ms	+2.2%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	186.75 ± (186.46 - 187.04) ms	193.78 ± (193.36 - 194.20) ms	+3.8%	✅⬆️
process.time_to_main_ms	80.21 ± (80.01 - 80.41) ms	83.40 ± (83.13 - 83.67) ms	+4.0%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.11 ± (16.08 - 16.13) MB	16.11 ± (16.10 - 16.13) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	20 ± (19 - 20)	20 ± (20 - 20)	+0.3%	✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms	186.61 ± (186.31 - 186.90) ms	190.48 ± (190.00 - 190.95) ms	+2.1%	✅⬆️
process.time_to_main_ms	81.47 ± (81.34 - 81.60) ms	83.43 ± (83.21 - 83.65) ms	+2.4%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.17 ± (16.14 - 16.20) MB	16.20 ± (16.18 - 16.22) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 21)	21 ± (21 - 21)	+0.6%	✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	399.27 ± (396.73 - 401.82) ms	404.17 ± (401.48 - 406.85) ms	+1.2%	✅⬆️
process.time_to_main_ms	468.60 ± (467.86 - 469.34) ms	481.45 ± (480.35 - 482.56) ms	+2.7%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	58.59 ± (58.47 - 58.71) MB	58.76 ± (58.65 - 58.87) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	30 ± (29 - 30)	29 ± (29 - 30)	-0.1%	✅
.NET 6 - Baseline
process.internal_duration_ms	191.50 ± (191.19 - 191.80) ms	193.18 ± (192.78 - 193.59) ms	+0.9%	✅⬆️
process.time_to_main_ms	69.85 ± (69.68 - 70.02) ms	70.04 ± (69.87 - 70.21) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	15.89 ± (15.72 - 16.06) MB	16.38 ± (16.34 - 16.43) MB	+3.1%	✅⬆️
runtime.dotnet.threads.count	18 ± (18 - 18)	19 ± (19 - 19)	+5.1%	✅⬆️
.NET 6 - Bailout
process.internal_duration_ms	190.10 ± (189.89 - 190.32) ms	191.33 ± (191.06 - 191.60) ms	+0.6%	✅⬆️
process.time_to_main_ms	70.42 ± (70.35 - 70.49) ms	70.95 ± (70.85 - 71.05) ms	+0.8%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.24 ± (16.10 - 16.38) MB	16.29 ± (16.17 - 16.40) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 19)	20 ± (19 - 20)	+2.6%	✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	415.11 ± (411.93 - 418.28) ms	413.87 ± (410.94 - 416.79) ms	-0.3%	✅
process.time_to_main_ms	439.76 ± (439.25 - 440.27) ms	441.67 ± (441.06 - 442.28) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	58.68 ± (58.53 - 58.83) MB	58.90 ± (58.77 - 59.03) MB	+0.4%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.1%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	189.85 ± (189.48 - 190.22) ms	190.77 ± (190.41 - 191.13) ms	+0.5%	✅⬆️
process.time_to_main_ms	69.41 ± (69.22 - 69.60) ms	69.45 ± (69.28 - 69.62) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.79 ± (11.77 - 11.81) MB	11.74 ± (11.71 - 11.77) MB	-0.4%	✅
runtime.dotnet.threads.count	18 ± (18 - 18)	18 ± (18 - 18)	+0.0%	✅⬆️
.NET 8 - Bailout
process.internal_duration_ms	188.25 ± (188.02 - 188.49) ms	190.02 ± (189.66 - 190.39) ms	+0.9%	✅⬆️
process.time_to_main_ms	70.20 ± (70.09 - 70.31) ms	70.52 ± (70.37 - 70.66) ms	+0.5%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.85 ± (11.78 - 11.91) MB	11.84 ± (11.81 - 11.87) MB	-0.1%	✅
runtime.dotnet.threads.count	19 ± (18 - 19)	19 ± (19 - 19)	+2.5%	✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	363.66 ± (362.36 - 364.96) ms	364.79 ± (363.36 - 366.23) ms	+0.3%	✅⬆️
process.time_to_main_ms	427.55 ± (427.04 - 428.07) ms	428.47 ± (427.93 - 429.01) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	47.87 ± (47.83 - 47.90) MB	47.84 ± (47.81 - 47.87) MB	-0.1%	✅
runtime.dotnet.threads.count	29 ± (29 - 29)	29 ± (29 - 29)	-0.2%	✅

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7856) - mean (75ms)  : 70, 80
    master - mean (75ms)  : 70, 81

    section Bailout
    This PR (7856) - mean (79ms)  : 74, 85
    master - mean (79ms)  : 75, 83

    section CallTarget+Inlining+NGEN
    This PR (7856) - mean (1,071ms)  : 981, 1161
    master - mean (1,060ms)  : 992, 1127

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7856) - mean (118ms)  : 109, 127
    master - mean (117ms)  : 111, 123

    section Bailout
    This PR (7856) - mean (121ms)  : 113, 128
    master - mean (120ms)  : 114, 125

    section CallTarget+Inlining+NGEN
    This PR (7856) - mean (767ms)  : 728, 806
    master - mean (753ms)  : 720, 786

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7856) - mean (105ms)  : 98, 112
    master - mean (106ms)  : 100, 113

    section Bailout
    This PR (7856) - mean (106ms)  : 98, 114
    master - mean (106ms)  : 100, 111

    section CallTarget+Inlining+NGEN
    This PR (7856) - mean (711ms)  : 668, 754
    master - mean (704ms)  : 670, 738

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7856) - mean (105ms)  : 99, 111
    master - mean (104ms)  : 97, 111

    section Bailout
    This PR (7856) - mean (105ms)  : 99, 111
    master - mean (105ms)  : 99, 110

    section CallTarget+Inlining+NGEN
    This PR (7856) - mean (690ms)  : 663, 717
    master - mean (681ms)  : 649, 714

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7856) - mean (193ms)  : 189, 197
    master - mean (192ms)  : 188, 195

    section Bailout
    This PR (7856) - mean (204ms)  : 193, 215
    master - mean (196ms)  : 192, 200

    section CallTarget+Inlining+NGEN
    This PR (7856) - mean (1,132ms)  : 1060, 1204
    master - mean (1,112ms)  : 1040, 1184

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7856) - mean (286ms)  : 274, 298
    master - mean (275ms)  : 270, 280

    section Bailout
    This PR (7856) - mean (283ms)  : 274, 291
    master - mean (276ms)  : 272, 280

    section CallTarget+Inlining+NGEN
    This PR (7856) - mean (926ms)  : 872, 980
    master - mean (901ms)  : 854, 947

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7856) - mean (271ms)  : 264, 279
    master - mean (270ms)  : 265, 274

    section Bailout
    This PR (7856) - mean (270ms)  : 267, 274
    master - mean (268ms)  : 266, 270

    section CallTarget+Inlining+NGEN
    This PR (7856) - mean (888ms)  : 834, 943
    master - mean (888ms)  : 830, 946

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7856) - mean (270ms)  : 264, 276
    master - mean (269ms)  : 264, 274

    section Bailout
    This PR (7856) - mean (270ms)  : 265, 275
    master - mean (268ms)  : 265, 271

    section CallTarget+Inlining+NGEN
    This PR (7856) - mean (825ms)  : 803, 846
    master - mean (821ms)  : 798, 844

process tags : extra-careful normalization

d9d5df2

vandonr requested a review from a team as a code owner November 24, 2025 14:35

github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Nov 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

process tags : extra-careful normalization #7856

process tags : extra-careful normalization #7856

vandonr commented Nov 24, 2025

Uh oh!

dd-trace-dotnet-ci-bot bot commented Nov 24, 2025

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

process tags : extra-careful normalization #7856

Are you sure you want to change the base?

process tags : extra-careful normalization #7856

Conversation

vandonr commented Nov 24, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

dd-trace-dotnet-ci-bot bot commented Nov 24, 2025

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants