Pool unionmap for log injection #9555

amarziali · 2025-09-17T14:17:07Z

What Does This Do

UnionMaps are used to provide a multimap view backed on original logger's mdc.

The mdc is used to be bound to a thread locality. In recent heap dumps I noticed that we largely allocate instances of this class. Specifically wrt MDC, those objects can be pooled

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-official · 2025-09-17T14:40:13Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 57.94% (-0.01%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: e94561b | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-09-17T14:50:14Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/test-union
git_commit_date	1759321427	1759325278
git_commit_sha	`450f7b5`	`e94561b`
release_version	1.54.0-SNAPSHOT~450f7b5139	1.54.0-SNAPSHOT~e94561b73a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1759326992	1759326992
ci_job_id	1157279005	1157279005
ci_pipeline_id	78068052	78068052
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-8x6f4kyh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-8x6f4kyh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~e94561b73a, baseline=1.54.0-SNAPSHOT~450f7b5139

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1014696
Total [baseline] (8.598 s) : 0, 8597901
Agent [candidate] (1.014 s) : 0, 1014438
Total [candidate] (8.66 s) : 0, 8659593
section iast
Agent [baseline] (1.147 s) : 0, 1147037
Total [baseline] (9.213 s) : 0, 9213452
Agent [candidate] (1.148 s) : 0, 1147688
Total [candidate] (9.213 s) : 0, 9213199

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.015 s	-
Agent	iast	1.147 s	132.341 ms (13.0%)
Total	tracing	8.598 s	-
Total	iast	9.213 s	615.551 ms (7.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.014 s	-
Agent	iast	1.148 s	133.249 ms (13.1%)
Total	tracing	8.66 s	-
Total	iast	9.213 s	553.606 ms (6.4%)

gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~e94561b73a, baseline=1.54.0-SNAPSHOT~450f7b5139

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (690.684 ms) : 0, 690684
BytebuddyAgent [candidate] (690.284 ms) : 0, 690284
GlobalTracer [baseline] (242.983 ms) : 0, 242983
GlobalTracer [candidate] (243.172 ms) : 0, 243172
AppSec [baseline] (31.277 ms) : 0, 31277
AppSec [candidate] (31.456 ms) : 0, 31456
Debugger [baseline] (6.365 ms) : 0, 6365
Debugger [candidate] (6.368 ms) : 0, 6368
Remote Config [baseline] (674.102 µs) : 0, 674
Remote Config [candidate] (667.576 µs) : 0, 668
Telemetry [baseline] (9.085 ms) : 0, 9085
Telemetry [candidate] (9.15 ms) : 0, 9150
Flare Poller [baseline] (11.199 ms) : 0, 11199
Flare Poller [candidate] (10.787 ms) : 0, 10787
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (812.375 ms) : 0, 812375
BytebuddyAgent [candidate] (812.284 ms) : 0, 812284
GlobalTracer [baseline] (232.729 ms) : 0, 232729
GlobalTracer [candidate] (232.288 ms) : 0, 232288
IAST [baseline] (26.28 ms) : 0, 26280
IAST [candidate] (26.782 ms) : 0, 26782
AppSec [baseline] (33.856 ms) : 0, 33856
AppSec [candidate] (34.101 ms) : 0, 34101
Debugger [baseline] (6.036 ms) : 0, 6036
Debugger [candidate] (6.118 ms) : 0, 6118
Remote Config [baseline] (586.25 µs) : 0, 586
Remote Config [candidate] (587.869 µs) : 0, 588
Telemetry [baseline] (8.162 ms) : 0, 8162
Telemetry [candidate] (8.348 ms) : 0, 8348
Flare Poller [baseline] (4.24 ms) : 0, 4240
Flare Poller [candidate] (4.266 ms) : 0, 4266

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~e94561b73a, baseline=1.54.0-SNAPSHOT~450f7b5139

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1027766
Total [baseline] (10.789 s) : 0, 10789137
Agent [candidate] (1.021 s) : 0, 1021131
Total [candidate] (10.679 s) : 0, 10679275
section appsec
Agent [baseline] (1.197 s) : 0, 1197377
Total [baseline] (11.071 s) : 0, 11070523
Agent [candidate] (1.188 s) : 0, 1187926
Total [candidate] (11.009 s) : 0, 11008756
section iast
Agent [baseline] (1.149 s) : 0, 1149039
Total [baseline] (10.873 s) : 0, 10873000
Agent [candidate] (1.147 s) : 0, 1146704
Total [candidate] (10.951 s) : 0, 10950580
section profiling
Agent [baseline] (1.166 s) : 0, 1165735
Total [baseline] (11.158 s) : 0, 11158138
Agent [candidate] (1.156 s) : 0, 1156371
Total [candidate] (11.009 s) : 0, 11009126

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.028 s	-
Agent	appsec	1.197 s	169.611 ms (16.5%)
Agent	iast	1.149 s	121.273 ms (11.8%)
Agent	profiling	1.166 s	137.969 ms (13.4%)
Total	tracing	10.789 s	-
Total	appsec	11.071 s	281.386 ms (2.6%)
Total	iast	10.873 s	83.864 ms (0.8%)
Total	profiling	11.158 s	369.001 ms (3.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	appsec	1.188 s	166.795 ms (16.3%)
Agent	iast	1.147 s	125.573 ms (12.3%)
Agent	profiling	1.156 s	135.24 ms (13.2%)
Total	tracing	10.679 s	-
Total	appsec	11.009 s	329.481 ms (3.1%)
Total	iast	10.951 s	271.305 ms (2.5%)
Total	profiling	11.009 s	329.851 ms (3.1%)

gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~e94561b73a, baseline=1.54.0-SNAPSHOT~450f7b5139

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (700.729 ms) : 0, 700729
BytebuddyAgent [candidate] (694.319 ms) : 0, 694319
GlobalTracer [baseline] (246.019 ms) : 0, 246019
GlobalTracer [candidate] (244.451 ms) : 0, 244451
AppSec [baseline] (31.741 ms) : 0, 31741
AppSec [candidate] (31.732 ms) : 0, 31732
Debugger [baseline] (6.49 ms) : 0, 6490
Debugger [candidate] (6.435 ms) : 0, 6435
Remote Config [baseline] (687.37 µs) : 0, 687
Remote Config [candidate] (697.507 µs) : 0, 698
Telemetry [baseline] (9.136 ms) : 0, 9136
Telemetry [candidate] (9.09 ms) : 0, 9090
Flare Poller [baseline] (10.124 ms) : 0, 10124
Flare Poller [candidate] (11.736 ms) : 0, 11736
section appsec
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (721.583 ms) : 0, 721583
BytebuddyAgent [candidate] (714.569 ms) : 0, 714569
GlobalTracer [baseline] (236.291 ms) : 0, 236291
GlobalTracer [candidate] (234.443 ms) : 0, 234443
IAST [baseline] (25.007 ms) : 0, 25007
IAST [candidate] (24.829 ms) : 0, 24829
AppSec [baseline] (172.118 ms) : 0, 172118
AppSec [candidate] (171.838 ms) : 0, 171838
Debugger [baseline] (6.037 ms) : 0, 6037
Debugger [candidate] (6.039 ms) : 0, 6039
Remote Config [baseline] (629.752 µs) : 0, 630
Remote Config [candidate] (636.042 µs) : 0, 636
Telemetry [baseline] (8.977 ms) : 0, 8977
Telemetry [candidate] (9.042 ms) : 0, 9042
Flare Poller [baseline] (3.988 ms) : 0, 3988
Flare Poller [candidate] (4.034 ms) : 0, 4034
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (813.956 ms) : 0, 813956
BytebuddyAgent [candidate] (813.147 ms) : 0, 813147
GlobalTracer [baseline] (232.956 ms) : 0, 232956
GlobalTracer [candidate] (231.708 ms) : 0, 231708
IAST [baseline] (26.059 ms) : 0, 26059
IAST [candidate] (26.041 ms) : 0, 26041
AppSec [baseline] (34.089 ms) : 0, 34089
AppSec [candidate] (33.79 ms) : 0, 33790
Debugger [baseline] (5.988 ms) : 0, 5988
Debugger [candidate] (6.021 ms) : 0, 6021
Remote Config [baseline] (588.815 µs) : 0, 589
Remote Config [candidate] (579.424 µs) : 0, 579
Telemetry [baseline] (8.178 ms) : 0, 8178
Telemetry [candidate] (8.22 ms) : 0, 8220
Flare Poller [baseline] (4.181 ms) : 0, 4181
Flare Poller [candidate] (4.291 ms) : 0, 4291
section profiling
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (726.421 ms) : 0, 726421
BytebuddyAgent [candidate] (720.52 ms) : 0, 720520
GlobalTracer [baseline] (219.737 ms) : 0, 219737
GlobalTracer [candidate] (218.219 ms) : 0, 218219
AppSec [baseline] (31.925 ms) : 0, 31925
AppSec [candidate] (31.432 ms) : 0, 31432
Debugger [baseline] (6.564 ms) : 0, 6564
Debugger [candidate] (7.292 ms) : 0, 7292
Remote Config [baseline] (731.47 µs) : 0, 731
Remote Config [candidate] (758.903 µs) : 0, 759
Telemetry [baseline] (16.086 ms) : 0, 16086
Telemetry [candidate] (15.529 ms) : 0, 15529
Flare Poller [baseline] (4.994 ms) : 0, 4994
Flare Poller [candidate] (4.253 ms) : 0, 4253
ProfilingAgent [baseline] (104.869 ms) : 0, 104869
ProfilingAgent [candidate] (104.414 ms) : 0, 104414
Profiling [baseline] (105.456 ms) : 0, 105456
Profiling [candidate] (105.0 ms) : 0, 105000

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/test-union
git_commit_date	1759321427	1759325278
git_commit_sha	`450f7b5`	`e94561b`
release_version	1.54.0-SNAPSHOT~450f7b5139	1.54.0-SNAPSHOT~e94561b73a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1759326743	1759326743
ci_job_id	1157279006	1157279006
ci_pipeline_id	78068052	78068052
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-3-zu0a2kcn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-3-zu0a2kcn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 5 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load	worse [+284.376µs; +881.660µs] or [+2.029%; +6.291%]	unstable [-50.206op/s; +23.206op/s] or [-15.094%; +6.977%]	14.597ms	319.125op/s	14.014ms	332.625op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+327.038µs; +756.280µs] or [+2.990%; +6.915%]	unstable [-68.095op/s; +28.533op/s] or [-16.020%; +6.713%]	11.479ms	405.281op/s	10.937ms	425.062op/s
scenario:load:petclinic:no_agent:high_load	worse [+1.210ms; +1.887ms] or [+3.253%; +5.073%]	unstable [-13.922op/s; +3.972op/s] or [-11.077%; +3.160%]	38.750ms	120.713op/s	37.201ms	125.688op/s
scenario:load:petclinic:appsec:high_load	worse [+2.451ms; +3.401ms] or [+5.110%; +7.091%]	unstable [-12.477op/s; +1.302op/s] or [-12.785%; +1.334%]	50.886ms	92.000op/s	47.960ms	97.588op/s
scenario:load:petclinic:tracing:high_load	better [-2.069ms; -1.229ms] or [-4.492%; -2.669%]	unstable [-2.127op/s; +12.269op/s] or [-2.094%; +12.075%]	44.400ms	106.684op/s	46.049ms	101.612op/s
scenario:load:petclinic:profiling:high_load	worse [+1.749ms; +2.801ms] or [+3.602%; +5.769%]	unstable [-9.895op/s; +3.575op/s] or [-10.267%; +3.709%]	50.836ms	93.215op/s	48.560ms	96.375op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~e94561b73a, baseline=1.54.0-SNAPSHOT~450f7b5139
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.382 ms) : 4322, 4442
.   : milestone, 4382,
iast (10.155 ms) : 9984, 10325
.   : milestone, 10155,
iast_FULL (14.014 ms) : 13742, 14287
.   : milestone, 14014,
iast_GLOBAL (10.937 ms) : 10741, 11132
.   : milestone, 10937,
profiling (8.846 ms) : 8696, 8996
.   : milestone, 8846,
tracing (7.716 ms) : 7605, 7826
.   : milestone, 7716,
section candidate
no_agent (4.311 ms) : 4262, 4361
.   : milestone, 4311,
iast (10.4 ms) : 10220, 10580
.   : milestone, 10400,
iast_FULL (14.597 ms) : 14315, 14880
.   : milestone, 14597,
iast_GLOBAL (11.479 ms) : 11275, 11682
.   : milestone, 11479,
profiling (8.725 ms) : 8595, 8856
.   : milestone, 8725,
tracing (7.687 ms) : 7578, 7795
.   : milestone, 7687,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.382 ms [4.322 ms, 4.442 ms]	-
iast	10.155 ms [9.984 ms, 10.325 ms]	5.773 ms (131.7%)
iast_FULL	14.014 ms [13.742 ms, 14.287 ms]	9.632 ms (219.8%)
iast_GLOBAL	10.937 ms [10.741 ms, 11.132 ms]	6.555 ms (149.6%)
profiling	8.846 ms [8.696 ms, 8.996 ms]	4.464 ms (101.9%)
tracing	7.716 ms [7.605 ms, 7.826 ms]	3.334 ms (76.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.311 ms [4.262 ms, 4.361 ms]	-
iast	10.4 ms [10.22 ms, 10.58 ms]	6.089 ms (141.2%)
iast_FULL	14.597 ms [14.315 ms, 14.88 ms]	10.286 ms (238.6%)
iast_GLOBAL	11.479 ms [11.275 ms, 11.682 ms]	7.167 ms (166.3%)
profiling	8.725 ms [8.595 ms, 8.856 ms]	4.414 ms (102.4%)
tracing	7.687 ms [7.578 ms, 7.795 ms]	3.376 ms (78.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~e94561b73a, baseline=1.54.0-SNAPSHOT~450f7b5139
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.201 ms) : 36899, 37504
.   : milestone, 37201,
appsec (47.96 ms) : 47536, 48383
.   : milestone, 47960,
code_origins (45.836 ms) : 45426, 46247
.   : milestone, 45836,
iast (45.028 ms) : 44628, 45427
.   : milestone, 45028,
profiling (48.56 ms) : 48105, 49016
.   : milestone, 48560,
tracing (46.049 ms) : 45654, 46445
.   : milestone, 46049,
section candidate
no_agent (38.75 ms) : 38424, 39076
.   : milestone, 38750,
appsec (50.886 ms) : 50427, 51344
.   : milestone, 50886,
code_origins (44.608 ms) : 44216, 44999
.   : milestone, 44608,
iast (45.118 ms) : 44737, 45498
.   : milestone, 45118,
profiling (50.836 ms) : 50316, 51356
.   : milestone, 50836,
tracing (44.4 ms) : 44016, 44785
.   : milestone, 44400,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.201 ms [36.899 ms, 37.504 ms]	-
appsec	47.96 ms [47.536 ms, 48.383 ms]	10.759 ms (28.9%)
code_origins	45.836 ms [45.426 ms, 46.247 ms]	8.635 ms (23.2%)
iast	45.028 ms [44.628 ms, 45.427 ms]	7.826 ms (21.0%)
profiling	48.56 ms [48.105 ms, 49.016 ms]	11.359 ms (30.5%)
tracing	46.049 ms [45.654 ms, 46.445 ms]	8.848 ms (23.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	38.75 ms [38.424 ms, 39.076 ms]	-
appsec	50.886 ms [50.427 ms, 51.344 ms]	12.136 ms (31.3%)
code_origins	44.608 ms [44.216 ms, 44.999 ms]	5.858 ms (15.1%)
iast	45.118 ms [44.737 ms, 45.498 ms]	6.368 ms (16.4%)
profiling	50.836 ms [50.316 ms, 51.356 ms]	12.086 ms (31.2%)
tracing	44.4 ms [44.016 ms, 44.785 ms]	5.65 ms (14.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/test-union
git_commit_date	1759321427	1759325278
git_commit_sha	`450f7b5`	`e94561b`
release_version	1.54.0-SNAPSHOT~450f7b5139	1.54.0-SNAPSHOT~e94561b73a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1759327201	1759327201
ci_job_id	1157279007	1157279007
ci_pipeline_id	78068052	78068052
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-pey1exkq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-pey1exkq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~e94561b73a, baseline=1.54.0-SNAPSHOT~450f7b5139
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (3.636 ms) : 3425, 3847
.   : milestone, 3636,
iast (2.202 ms) : 2138, 2265
.   : milestone, 2202,
iast_GLOBAL (2.244 ms) : 2180, 2308
.   : milestone, 2244,
profiling (2.065 ms) : 2012, 2118
.   : milestone, 2065,
tracing (2.016 ms) : 1967, 2065
.   : milestone, 2016,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (3.657 ms) : 3443, 3871
.   : milestone, 3657,
iast (2.204 ms) : 2140, 2267
.   : milestone, 2204,
iast_GLOBAL (2.241 ms) : 2178, 2305
.   : milestone, 2241,
profiling (2.063 ms) : 2011, 2116
.   : milestone, 2063,
tracing (2.024 ms) : 1975, 2074
.   : milestone, 2024,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	3.636 ms [3.425 ms, 3.847 ms]	2.16 ms (146.4%)
iast	2.202 ms [2.138 ms, 2.265 ms]	725.802 µs (49.2%)
iast_GLOBAL	2.244 ms [2.18 ms, 2.308 ms]	768.092 µs (52.0%)
profiling	2.065 ms [2.012 ms, 2.118 ms]	589.321 µs (39.9%)
tracing	2.016 ms [1.967 ms, 2.065 ms]	539.982 µs (36.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.461 ms, 1.484 ms]	-
appsec	3.657 ms [3.443 ms, 3.871 ms]	2.185 ms (148.4%)
iast	2.204 ms [2.14 ms, 2.267 ms]	731.314 µs (49.7%)
iast_GLOBAL	2.241 ms [2.178 ms, 2.305 ms]	768.801 µs (52.2%)
profiling	2.063 ms [2.011 ms, 2.116 ms]	590.958 µs (40.1%)
tracing	2.024 ms [1.975 ms, 2.074 ms]	551.86 µs (37.5%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~e94561b73a, baseline=1.54.0-SNAPSHOT~450f7b5139
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.001 s) : 15001000, 15001000
.   : milestone, 15001000,
appsec (15.067 s) : 15067000, 15067000
.   : milestone, 15067000,
iast (18.531 s) : 18531000, 18531000
.   : milestone, 18531000,
iast_GLOBAL (18.165 s) : 18165000, 18165000
.   : milestone, 18165000,
profiling (15.44 s) : 15440000, 15440000
.   : milestone, 15440000,
tracing (15.3 s) : 15300000, 15300000
.   : milestone, 15300000,
section candidate
no_agent (15.21 s) : 15210000, 15210000
.   : milestone, 15210000,
appsec (15.25 s) : 15250000, 15250000
.   : milestone, 15250000,
iast (18.631 s) : 18631000, 18631000
.   : milestone, 18631000,
iast_GLOBAL (17.957 s) : 17957000, 17957000
.   : milestone, 17957000,
profiling (15.474 s) : 15474000, 15474000
.   : milestone, 15474000,
tracing (15.125 s) : 15125000, 15125000
.   : milestone, 15125000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.001 s [15.001 s, 15.001 s]	-
appsec	15.067 s [15.067 s, 15.067 s]	66.0 ms (0.4%)
iast	18.531 s [18.531 s, 18.531 s]	3.53 s (23.5%)
iast_GLOBAL	18.165 s [18.165 s, 18.165 s]	3.164 s (21.1%)
profiling	15.44 s [15.44 s, 15.44 s]	439.0 ms (2.9%)
tracing	15.3 s [15.3 s, 15.3 s]	299.0 ms (2.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.21 s [15.21 s, 15.21 s]	-
appsec	15.25 s [15.25 s, 15.25 s]	40.0 ms (0.3%)
iast	18.631 s [18.631 s, 18.631 s]	3.421 s (22.5%)
iast_GLOBAL	17.957 s [17.957 s, 17.957 s]	2.747 s (18.1%)
profiling	15.474 s [15.474 s, 15.474 s]	264.0 ms (1.7%)
tracing	15.125 s [15.125 s, 15.125 s]	-85.0 ms (-0.6%)

github-actions · 2025-09-18T08:36:37Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/log/UnionMap.java

dougqh · 2025-09-19T01:52:21Z

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/log/UnionMap.java

  }

+  @SuppressWarnings({"unchecked"})
+  public static <K, V> UnionMap<K, V> create(Map<K, V> primaryMap, Map<K, V> secondaryMap) {


I think I'd prefer some other name than create, but I'm not sure what that would be.

I changed to obtain. It looks not so bad for this kind of action

amarziali force-pushed the andrea.marziali/test-union branch from 61f2c07 to e60ce1a Compare September 17, 2025 16:04

amarziali marked this pull request as ready for review September 18, 2025 08:36

amarziali requested review from a team as code owners September 18, 2025 08:36

amarziali requested a review from smola September 18, 2025 08:36

amarziali added tag: performance Performance related changes comp: logging Tracer internal logging type: enhancement Enhancements and improvements labels Sep 18, 2025

amarziali changed the title ~~test reusing unionmaps~~ Pool unionmap for log injection Sep 18, 2025

amarziali requested review from mcculls and dougqh September 18, 2025 16:30

dougqh reviewed Sep 19, 2025

View reviewed changes

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/log/UnionMap.java Outdated Show resolved Hide resolved

dougqh reviewed Sep 19, 2025

View reviewed changes

amarziali added 2 commits September 29, 2025 14:09

Reuse unionmaps for thread bound MDCs

0e1d36a

review

4fb3661

amarziali force-pushed the andrea.marziali/test-union branch from 5a47b6f to 4fb3661 Compare September 29, 2025 12:15

Merge branch 'master' into andrea.marziali/test-union

e94561b

amarziali requested a review from dougqh October 1, 2025 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Pool unionmap for log injection #9555

Pool unionmap for log injection #9555

amarziali commented Sep 17, 2025 •

edited

Loading

Uh oh!

datadog-official bot commented Sep 17, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

Uh oh!

pr-commenter bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

dougqh Sep 19, 2025

Uh oh!

amarziali Sep 29, 2025

Uh oh!

Uh oh!

Pool unionmap for log injection #9555

Are you sure you want to change the base?

Pool unionmap for log injection #9555

Conversation

amarziali commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Sep 17, 2025 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actions bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dougqh Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

amarziali Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amarziali commented Sep 17, 2025 •

edited

Loading

datadog-official bot commented Sep 17, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

pr-commenter bot commented Sep 17, 2025 •

edited

Loading

github-actions bot commented Sep 18, 2025 •

edited

Loading