-
Notifications
You must be signed in to change notification settings - Fork 312
ensure no duplicate spans get created in http test server #9593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
49806b0
to
6e1bd4f
Compare
🎯 Code Coverage 🔗 Commit SHA: ed81a60 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~ed81a60109, baseline=1.54.0-SNAPSHOT~274d1448c2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.007 s) : 0, 1007485
Total [baseline] (8.715 s) : 0, 8714922
Agent [candidate] (1.011 s) : 0, 1010753
Total [candidate] (8.681 s) : 0, 8680575
section iast
Agent [baseline] (1.156 s) : 0, 1155988
Total [baseline] (9.319 s) : 0, 9318660
Agent [candidate] (1.147 s) : 0, 1146516
Total [candidate] (9.293 s) : 0, 9292618
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~ed81a60109, baseline=1.54.0-SNAPSHOT~274d1448c2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (689.899 ms) : 0, 689899
BytebuddyAgent [candidate] (691.485 ms) : 0, 691485
GlobalTracer [baseline] (248.279 ms) : 0, 248279
GlobalTracer [candidate] (249.288 ms) : 0, 249288
AppSec [baseline] (30.802 ms) : 0, 30802
AppSec [candidate] (31.245 ms) : 0, 31245
Debugger [baseline] (6.371 ms) : 0, 6371
Debugger [candidate] (6.41 ms) : 0, 6410
Remote Config [baseline] (676.104 µs) : 0, 676
Remote Config [candidate] (675.013 µs) : 0, 675
Telemetry [baseline] (8.939 ms) : 0, 8939
Telemetry [candidate] (9.029 ms) : 0, 9029
section iast
crashtracking [baseline] (1.495 ms) : 0, 1495
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (817.612 ms) : 0, 817612
BytebuddyAgent [candidate] (811.457 ms) : 0, 811457
GlobalTracer [baseline] (239.544 ms) : 0, 239544
GlobalTracer [candidate] (237.327 ms) : 0, 237327
IAST [baseline] (26.414 ms) : 0, 26414
IAST [candidate] (26.041 ms) : 0, 26041
AppSec [baseline] (34.152 ms) : 0, 34152
AppSec [candidate] (33.847 ms) : 0, 33847
Debugger [baseline] (6.113 ms) : 0, 6113
Debugger [candidate] (6.104 ms) : 0, 6104
Remote Config [baseline] (613.565 µs) : 0, 614
Remote Config [candidate] (597.472 µs) : 0, 597
Telemetry [baseline] (8.513 ms) : 0, 8513
Telemetry [candidate] (8.351 ms) : 0, 8351
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~ed81a60109, baseline=1.54.0-SNAPSHOT~274d1448c2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.009 s) : 0, 1009281
Total [baseline] (10.71 s) : 0, 10709683
Agent [candidate] (1.021 s) : 0, 1021084
Total [candidate] (10.804 s) : 0, 10804062
section appsec
Agent [baseline] (1.189 s) : 0, 1188897
Total [baseline] (11.037 s) : 0, 11036786
Agent [candidate] (1.196 s) : 0, 1196028
Total [candidate] (11.051 s) : 0, 11051450
section iast
Agent [baseline] (1.16 s) : 0, 1160286
Total [baseline] (11.022 s) : 0, 11022356
Agent [candidate] (1.156 s) : 0, 1155784
Total [candidate] (10.983 s) : 0, 10983181
section profiling
Agent [baseline] (1.155 s) : 0, 1155122
Total [baseline] (11.077 s) : 0, 11076645
Agent [candidate] (1.163 s) : 0, 1163327
Total [candidate] (11.068 s) : 0, 11067554
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~ed81a60109, baseline=1.54.0-SNAPSHOT~274d1448c2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (691.23 ms) : 0, 691230
BytebuddyAgent [candidate] (698.671 ms) : 0, 698671
GlobalTracer [baseline] (248.654 ms) : 0, 248654
GlobalTracer [candidate] (251.585 ms) : 0, 251585
AppSec [baseline] (30.867 ms) : 0, 30867
AppSec [candidate] (31.665 ms) : 0, 31665
Debugger [baseline] (6.343 ms) : 0, 6343
Debugger [candidate] (6.482 ms) : 0, 6482
Remote Config [baseline] (681.428 µs) : 0, 681
Remote Config [candidate] (685.759 µs) : 0, 686
Telemetry [baseline] (8.869 ms) : 0, 8869
Telemetry [candidate] (9.218 ms) : 0, 9218
section appsec
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (713.392 ms) : 0, 713392
BytebuddyAgent [candidate] (717.587 ms) : 0, 717587
GlobalTracer [baseline] (239.962 ms) : 0, 239962
GlobalTracer [candidate] (241.749 ms) : 0, 241749
IAST [baseline] (24.705 ms) : 0, 24705
IAST [candidate] (24.834 ms) : 0, 24834
AppSec [baseline] (172.323 ms) : 0, 172323
AppSec [candidate] (172.406 ms) : 0, 172406
Debugger [baseline] (6.028 ms) : 0, 6028
Debugger [candidate] (5.94 ms) : 0, 5940
Remote Config [baseline] (629.907 µs) : 0, 630
Remote Config [candidate] (632.412 µs) : 0, 632
Telemetry [baseline] (9.246 ms) : 0, 9246
Telemetry [candidate] (10.042 ms) : 0, 10042
section iast
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (820.656 ms) : 0, 820656
BytebuddyAgent [candidate] (818.101 ms) : 0, 818101
GlobalTracer [baseline] (240.354 ms) : 0, 240354
GlobalTracer [candidate] (239.288 ms) : 0, 239288
IAST [baseline] (26.756 ms) : 0, 26756
IAST [candidate] (27.061 ms) : 0, 27061
AppSec [baseline] (34.261 ms) : 0, 34261
AppSec [candidate] (33.469 ms) : 0, 33469
Debugger [baseline] (6.15 ms) : 0, 6150
Debugger [candidate] (6.1 ms) : 0, 6100
Remote Config [baseline] (606.204 µs) : 0, 606
Remote Config [candidate] (594.319 µs) : 0, 594
Telemetry [baseline] (8.466 ms) : 0, 8466
Telemetry [candidate] (8.288 ms) : 0, 8288
section profiling
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (720.761 ms) : 0, 720761
BytebuddyAgent [candidate] (726.383 ms) : 0, 726383
GlobalTracer [baseline] (224.806 ms) : 0, 224806
GlobalTracer [candidate] (225.131 ms) : 0, 225131
AppSec [baseline] (31.244 ms) : 0, 31244
AppSec [candidate] (31.585 ms) : 0, 31585
Debugger [baseline] (7.279 ms) : 0, 7279
Debugger [candidate] (6.639 ms) : 0, 6639
Remote Config [baseline] (732.706 µs) : 0, 733
Remote Config [candidate] (730.853 µs) : 0, 731
Telemetry [baseline] (15.63 ms) : 0, 15630
Telemetry [candidate] (15.752 ms) : 0, 15752
ProfilingAgent [baseline] (100.975 ms) : 0, 100975
ProfilingAgent [candidate] (102.945 ms) : 0, 102945
Profiling [baseline] (101.572 ms) : 0, 101572
Profiling [candidate] (103.566 ms) : 0, 103566
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~ed81a60109, baseline=1.54.0-SNAPSHOT~274d1448c2
dateFormat X
axisFormat %s
section baseline
no_agent (4.406 ms) : 4355, 4456
. : milestone, 4406,
iast (9.682 ms) : 9523, 9842
. : milestone, 9682,
iast_FULL (13.604 ms) : 13334, 13874
. : milestone, 13604,
iast_GLOBAL (11.269 ms) : 11065, 11472
. : milestone, 11269,
profiling (9.07 ms) : 8928, 9211
. : milestone, 9070,
tracing (7.517 ms) : 7410, 7625
. : milestone, 7517,
section candidate
no_agent (4.479 ms) : 4429, 4529
. : milestone, 4479,
iast (10.272 ms) : 10099, 10445
. : milestone, 10272,
iast_FULL (14.493 ms) : 14204, 14783
. : milestone, 14493,
iast_GLOBAL (10.324 ms) : 10146, 10502
. : milestone, 10324,
profiling (9.28 ms) : 9132, 9427
. : milestone, 9280,
tracing (7.945 ms) : 7831, 8059
. : milestone, 7945,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~ed81a60109, baseline=1.54.0-SNAPSHOT~274d1448c2
dateFormat X
axisFormat %s
section baseline
no_agent (38.183 ms) : 37881, 38486
. : milestone, 38183,
appsec (49.084 ms) : 48644, 49524
. : milestone, 49084,
code_origins (43.896 ms) : 43537, 44255
. : milestone, 43896,
iast (46.121 ms) : 45715, 46527
. : milestone, 46121,
profiling (49.968 ms) : 49443, 50492
. : milestone, 49968,
tracing (44.456 ms) : 44061, 44852
. : milestone, 44456,
section candidate
no_agent (37.515 ms) : 37215, 37816
. : milestone, 37515,
appsec (47.867 ms) : 47448, 48287
. : milestone, 47867,
code_origins (43.994 ms) : 43620, 44368
. : milestone, 43994,
iast (44.807 ms) : 44415, 45198
. : milestone, 44807,
profiling (49.91 ms) : 49425, 50395
. : milestone, 49910,
tracing (43.542 ms) : 43183, 43901
. : milestone, 43542,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~ed81a60109, baseline=1.54.0-SNAPSHOT~274d1448c2
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.7 ms) : 3484, 3916
. : milestone, 3700,
iast (2.201 ms) : 2138, 2265
. : milestone, 2201,
iast_GLOBAL (2.242 ms) : 2178, 2306
. : milestone, 2242,
profiling (2.052 ms) : 2000, 2103
. : milestone, 2052,
tracing (2.011 ms) : 1962, 2060
. : milestone, 2011,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.701 ms) : 3485, 3917
. : milestone, 3701,
iast (2.196 ms) : 2133, 2258
. : milestone, 2196,
iast_GLOBAL (2.237 ms) : 2173, 2300
. : milestone, 2237,
profiling (2.042 ms) : 1992, 2092
. : milestone, 2042,
tracing (2.021 ms) : 1972, 2070
. : milestone, 2021,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~ed81a60109, baseline=1.54.0-SNAPSHOT~274d1448c2
dateFormat X
axisFormat %s
section baseline
no_agent (14.759 s) : 14759000, 14759000
. : milestone, 14759000,
appsec (15.242 s) : 15242000, 15242000
. : milestone, 15242000,
iast (18.357 s) : 18357000, 18357000
. : milestone, 18357000,
iast_GLOBAL (18.094 s) : 18094000, 18094000
. : milestone, 18094000,
profiling (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
tracing (15.201 s) : 15201000, 15201000
. : milestone, 15201000,
section candidate
no_agent (14.744 s) : 14744000, 14744000
. : milestone, 14744000,
appsec (15.041 s) : 15041000, 15041000
. : milestone, 15041000,
iast (18.283 s) : 18283000, 18283000
. : milestone, 18283000,
iast_GLOBAL (18.14 s) : 18140000, 18140000
. : milestone, 18140000,
profiling (15.805 s) : 15805000, 15805000
. : milestone, 15805000,
tracing (15.139 s) : 15139000, 15139000
. : milestone, 15139000,
|
What Does This Do
in the http test server's
handleDistributedRequest
, add a mechanism to detect if a request has already been instrumented.Motivation
Apparently, it's possible for several threads to enter this handler at the same time for the same request, and duplicate spans would get created, resulting in flaky tests because assertions fail. This is an attempt to prevent this.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]