-
Notifications
You must be signed in to change notification settings - Fork 312
Implementation of http client request analysis for OkHttp3 #9654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎯 Code Coverage 🔗 Commit SHA: 31dd984 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~31dd984c23, baseline=1.54.0-SNAPSHOT~c442de6541
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020306
Total [baseline] (8.667 s) : 0, 8666585
Agent [candidate] (1.039 s) : 0, 1038741
Total [candidate] (8.71 s) : 0, 8710353
section iast
Agent [baseline] (1.153 s) : 0, 1152725
Total [baseline] (9.313 s) : 0, 9312628
Agent [candidate] (1.153 s) : 0, 1153031
Total [candidate] (9.271 s) : 0, 9270506
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~31dd984c23, baseline=1.54.0-SNAPSHOT~c442de6541
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.499 ms) : 0, 1499
BytebuddyAgent [baseline] (694.764 ms) : 0, 694764
BytebuddyAgent [candidate] (705.957 ms) : 0, 705957
GlobalTracer [baseline] (243.277 ms) : 0, 243277
GlobalTracer [candidate] (247.699 ms) : 0, 247699
AppSec [baseline] (32.408 ms) : 0, 32408
AppSec [candidate] (33.53 ms) : 0, 33530
Debugger [baseline] (6.33 ms) : 0, 6330
Debugger [candidate] (6.542 ms) : 0, 6542
Remote Config [baseline] (663.44 µs) : 0, 663
Remote Config [candidate] (692.771 µs) : 0, 693
Telemetry [baseline] (9.315 ms) : 0, 9315
Telemetry [candidate] (9.518 ms) : 0, 9518
Flare Poller [baseline] (10.889 ms) : 0, 10889
Flare Poller [candidate] (11.849 ms) : 0, 11849
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (815.558 ms) : 0, 815558
BytebuddyAgent [candidate] (815.319 ms) : 0, 815319
GlobalTracer [baseline] (233.694 ms) : 0, 233694
GlobalTracer [candidate] (233.683 ms) : 0, 233683
AppSec [baseline] (34.918 ms) : 0, 34918
AppSec [candidate] (35.595 ms) : 0, 35595
Debugger [baseline] (6.148 ms) : 0, 6148
Debugger [candidate] (6.114 ms) : 0, 6114
Remote Config [baseline] (590.896 µs) : 0, 591
Remote Config [candidate] (592.295 µs) : 0, 592
Telemetry [baseline] (8.548 ms) : 0, 8548
Telemetry [candidate] (8.56 ms) : 0, 8560
Flare Poller [baseline] (4.21 ms) : 0, 4210
Flare Poller [candidate] (4.189 ms) : 0, 4189
IAST [baseline] (26.315 ms) : 0, 26315
IAST [candidate] (26.361 ms) : 0, 26361
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~31dd984c23, baseline=1.54.0-SNAPSHOT~c442de6541
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021361
Total [baseline] (10.772 s) : 0, 10771643
Agent [candidate] (1.021 s) : 0, 1021237
Total [candidate] (10.746 s) : 0, 10746033
section appsec
Agent [baseline] (1.195 s) : 0, 1194591
Total [baseline] (11.05 s) : 0, 11050381
Agent [candidate] (1.194 s) : 0, 1194296
Total [candidate] (11.039 s) : 0, 11039012
section iast
Agent [baseline] (1.161 s) : 0, 1161056
Total [baseline] (10.966 s) : 0, 10965504
Agent [candidate] (1.165 s) : 0, 1164809
Total [candidate] (10.971 s) : 0, 10970837
section profiling
Agent [baseline] (1.164 s) : 0, 1164087
Total [baseline] (11.094 s) : 0, 11094258
Agent [candidate] (1.165 s) : 0, 1165455
Total [candidate] (11.03 s) : 0, 11030130
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~31dd984c23, baseline=1.54.0-SNAPSHOT~c442de6541
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (695.156 ms) : 0, 695156
BytebuddyAgent [candidate] (695.92 ms) : 0, 695920
GlobalTracer [baseline] (243.968 ms) : 0, 243968
GlobalTracer [candidate] (243.695 ms) : 0, 243695
AppSec [baseline] (32.966 ms) : 0, 32966
AppSec [candidate] (32.54 ms) : 0, 32540
Debugger [baseline] (6.383 ms) : 0, 6383
Debugger [candidate] (6.37 ms) : 0, 6370
Remote Config [baseline] (704.697 µs) : 0, 705
Remote Config [candidate] (666.676 µs) : 0, 667
Telemetry [baseline] (9.422 ms) : 0, 9422
Telemetry [candidate] (9.291 ms) : 0, 9291
Flare Poller [baseline] (10.056 ms) : 0, 10056
Flare Poller [candidate] (10.039 ms) : 0, 10039
section appsec
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (717.247 ms) : 0, 717247
BytebuddyAgent [candidate] (717.346 ms) : 0, 717346
GlobalTracer [baseline] (235.638 ms) : 0, 235638
GlobalTracer [candidate] (235.608 ms) : 0, 235608
IAST [baseline] (25.099 ms) : 0, 25099
IAST [candidate] (24.808 ms) : 0, 24808
AppSec [baseline] (173.127 ms) : 0, 173127
AppSec [candidate] (173.258 ms) : 0, 173258
Debugger [baseline] (6.09 ms) : 0, 6090
Debugger [candidate] (6.088 ms) : 0, 6088
Remote Config [baseline] (636.07 µs) : 0, 636
Remote Config [candidate] (624.954 µs) : 0, 625
Telemetry [baseline] (9.395 ms) : 0, 9395
Telemetry [candidate] (10.026 ms) : 0, 10026
Flare Poller [baseline] (4.804 ms) : 0, 4804
Flare Poller [candidate] (3.983 ms) : 0, 3983
section iast
crashtracking [baseline] (1.496 ms) : 0, 1496
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (821.639 ms) : 0, 821639
BytebuddyAgent [candidate] (823.984 ms) : 0, 823984
GlobalTracer [baseline] (235.152 ms) : 0, 235152
GlobalTracer [candidate] (235.972 ms) : 0, 235972
IAST [baseline] (26.434 ms) : 0, 26434
IAST [candidate] (26.696 ms) : 0, 26696
AppSec [baseline] (35.444 ms) : 0, 35444
AppSec [candidate] (35.513 ms) : 0, 35513
Debugger [baseline] (6.148 ms) : 0, 6148
Debugger [candidate] (6.226 ms) : 0, 6226
Remote Config [baseline] (599.697 µs) : 0, 600
Remote Config [candidate] (625.583 µs) : 0, 626
Telemetry [baseline] (8.537 ms) : 0, 8537
Telemetry [candidate] (8.787 ms) : 0, 8787
Flare Poller [baseline] (4.237 ms) : 0, 4237
Flare Poller [candidate] (4.252 ms) : 0, 4252
section profiling
crashtracking [baseline] (1.423 ms) : 0, 1423
crashtracking [candidate] (1.414 ms) : 0, 1414
BytebuddyAgent [baseline] (722.784 ms) : 0, 722784
BytebuddyAgent [candidate] (722.931 ms) : 0, 722931
GlobalTracer [baseline] (219.058 ms) : 0, 219058
GlobalTracer [candidate] (219.593 ms) : 0, 219593
AppSec [baseline] (32.743 ms) : 0, 32743
AppSec [candidate] (32.825 ms) : 0, 32825
Debugger [baseline] (6.516 ms) : 0, 6516
Debugger [candidate] (6.472 ms) : 0, 6472
Remote Config [baseline] (768.587 µs) : 0, 769
Remote Config [candidate] (791.544 µs) : 0, 792
Telemetry [baseline] (16.826 ms) : 0, 16826
Telemetry [candidate] (16.706 ms) : 0, 16706
Flare Poller [baseline] (4.107 ms) : 0, 4107
Flare Poller [candidate] (4.223 ms) : 0, 4223
ProfilingAgent [baseline] (106.874 ms) : 0, 106874
ProfilingAgent [candidate] (107.658 ms) : 0, 107658
Profiling [baseline] (107.987 ms) : 0, 107987
Profiling [candidate] (108.588 ms) : 0, 108588
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~31dd984c23, baseline=1.54.0-SNAPSHOT~c442de6541
dateFormat X
axisFormat %s
section baseline
no_agent (4.339 ms) : 4283, 4395
. : milestone, 4339,
iast (9.948 ms) : 9784, 10112
. : milestone, 9948,
iast_FULL (13.967 ms) : 13687, 14246
. : milestone, 13967,
iast_GLOBAL (10.681 ms) : 10493, 10870
. : milestone, 10681,
profiling (8.615 ms) : 8480, 8750
. : milestone, 8615,
tracing (7.752 ms) : 7634, 7870
. : milestone, 7752,
section candidate
no_agent (4.228 ms) : 4181, 4276
. : milestone, 4228,
iast (9.539 ms) : 9381, 9697
. : milestone, 9539,
iast_FULL (15.064 ms) : 14763, 15366
. : milestone, 15064,
iast_GLOBAL (10.62 ms) : 10428, 10812
. : milestone, 10620,
profiling (9.235 ms) : 9093, 9377
. : milestone, 9235,
tracing (7.75 ms) : 7632, 7867
. : milestone, 7750,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~31dd984c23, baseline=1.54.0-SNAPSHOT~c442de6541
dateFormat X
axisFormat %s
section baseline
no_agent (37.192 ms) : 36897, 37487
. : milestone, 37192,
appsec (48.232 ms) : 47808, 48656
. : milestone, 48232,
code_origins (44.39 ms) : 43999, 44781
. : milestone, 44390,
iast (44.344 ms) : 43956, 44731
. : milestone, 44344,
profiling (47.351 ms) : 46898, 47804
. : milestone, 47351,
tracing (44.365 ms) : 43999, 44731
. : milestone, 44365,
section candidate
no_agent (36.427 ms) : 36128, 36725
. : milestone, 36427,
appsec (49.032 ms) : 48594, 49471
. : milestone, 49032,
code_origins (43.929 ms) : 43550, 44309
. : milestone, 43929,
iast (47.334 ms) : 46914, 47754
. : milestone, 47334,
profiling (47.494 ms) : 47049, 47938
. : milestone, 47494,
tracing (44.805 ms) : 44426, 45184
. : milestone, 44805,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~31dd984c23, baseline=1.54.0-SNAPSHOT~c442de6541
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.725 ms) : 3506, 3944
. : milestone, 3725,
iast (2.222 ms) : 2157, 2286
. : milestone, 2222,
iast_GLOBAL (2.268 ms) : 2203, 2333
. : milestone, 2268,
profiling (2.084 ms) : 2031, 2138
. : milestone, 2084,
tracing (2.04 ms) : 1990, 2091
. : milestone, 2040,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (2.481 ms) : 2428, 2533
. : milestone, 2481,
iast (2.224 ms) : 2159, 2288
. : milestone, 2224,
iast_GLOBAL (2.255 ms) : 2191, 2320
. : milestone, 2255,
profiling (2.056 ms) : 2004, 2108
. : milestone, 2056,
tracing (2.03 ms) : 1979, 2080
. : milestone, 2030,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~31dd984c23, baseline=1.54.0-SNAPSHOT~c442de6541
dateFormat X
axisFormat %s
section baseline
no_agent (15.029 s) : 15029000, 15029000
. : milestone, 15029000,
appsec (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
iast (18.367 s) : 18367000, 18367000
. : milestone, 18367000,
iast_GLOBAL (18.235 s) : 18235000, 18235000
. : milestone, 18235000,
profiling (15.493 s) : 15493000, 15493000
. : milestone, 15493000,
tracing (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
section candidate
no_agent (14.814 s) : 14814000, 14814000
. : milestone, 14814000,
appsec (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
iast (18.671 s) : 18671000, 18671000
. : milestone, 18671000,
iast_GLOBAL (18.0 s) : 18000000, 18000000
. : milestone, 18000000,
profiling (15.296 s) : 15296000, 15296000
. : milestone, 15296000,
tracing (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
|
843aa9a
to
31dd984
Compare
What Does This Do
Adds support for downstream HTTP request and response analysis in the OkHttp3 client instrumentation.
Motivation
Enable AppSec to analyze outbound requests made through OkHttp3. This expands coverage for API security and SSRF protections, while supporting downstream traffic inspection with configurable sampling.
Additional Notes
RFC
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-58613