-
Notifications
You must be signed in to change notification settings - Fork 314
Add suffix ID to memfd file name #9796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~11b824d00c, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1025216
Total [baseline] (10.652 s) : 0, 10652191
Agent [candidate] (1.021 s) : 0, 1020862
Total [candidate] (10.726 s) : 0, 10726202
section appsec
Agent [baseline] (1.192 s) : 0, 1191821
Total [baseline] (10.845 s) : 0, 10844794
Agent [candidate] (1.199 s) : 0, 1199229
Total [candidate] (10.905 s) : 0, 10904563
section iast
Agent [baseline] (1.165 s) : 0, 1165319
Total [baseline] (11.111 s) : 0, 11111418
Agent [candidate] (1.151 s) : 0, 1151183
Total [candidate] (10.99 s) : 0, 10990210
section profiling
Agent [baseline] (1.16 s) : 0, 1160461
Total [baseline] (10.826 s) : 0, 10825656
Agent [candidate] (1.165 s) : 0, 1164540
Total [candidate] (10.945 s) : 0, 10944660
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~11b824d00c, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (697.745 ms) : 0, 697745
BytebuddyAgent [candidate] (694.17 ms) : 0, 694170
GlobalTracer [baseline] (244.046 ms) : 0, 244046
GlobalTracer [candidate] (243.506 ms) : 0, 243506
AppSec [baseline] (32.474 ms) : 0, 32474
AppSec [candidate] (32.445 ms) : 0, 32445
Debugger [baseline] (6.36 ms) : 0, 6360
Debugger [candidate] (6.304 ms) : 0, 6304
Remote Config [baseline] (684.564 µs) : 0, 685
Remote Config [candidate] (671.531 µs) : 0, 672
Telemetry [baseline] (9.299 ms) : 0, 9299
Telemetry [candidate] (9.252 ms) : 0, 9252
Flare Poller [baseline] (11.913 ms) : 0, 11913
Flare Poller [candidate] (11.895 ms) : 0, 11895
section appsec
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (716.461 ms) : 0, 716461
BytebuddyAgent [candidate] (721.999 ms) : 0, 721999
GlobalTracer [baseline] (234.32 ms) : 0, 234320
GlobalTracer [candidate] (235.974 ms) : 0, 235974
AppSec [baseline] (173.682 ms) : 0, 173682
AppSec [candidate] (174.396 ms) : 0, 174396
Debugger [baseline] (6.079 ms) : 0, 6079
Debugger [candidate] (6.108 ms) : 0, 6108
Remote Config [baseline] (636.19 µs) : 0, 636
Remote Config [candidate] (626.703 µs) : 0, 627
Telemetry [baseline] (9.351 ms) : 0, 9351
Telemetry [candidate] (8.628 ms) : 0, 8628
Flare Poller [baseline] (3.911 ms) : 0, 3911
Flare Poller [candidate] (3.909 ms) : 0, 3909
IAST [baseline] (24.768 ms) : 0, 24768
IAST [candidate] (24.898 ms) : 0, 24898
section iast
crashtracking [baseline] (1.497 ms) : 0, 1497
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (825.7 ms) : 0, 825700
BytebuddyAgent [candidate] (814.868 ms) : 0, 814868
GlobalTracer [baseline] (233.676 ms) : 0, 233676
GlobalTracer [candidate] (231.929 ms) : 0, 231929
AppSec [baseline] (35.582 ms) : 0, 35582
AppSec [candidate] (35.029 ms) : 0, 35029
Debugger [baseline] (6.195 ms) : 0, 6195
Debugger [candidate] (6.135 ms) : 0, 6135
Remote Config [baseline] (634.389 µs) : 0, 634
Remote Config [candidate] (605.297 µs) : 0, 605
Telemetry [baseline] (8.831 ms) : 0, 8831
Telemetry [candidate] (8.738 ms) : 0, 8738
Flare Poller [baseline] (4.29 ms) : 0, 4290
Flare Poller [candidate] (4.268 ms) : 0, 4268
IAST [baseline] (27.285 ms) : 0, 27285
IAST [candidate] (26.692 ms) : 0, 26692
section profiling
ProfilingAgent [baseline] (108.886 ms) : 0, 108886
ProfilingAgent [candidate] (110.658 ms) : 0, 110658
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (718.582 ms) : 0, 718582
BytebuddyAgent [candidate] (720.513 ms) : 0, 720513
GlobalTracer [baseline] (218.33 ms) : 0, 218330
GlobalTracer [candidate] (218.704 ms) : 0, 218704
AppSec [baseline] (32.225 ms) : 0, 32225
AppSec [candidate] (32.169 ms) : 0, 32169
Debugger [baseline] (7.382 ms) : 0, 7382
Debugger [candidate] (6.581 ms) : 0, 6581
Remote Config [baseline] (691.599 µs) : 0, 692
Remote Config [candidate] (677.302 µs) : 0, 677
Telemetry [baseline] (15.112 ms) : 0, 15112
Telemetry [candidate] (15.916 ms) : 0, 15916
Flare Poller [baseline] (4.158 ms) : 0, 4158
Flare Poller [candidate] (4.165 ms) : 0, 4165
Profiling [baseline] (109.505 ms) : 0, 109505
Profiling [candidate] (111.292 ms) : 0, 111292
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~11b824d00c, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018260
Total [baseline] (8.651 s) : 0, 8650620
Agent [candidate] (1.018 s) : 0, 1018270
Total [candidate] (8.649 s) : 0, 8648577
section iast
Agent [baseline] (1.152 s) : 0, 1152102
Total [baseline] (9.27 s) : 0, 9269689
Agent [candidate] (1.151 s) : 0, 1150532
Total [candidate] (9.266 s) : 0, 9266343
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~11b824d00c, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (693.532 ms) : 0, 693532
BytebuddyAgent [candidate] (692.551 ms) : 0, 692551
GlobalTracer [baseline] (242.602 ms) : 0, 242602
GlobalTracer [candidate] (242.816 ms) : 0, 242816
AppSec [baseline] (32.307 ms) : 0, 32307
AppSec [candidate] (32.194 ms) : 0, 32194
Debugger [baseline] (6.264 ms) : 0, 6264
Debugger [candidate] (6.299 ms) : 0, 6299
Remote Config [baseline] (678.358 µs) : 0, 678
Remote Config [candidate] (665.543 µs) : 0, 666
Telemetry [baseline] (9.293 ms) : 0, 9293
Telemetry [candidate] (9.339 ms) : 0, 9339
Flare Poller [baseline] (11.031 ms) : 0, 11031
Flare Poller [candidate] (11.938 ms) : 0, 11938
section iast
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (815.635 ms) : 0, 815635
BytebuddyAgent [candidate] (814.409 ms) : 0, 814409
GlobalTracer [baseline] (231.717 ms) : 0, 231717
GlobalTracer [candidate] (231.608 ms) : 0, 231608
AppSec [baseline] (35.146 ms) : 0, 35146
AppSec [candidate] (35.408 ms) : 0, 35408
Debugger [baseline] (6.153 ms) : 0, 6153
Debugger [candidate] (6.113 ms) : 0, 6113
Remote Config [baseline] (612.067 µs) : 0, 612
Remote Config [candidate] (600.803 µs) : 0, 601
Telemetry [baseline] (8.703 ms) : 0, 8703
Telemetry [candidate] (8.628 ms) : 0, 8628
Flare Poller [baseline] (4.354 ms) : 0, 4354
Flare Poller [candidate] (4.238 ms) : 0, 4238
IAST [baseline] (26.829 ms) : 0, 26829
IAST [candidate] (26.64 ms) : 0, 26640
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~11b824d00c, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section baseline
no_agent (4.401 ms) : 4347, 4455
. : milestone, 4401,
iast (9.739 ms) : 9572, 9906
. : milestone, 9739,
iast_FULL (14.355 ms) : 14066, 14644
. : milestone, 14355,
iast_GLOBAL (10.436 ms) : 10254, 10618
. : milestone, 10436,
profiling (9.135 ms) : 8995, 9276
. : milestone, 9135,
tracing (7.942 ms) : 7824, 8060
. : milestone, 7942,
section candidate
no_agent (4.417 ms) : 4368, 4467
. : milestone, 4417,
iast (9.856 ms) : 9690, 10021
. : milestone, 9856,
iast_FULL (14.824 ms) : 14530, 15117
. : milestone, 14824,
iast_GLOBAL (10.978 ms) : 10779, 11176
. : milestone, 10978,
profiling (9.022 ms) : 8873, 9171
. : milestone, 9022,
tracing (7.724 ms) : 7614, 7834
. : milestone, 7724,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~11b824d00c, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section baseline
no_agent (37.288 ms) : 36989, 37587
. : milestone, 37288,
appsec (48.579 ms) : 48145, 49014
. : milestone, 48579,
code_origins (42.29 ms) : 41925, 42654
. : milestone, 42290,
iast (45.452 ms) : 45045, 45858
. : milestone, 45452,
profiling (49.658 ms) : 49199, 50118
. : milestone, 49658,
tracing (43.468 ms) : 43082, 43854
. : milestone, 43468,
section candidate
no_agent (36.921 ms) : 36619, 37223
. : milestone, 36921,
appsec (46.052 ms) : 45651, 46453
. : milestone, 46052,
code_origins (42.619 ms) : 42246, 42992
. : milestone, 42619,
iast (44.276 ms) : 43911, 44641
. : milestone, 44276,
profiling (48.881 ms) : 48417, 49345
. : milestone, 48881,
tracing (44.38 ms) : 44000, 44759
. : milestone, 44380,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~11b824d00c, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section baseline
no_agent (14.808 s) : 14808000, 14808000
. : milestone, 14808000,
appsec (15.036 s) : 15036000, 15036000
. : milestone, 15036000,
iast (18.584 s) : 18584000, 18584000
. : milestone, 18584000,
iast_GLOBAL (18.19 s) : 18190000, 18190000
. : milestone, 18190000,
profiling (15.514 s) : 15514000, 15514000
. : milestone, 15514000,
tracing (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
section candidate
no_agent (15.286 s) : 15286000, 15286000
. : milestone, 15286000,
appsec (14.991 s) : 14991000, 14991000
. : milestone, 14991000,
iast (18.484 s) : 18484000, 18484000
. : milestone, 18484000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
. : milestone, 18003000,
profiling (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
tracing (15.229 s) : 15229000, 15229000
. : milestone, 15229000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~11b824d00c, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.526 ms) : 2472, 2581
. : milestone, 2526,
iast (2.215 ms) : 2151, 2278
. : milestone, 2215,
iast_GLOBAL (2.27 ms) : 2206, 2335
. : milestone, 2270,
profiling (2.083 ms) : 2030, 2136
. : milestone, 2083,
tracing (2.028 ms) : 1979, 2078
. : milestone, 2028,
section candidate
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.732 ms) : 3513, 3952
. : milestone, 3732,
iast (2.222 ms) : 2158, 2286
. : milestone, 2222,
iast_GLOBAL (2.256 ms) : 2191, 2320
. : milestone, 2256,
profiling (2.047 ms) : 1995, 2098
. : milestone, 2047,
tracing (2.044 ms) : 1994, 2094
. : milestone, 2044,
|
🎯 Code Coverage 🔗 Commit SHA: 11b824d | Docs | Was this helpful? Give us feedback! |
dd-trace-core/src/main/java/datadog/trace/core/servicediscovery/ServiceDiscovery.java
Outdated
Show resolved
Hide resolved
…y/ServiceDiscovery.java Co-authored-by: Stuart McCulloch <stuart.mcculloch@datadoghq.com>
What Does This Do
Fix the memfd name to include a 8 byte suffix following spec. This suffix is going to be used by the agent for: DataDog/datadog-agent#41742
Matching system-test PR that passes with this java tracer DataDog/system-tests#5545
with failing system-test against current java latest commit
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]