Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore MESSAGE_* types #3031

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Restore MESSAGE_* types #3031

merged 1 commit into from
Jan 10, 2025

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Jan 10, 2025

Description

Fix #3029

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc requested a review from a team as a code owner January 10, 2025 16:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.62%. Comparing base (9607a5f) to head (4082bcb).

❗ There is a different number of reports uploaded between BASE (9607a5f) and HEAD (4082bcb). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (9607a5f) HEAD (4082bcb)
tracer-php 11 9
appsec-extension 2 0
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #3031       +/-   ##
=============================================
- Coverage     72.92%   38.62%   -34.31%     
  Complexity     2781     2781               
=============================================
  Files           139      112       -27     
  Lines         15166    11017     -4149     
  Branches       1022        0     -1022     
=============================================
- Hits          11060     4255     -6805     
- Misses         3554     6762     +3208     
+ Partials        552        0      -552     
Flag Coverage Δ
appsec-extension ?
tracer-php 38.62% <ø> (-36.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 69 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9607a5f...4082bcb. Read the comment docs.

@felipefrancisco
Copy link

lgtm

@bwoebi bwoebi merged commit c7414c8 into master Jan 10, 2025
619 of 700 checks passed
@bwoebi bwoebi deleted the luc/restore-message-types branch January 10, 2025 23:10
@github-actions github-actions bot added this to the 1.7.0 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type consts removed in non major version bump
4 participants