Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block signals for sqlsrv_connect function #3035

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Jan 13, 2025

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.93%. Comparing base (52336c9) to head (3b59fdb).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3035      +/-   ##
============================================
- Coverage     74.80%   72.93%   -1.87%     
  Complexity     2781     2781              
============================================
  Files           112      139      +27     
  Lines         11017    15166    +4149     
  Branches          0     1022    +1022     
============================================
+ Hits           8241    11062    +2821     
- Misses         2776     3552     +776     
- Partials          0      552     +552     
Flag Coverage Δ
appsec-extension 67.99% <ø> (?)
tracer-php 74.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52336c9...3b59fdb. Read the comment docs.

@iamluc iamluc marked this pull request as ready for review January 15, 2025 13:37
@iamluc iamluc requested a review from a team as a code owner January 15, 2025 13:37
@iamluc iamluc force-pushed the luc/block-sqlsrv_connect branch from b48a4b9 to 3b59fdb Compare January 16, 2025 07:48
@iamluc iamluc merged commit 9aa53e7 into master Jan 16, 2025
695 of 744 checks passed
@iamluc iamluc deleted the luc/block-sqlsrv_connect branch January 16, 2025 09:17
@github-actions github-actions bot added this to the 1.7.0 milestone Jan 16, 2025
@realFlowControl realFlowControl modified the milestones: 1.7.0, 1.6.3 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants