Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate DD_TRACE_AGENT_URL #3050

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Validate DD_TRACE_AGENT_URL #3050

merged 1 commit into from
Jan 28, 2025

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Jan 20, 2025

This avoids panics in the sidecar and crashes in crashtracker initialization.

@bwoebi bwoebi requested review from a team as code owners January 20, 2025 15:20
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.00%. Comparing base (7a0d358) to head (b9efbb8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3050      +/-   ##
============================================
- Coverage     73.06%   73.00%   -0.06%     
  Complexity     2787     2787              
============================================
  Files           139      139              
  Lines         15272    15272              
  Branches       1043     1043              
============================================
- Hits          11158    11150       -8     
- Misses         3563     3571       +8     
  Partials        551      551              
Flag Coverage Δ
appsec-extension 68.41% <ø> (ø)
tracer-php 74.77% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0d358...b9efbb8. Read the comment docs.

This avoids panics in the sidecar and crashes in crashtracker initialization.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/validate-agent-url branch from 836afe4 to b9efbb8 Compare January 20, 2025 16:01
Copy link
Contributor

@iamluc iamluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but shouldn't we fix ddog_endpoint_from_url instead?

@bwoebi
Copy link
Collaborator Author

bwoebi commented Jan 21, 2025

@iamluc Possibly, but maybe they also don't want auto-fallback to http. PHP has that auto-fallback since a long time in the background sender (curl does it for us). Hence I mirrored this here too.

@bwoebi bwoebi merged commit 09f23bd into master Jan 28, 2025
488 of 520 checks passed
@bwoebi bwoebi deleted the bob/validate-agent-url branch January 28, 2025 11:37
@github-actions github-actions bot added this to the 1.7.0 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants