Skip to content

Conversation

@estringana
Copy link
Contributor

Description

Update json template accordingly to the minify version

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@estringana estringana marked this pull request as ready for review November 26, 2025 15:30
@estringana estringana requested a review from a team as a code owner November 26, 2025 15:30
@estringana estringana force-pushed the estringana/minify-json-blocking-error branch from 3cd7886 to 4a4d3e4 Compare November 26, 2025 15:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.69%. Comparing base (9468244) to head (e1da67b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3502   +/-   ##
=======================================
  Coverage   61.69%   61.69%           
=======================================
  Files         142      142           
  Lines       12923    12923           
  Branches     1695     1695           
=======================================
  Hits         7973     7973           
  Misses       4196     4196           
  Partials      754      754           
Files with missing lines Coverage Δ
appsec/src/extension/request_abort.c 73.86% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9468244...e1da67b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Nov 26, 2025

Benchmarks [ appsec ]

Benchmark execution time: 2025-11-28 15:42:49

Comparing candidate commit e1da67b in PR branch estringana/minify-json-blocking-error with baseline commit 9468244 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@estringana estringana force-pushed the estringana/minify-json-blocking-error branch 2 times, most recently from 16fb202 to 6f96019 Compare November 26, 2025 16:34
@estringana estringana force-pushed the estringana/minify-json-blocking-error branch from 6f96019 to ad6b3be Compare November 28, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants