Skip to content

Conversation

@cataphract
Copy link
Contributor

It had three problems:

  • Value in ns instead of microseconds
  • It would effectively be the time of the first rasp call only
  • Did not fetch the span properly where to store the tags

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 77.55102% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.73%. Comparing base (0c35caf) to head (be6b02a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
appsec/src/extension/rasp.c 71.05% 8 Missing and 3 partials ⚠️

❌ Your patch status has failed because the patch coverage (77.55%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3507      +/-   ##
==========================================
- Coverage   61.83%   61.73%   -0.11%     
==========================================
  Files         142      143       +1     
  Lines       12923    12951      +28     
  Branches     1695     1697       +2     
==========================================
+ Hits         7991     7995       +4     
- Misses       4178     4201      +23     
- Partials      754      755       +1     
Files with missing lines Coverage Δ
appsec/src/extension/ddappsec.c 77.63% <100.00%> (+0.50%) ⬆️
appsec/src/extension/request_lifecycle.c 63.75% <100.00%> (+0.14%) ⬆️
appsec/src/extension/tags.c 80.34% <ø> (+0.07%) ⬆️
appsec/src/extension/tags.h 100.00% <ø> (ø)
appsec/src/extension/rasp.c 71.05% <71.05%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c35caf...be6b02a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

It had three problems:
* Value in ns instead of microseconds
* It would effectively be the time of the first rasp call only
* Did not fetch the span properly where to store the tags
@cataphract cataphract force-pushed the glopes/fix-duration_ext branch from 39b736b to be6b02a Compare November 28, 2025 11:39
@pr-commenter
Copy link

pr-commenter bot commented Nov 28, 2025

Benchmarks [ appsec ]

Benchmark execution time: 2025-11-28 12:16:06

Comparing candidate commit be6b02a in PR branch glopes/fix-duration_ext with baseline commit 0c35caf in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants