fix(er): proactively remove exception fields [backport 2.21] #14662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dd-octo-sts[bot]](https://avatars.githubusercontent.com/in/1157446?s=80&v=4){kind=small}
## Description Exception Replay introduces an unexpected interaction with Celery when tasks raise custom exceptions with mandatory arguments. It seems that holding on to exception fields, such as __cause__, for longer than necessary causes Celery to produce bad pickled responses that are not handled by the framework. We therefore proactively clear up our tracking of the exception fields that we want to capture to prevent Celery tasks from crashing the application. (cherry picked from commit ceded88)
P403n1x87
approved these changes
Sep 22, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ceded88 from #14649 to 2.21.
Description
Exception Replay introduces an unexpected interaction with Celery when tasks raise custom exceptions with mandatory arguments. It seems that holding on to exception fields, such as cause, for longer than necessary causes Celery to produce bad pickled responses that are not handled by the framework. We therefore proactively clear up our tracking of the exception fields that we want to capture to prevent Celery tasks from crashing the application.