-
Notifications
You must be signed in to change notification settings - Fork 463
fix(llmobs): remove version setting in langchain auto prompt template #14937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(llmobs): remove version setting in langchain auto prompt template #14937
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 240 ± 3 ms. The average import time from base is: 242 ± 3 ms. The import time difference between this PR and base is: -1.8 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate jsimpher/prompts-v1-langchain-auto-user-version-undefined (3a20b27) with baseline main (c79a3a8) ❌ Test Failures (1 suite)❌ otelspan - 20/22✅ add-eventTime: ✅ 40.920ms (SLO: <47.150ms 📉 -13.2%) vs baseline: -4.0% Memory: ✅ 44.200MB (SLO: <47.000MB -6.0%) vs baseline: +4.3% ❌ add-metricsTime: ✅ 318.856ms (SLO: <344.800ms -7.5%) vs baseline: +0.5% Memory: ❌ 617.173MB (SLO: <600.000MB +2.9%) vs baseline: +8.6% ❌ add-tagsTime: ✅ 289.276ms (SLO: <314.000ms -7.9%) vs baseline: +0.7% Memory: ❌ 618.435MB (SLO: <600.000MB +3.1%) vs baseline: +8.5% ✅ get-contextTime: ✅ 80.702ms (SLO: <92.350ms 📉 -12.6%) vs baseline: +0.4% Memory: ✅ 39.775MB (SLO: <46.500MB 📉 -14.5%) vs baseline: +4.3% ✅ is-recordingTime: ✅ 38.406ms (SLO: <44.500ms 📉 -13.7%) vs baseline: -1.2% Memory: ✅ 43.622MB (SLO: <47.500MB -8.2%) vs baseline: +4.0% ✅ record-exceptionTime: ✅ 58.078ms (SLO: <67.650ms 📉 -14.1%) vs baseline: -1.0% Memory: ✅ 40.167MB (SLO: <47.000MB 📉 -14.5%) vs baseline: +4.6% ✅ set-statusTime: ✅ 44.102ms (SLO: <50.400ms 📉 -12.5%) vs baseline: -1.8% Memory: ✅ 43.579MB (SLO: <47.000MB -7.3%) vs baseline: +3.9% ✅ startTime: ✅ 38.011ms (SLO: <43.450ms 📉 -12.5%) vs baseline: ~same Memory: ✅ 43.604MB (SLO: <47.000MB -7.2%) vs baseline: +4.1% ✅ start-finishTime: ✅ 82.691ms (SLO: <88.000ms -6.0%) vs baseline: ~same Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 83.969ms (SLO: <89.000ms -5.7%) vs baseline: -0.2% Memory: ✅ 34.524MB (SLO: <46.500MB 📉 -25.8%) vs baseline: +4.9% ✅ update-nameTime: ✅ 39.351ms (SLO: <45.150ms 📉 -12.8%) vs baseline: -1.7% Memory: ✅ 43.976MB (SLO: <47.000MB -6.4%) vs baseline: +4.1% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.806ms (SLO: <22.300ms 📉 -11.2%) vs baseline: -0.4% Memory: ✅ 65.499MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% ✅ exception-replay-enabledTime: ✅ 1.337ms (SLO: <1.450ms -7.8%) vs baseline: +0.6% Memory: ✅ 64.525MB (SLO: <67.000MB -3.7%) vs baseline: +4.9% ✅ iastTime: ✅ 19.855ms (SLO: <22.250ms 📉 -10.8%) vs baseline: ~same Memory: ✅ 65.422MB (SLO: <67.000MB -2.4%) vs baseline: +4.9% ✅ profilerTime: ✅ 14.727ms (SLO: <16.550ms 📉 -11.0%) vs baseline: +0.1% Memory: ✅ 53.693MB (SLO: <54.500MB 🟡 -1.5%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 19.942ms (SLO: <21.750ms -8.3%) vs baseline: +0.1% Memory: ✅ 65.464MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 24.370ms (SLO: <28.200ms 📉 -13.6%) vs baseline: -4.2% Memory: ✅ 67.725MB (SLO: <69.500MB -2.6%) vs baseline: +5.0% ✅ tracerTime: ✅ 19.822ms (SLO: <21.750ms -8.9%) vs baseline: -0.2% Memory: ✅ 65.378MB (SLO: <67.000MB -2.4%) vs baseline: +4.7% ✅ tracer-and-profilerTime: ✅ 21.350ms (SLO: <23.500ms -9.1%) vs baseline: +0.2% Memory: ✅ 66.595MB (SLO: <67.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 18.699ms (SLO: <21.500ms 📉 -13.0%) vs baseline: -0.3% Memory: ✅ 65.451MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.031ms (SLO: <17.500ms -8.4%) vs baseline: -0.2% Memory: ✅ 65.434MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 19.870ms (SLO: <21.750ms -8.6%) vs baseline: +0.4% Memory: ✅ 71.387MB (SLO: <72.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 17.817ms (SLO: <19.650ms -9.3%) vs baseline: -0.2% Memory: ✅ 65.411MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.210ms (SLO: <20.100ms -9.4%) vs baseline: ~same Memory: ✅ 65.469MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 19.568ms (SLO: <21.500ms -9.0%) vs baseline: +0.2% Memory: ✅ 65.538MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 19.700ms (SLO: <22.000ms 📉 -10.5%) vs baseline: +0.1% Memory: ✅ 65.498MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 17.985ms (SLO: <19.850ms -9.4%) vs baseline: -0.3% Memory: ✅ 65.235MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 18.020ms (SLO: <19.400ms -7.1%) vs baseline: -0.4% Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.121ms (SLO: <19.450ms -6.8%) vs baseline: ~same Memory: ✅ 65.294MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +5.0% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.591ms (SLO: <4.750ms -3.3%) vs baseline: +0.5% Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.585ms (SLO: <6.750ms -2.4%) vs baseline: +0.2% Memory: ✅ 61.951MB (SLO: <65.000MB -4.7%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.576ms (SLO: <4.750ms -3.7%) vs baseline: +0.3% Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 45.495MB (SLO: <47.000MB -3.2%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: ~same Memory: ✅ 42.369MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.910ms (SLO: <2.100ms -9.1%) vs baseline: ~same Memory: ✅ 46.537MB (SLO: <47.000MB 🟡 -1.0%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 3.367ms (SLO: <3.650ms -7.7%) vs baseline: -0.2% Memory: ✅ 52.209MB (SLO: <53.500MB -2.4%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.355ms (SLO: <3.650ms -8.1%) vs baseline: -0.5% Memory: ✅ 52.239MB (SLO: <53.500MB -2.4%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.354ms (SLO: <3.650ms -8.1%) vs baseline: -0.3% Memory: ✅ 58.287MB (SLO: <60.000MB -2.9%) vs baseline: +4.5% 🟡 packagesupdateimporteddependencies - 24/24✅ import_manyTime: ✅ 155.259µs (SLO: <170.000µs -8.7%) vs baseline: -0.5% Memory: ✅ 37.809MB (SLO: <38.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ import_many_cachedTime: ✅ 121.656µs (SLO: <130.000µs -6.4%) vs baseline: +0.6% Memory: ✅ 37.831MB (SLO: <38.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ import_many_stdlibTime: ✅ 1.627ms (SLO: <1.750ms -7.0%) vs baseline: -0.7% Memory: ✅ 37.883MB (SLO: <38.500MB 🟡 -1.6%) vs baseline: +4.4% ✅ import_many_stdlib_cachedTime: ✅ 0.973ms (SLO: <1.100ms 📉 -11.5%) vs baseline: -1.2% Memory: ✅ 37.834MB (SLO: <38.500MB 🟡 -1.7%) vs baseline: +4.4% ✅ import_many_unknownTime: ✅ 836.507µs (SLO: <890.000µs -6.0%) vs baseline: +0.4% Memory: ✅ 38.049MB (SLO: <38.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ import_many_unknown_cachedTime: ✅ 789.630µs (SLO: <870.000µs -9.2%) vs baseline: -0.7% Memory: ✅ 37.998MB (SLO: <38.500MB 🟡 -1.3%) vs baseline: +5.3% ✅ import_oneTime: ✅ 19.746µs (SLO: <30.000µs 📉 -34.2%) vs baseline: -0.2% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.5% ✅ import_one_cacheTime: ✅ 6.288µs (SLO: <10.000µs 📉 -37.1%) vs baseline: -0.1% Memory: ✅ 37.960MB (SLO: <38.500MB 🟡 -1.4%) vs baseline: +5.3% ✅ import_one_stdlibTime: ✅ 18.708µs (SLO: <20.000µs -6.5%) vs baseline: +0.3% Memory: ✅ 37.880MB (SLO: <38.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ import_one_stdlib_cacheTime: ✅ 6.279µs (SLO: <10.000µs 📉 -37.2%) vs baseline: -0.1% Memory: ✅ 37.720MB (SLO: <38.500MB -2.0%) vs baseline: +4.5% ✅ import_one_unknownTime: ✅ 45.527µs (SLO: <50.000µs -8.9%) vs baseline: +0.2% Memory: ✅ 37.794MB (SLO: <38.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ import_one_unknown_cacheTime: ✅ 6.303µs (SLO: <10.000µs 📉 -37.0%) vs baseline: +1.1% Memory: ✅ 37.714MB (SLO: <38.500MB -2.0%) vs baseline: +4.5% 🟡 span - 26/26✅ add-eventTime: ✅ 20.429ms (SLO: <22.500ms -9.2%) vs baseline: -1.2% Memory: ✅ 49.699MB (SLO: <53.000MB -6.2%) vs baseline: +3.5% ✅ add-metricsTime: ✅ 90.365ms (SLO: <93.500ms -3.4%) vs baseline: -0.6% Memory: ✅ 690.110MB (SLO: <961.000MB 📉 -28.2%) vs baseline: +9.4% ✅ add-tagsTime: ✅ 148.123ms (SLO: <155.000ms -4.4%) vs baseline: -0.8% Memory: ✅ 690.458MB (SLO: <962.500MB 📉 -28.3%) vs baseline: +9.3% ✅ get-contextTime: ✅ 18.856ms (SLO: <20.500ms -8.0%) vs baseline: -2.2% Memory: ✅ 48.431MB (SLO: <53.000MB -8.6%) vs baseline: +3.3% ✅ is-recordingTime: ✅ 18.937ms (SLO: <20.500ms -7.6%) vs baseline: -2.2% Memory: ✅ 48.372MB (SLO: <53.000MB -8.7%) vs baseline: +3.0% ✅ record-exceptionTime: ✅ 37.883ms (SLO: <40.000ms -5.3%) vs baseline: -0.7% Memory: ✅ 42.507MB (SLO: <53.000MB 📉 -19.8%) vs baseline: +4.2% ✅ set-statusTime: ✅ 20.785ms (SLO: <22.000ms -5.5%) vs baseline: -2.0% Memory: ✅ 48.466MB (SLO: <53.000MB -8.6%) vs baseline: +3.4% ✅ startTime: ✅ 18.833ms (SLO: <20.500ms -8.1%) vs baseline: -2.5% Memory: ✅ 48.317MB (SLO: <53.000MB -8.8%) vs baseline: +2.9% ✅ start-finishTime: ✅ 51.591ms (SLO: <52.500ms 🟡 -1.7%) vs baseline: +0.8% Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.1% ✅ start-finish-telemetryTime: ✅ 53.123ms (SLO: <54.500ms -2.5%) vs baseline: +0.8% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ start-finish-traceid128Time: ✅ 54.805ms (SLO: <56.000ms -2.1%) vs baseline: +0.2% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ start-traceid128Time: ✅ 19.166ms (SLO: <22.500ms 📉 -14.8%) vs baseline: -2.1% Memory: ✅ 48.373MB (SLO: <53.000MB -8.7%) vs baseline: +3.3% ✅ update-nameTime: ✅ 19.165ms (SLO: <22.000ms 📉 -12.9%) vs baseline: -3.1% Memory: ✅ 49.129MB (SLO: <53.000MB -7.3%) vs baseline: +3.4% 📉 Performance Improvements (1 suite)📉 samplingrules - 8/8✅ average_matchTime: ✅ 137.273µs (SLO: <290.000µs 📉 -52.7%) vs baseline: -7.5% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.0% ✅ high_matchTime: ✅ 175.289µs (SLO: <480.000µs 📉 -63.5%) vs baseline: 📉 -10.6% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ low_matchTime: ✅ 99.063µs (SLO: <120.000µs 📉 -17.4%) vs baseline: -0.5% Memory: ✅ 600.947MB (SLO: <700.000MB 📉 -14.2%) vs baseline: -0.4% ✅ very_low_matchTime: ✅ 2.665ms (SLO: <8.500ms 📉 -68.6%) vs baseline: -7.9% Memory: ✅ 68.351MB (SLO: <75.000MB -8.9%) vs baseline: +2.0%
|
3a20b27
to
4ff86d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a release note and calling it a "fix" even tho we didn't announce this feature yet lol
Description
Remove setting version from auto instrumented prompt templates.
We adjusted the way we interpret explicitly set versions. Auto instrumentation should not set one.
Testing
Risks
Additional Notes