-
Notifications
You must be signed in to change notification settings - Fork 463
chore(tracing): deprecate Span.set_tag_str #14944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 244 ± 3 ms. The average import time from base is: 246 ± 4 ms. The import time difference between this PR and base is: -1.5 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate brettlangdon/deprecate.span.set_tag_str (c9e4d1f) with baseline main (9f7d187) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.408µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.9% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.1% ✅ add_inplace_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: ~same Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ add_inplace_noaspectTime: ✅ 0.317µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.275µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.8% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 1.321µs (SLO: <10.000µs 📉 -86.8%) vs baseline: ~same Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 1.604µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +4.6% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 0.617µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ bytearray_noaspectTime: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: ~same Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.6% ✅ bytes_aspectTime: ✅ 1.449µs (SLO: <10.000µs 📉 -85.5%) vs baseline: 📈 +12.6% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ bytes_noaspectTime: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.3% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.1% ✅ bytesio_aspectTime: ✅ 1.319µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +0.7% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ bytesio_noaspectTime: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 0.736µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -1.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 0.434µs (SLO: <10.000µs 📉 -95.7%) vs baseline: +0.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ casefold_aspectTime: ✅ 0.743µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 0.729µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ decode_noaspectTime: ✅ 0.421µs (SLO: <10.000µs 📉 -95.8%) vs baseline: ~same Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ encode_aspectTime: ✅ 0.708µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ encode_noaspectTime: ✅ 0.399µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.6% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 3.359µs (SLO: <10.000µs 📉 -66.4%) vs baseline: +0.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ format_map_aspectTime: ✅ 3.616µs (SLO: <10.000µs 📉 -63.8%) vs baseline: +1.2% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ format_map_noaspectTime: ✅ 0.776µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.2% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 0.600µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.2% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ index_aspectTime: ✅ 0.359µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.5% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.279µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.7% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 1.330µs (SLO: <10.000µs 📉 -86.7%) vs baseline: ~same Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ join_noaspectTime: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.2% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ ljust_aspectTime: ✅ 2.593µs (SLO: <20.000µs 📉 -87.0%) vs baseline: -1.0% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.1% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 2.446µs (SLO: <10.000µs 📉 -75.5%) vs baseline: +9.5% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.1% ✅ lower_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ lstrip_aspectTime: ✅ 2.239µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +1.9% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ lstrip_noaspectTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.4% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.8% ✅ modulo_aspectTime: ✅ 1.000µs (SLO: <10.000µs 📉 -90.0%) vs baseline: -0.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.546µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ modulo_aspect_for_bytesTime: ✅ 0.973µs (SLO: <10.000µs 📉 -90.3%) vs baseline: -0.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.209µs (SLO: <10.000µs 📉 -87.9%) vs baseline: +1.4% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.631µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 4.830µs (SLO: <10.000µs 📉 -51.7%) vs baseline: -0.7% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.6% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ repr_aspectTime: ✅ 0.916µs (SLO: <10.000µs 📉 -90.8%) vs baseline: +0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 1.927µs (SLO: <20.000µs 📉 -90.4%) vs baseline: -0.2% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 0.379µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.0% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.447µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +1.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ stringio_aspectTime: ✅ 1.764µs (SLO: <10.000µs 📉 -82.4%) vs baseline: 📈 +13.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ stringio_noaspectTime: ✅ 0.730µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +1.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 2.211µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ strip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -0.8% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ swapcase_aspectTime: ✅ 2.451µs (SLO: <10.000µs 📉 -75.5%) vs baseline: ~same Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 0.536µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +1.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 2.389µs (SLO: <10.000µs 📉 -76.1%) vs baseline: +0.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -1.3% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ translate_aspectTime: ✅ 3.295µs (SLO: <10.000µs 📉 -67.0%) vs baseline: +0.7% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ translate_noaspectTime: ✅ 1.041µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 2.315µs (SLO: <10.000µs 📉 -76.8%) vs baseline: +1.9% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.269µs (SLO: <10.000µs 📉 -57.3%) vs baseline: -1.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.083µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.6% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 6.207µs (SLO: <10.000µs 📉 -37.9%) vs baseline: +0.6% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.303µs (SLO: <10.000µs 📉 -77.0%) vs baseline: -0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.576µs (SLO: <10.000µs 📉 -64.2%) vs baseline: ~same Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 0.569µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 5.238µs (SLO: <10.000µs 📉 -47.6%) vs baseline: +6.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 1.588µs (SLO: <10.000µs 📉 -84.1%) vs baseline: ~same Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 4.139µs (SLO: <10.000µs 📉 -58.6%) vs baseline: 📈 +10.4% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.693µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.6% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 4.597µs (SLO: <10.000µs 📉 -54.0%) vs baseline: -0.2% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 1.387µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.4% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.416ms (SLO: <22.300ms -8.4%) vs baseline: -0.1% Memory: ✅ 65.121MB (SLO: <67.000MB -2.8%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.343ms (SLO: <1.450ms -7.4%) vs baseline: -0.2% Memory: ✅ 64.707MB (SLO: <67.000MB -3.4%) vs baseline: +5.0% ✅ iastTime: ✅ 20.437ms (SLO: <22.250ms -8.1%) vs baseline: -0.2% Memory: ✅ 65.197MB (SLO: <67.000MB -2.7%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.243ms (SLO: <16.550ms -7.9%) vs baseline: -0.4% Memory: ✅ 53.947MB (SLO: <54.500MB 🟡 -1.0%) vs baseline: +5.2% ✅ resource-renamingTime: ✅ 20.554ms (SLO: <21.750ms -5.5%) vs baseline: +0.2% Memory: ✅ 65.168MB (SLO: <67.000MB -2.7%) vs baseline: +4.7% ✅ span-code-originTime: ✅ 25.407ms (SLO: <28.200ms -9.9%) vs baseline: -0.2% Memory: ✅ 67.397MB (SLO: <69.500MB -3.0%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.424ms (SLO: <21.750ms -6.1%) vs baseline: ~same Memory: ✅ 65.228MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.056ms (SLO: <23.500ms -6.1%) vs baseline: ~same Memory: ✅ 66.625MB (SLO: <67.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ tracer-dont-create-db-spansTime: ✅ 19.325ms (SLO: <21.500ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 65.169MB (SLO: <66.000MB 🟡 -1.3%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.617ms (SLO: <17.500ms -5.0%) vs baseline: ~same Memory: ✅ 65.185MB (SLO: <66.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.480ms (SLO: <21.750ms -5.8%) vs baseline: +0.2% Memory: ✅ 70.975MB (SLO: <72.500MB -2.1%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.453ms (SLO: <19.650ms -6.1%) vs baseline: +0.2% Memory: ✅ 65.050MB (SLO: <67.000MB -2.9%) vs baseline: +4.6% ✅ tracer-no-databasesTime: ✅ 18.761ms (SLO: <20.100ms -6.7%) vs baseline: +0.3% Memory: ✅ 65.238MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.140ms (SLO: <21.500ms -6.3%) vs baseline: -0.5% Memory: ✅ 65.228MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.288ms (SLO: <22.000ms -7.8%) vs baseline: +0.1% Memory: ✅ 65.231MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.056ms (SLO: <19.850ms -9.0%) vs baseline: ~same Memory: ✅ 65.153MB (SLO: <66.500MB -2.0%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 18.047ms (SLO: <19.400ms -7.0%) vs baseline: -0.1% Memory: ✅ 65.161MB (SLO: <66.500MB -2.0%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.056ms (SLO: <19.450ms -7.2%) vs baseline: +0.2% Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.576ms (SLO: <4.750ms -3.7%) vs baseline: +0.2% Memory: ✅ 62.030MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.610ms (SLO: <6.750ms -2.1%) vs baseline: +0.3% Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.564ms (SLO: <4.750ms -3.9%) vs baseline: -0.3% Memory: ✅ 62.049MB (SLO: <65.000MB -4.5%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.855ms (SLO: <2.000ms -7.3%) vs baseline: +0.2% Memory: ✅ 45.495MB (SLO: <47.000MB -3.2%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.859ms (SLO: <2.000ms -7.1%) vs baseline: -0.4% Memory: ✅ 42.428MB (SLO: <49.000MB 📉 -13.4%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.911ms (SLO: <2.100ms -9.0%) vs baseline: ~same Memory: ✅ 46.557MB (SLO: <47.000MB 🟡 -0.9%) vs baseline: +5.1% ✅ resource-renamingTime: ✅ 3.367ms (SLO: <3.650ms -7.8%) vs baseline: +0.3% Memory: ✅ 52.239MB (SLO: <53.500MB -2.4%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.350ms (SLO: <3.650ms -8.2%) vs baseline: -0.1% Memory: ✅ 52.239MB (SLO: <53.500MB -2.4%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.353ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 58.261MB (SLO: <60.000MB -2.9%) vs baseline: +4.8% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.927µs (SLO: <20.000µs 📉 -85.4%) vs baseline: -0.2% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 1-count-metrics-100-timesTime: ✅ 201.219µs (SLO: <220.000µs -8.5%) vs baseline: -1.3% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.297µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -0.2% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.641µs (SLO: <220.000µs 🟡 -1.5%) vs baseline: +0.6% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 1-gauge-metric-1-timesTime: ✅ 2.237µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +2.3% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.686µs (SLO: <150.000µs -8.2%) vs baseline: ~same Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.053µs (SLO: <20.000µs 📉 -84.7%) vs baseline: -0.8% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 216.682µs (SLO: <250.000µs 📉 -13.3%) vs baseline: +0.8% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.5% ✅ 100-count-metrics-100-timesTime: ✅ 20.697ms (SLO: <22.000ms -5.9%) vs baseline: +1.1% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.0% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.285ms (SLO: <2.300ms 🟡 -0.6%) vs baseline: +0.2% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.419ms (SLO: <1.550ms -8.4%) vs baseline: +1.6% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.2% ✅ 100-rate-metrics-100-timesTime: ✅ 2.282ms (SLO: <2.550ms 📉 -10.5%) vs baseline: +3.0% Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.1% ✅ flush-1-metricTime: ✅ 4.448µs (SLO: <20.000µs 📉 -77.8%) vs baseline: -0.5% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ flush-100-metricsTime: ✅ 173.689µs (SLO: <250.000µs 📉 -30.5%) vs baseline: -1.1% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.102ms (SLO: <2.500ms 📉 -15.9%) vs baseline: -0.9% Memory: ✅ 32.971MB (SLO: <34.500MB -4.4%) vs baseline: +5.0%
|
…e.span.set_tag_str
@codex review |
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Description
We want to remove this method from the public interface, it was added as an internal only optimization, but was added to the public API.
#14943 is a follow-up change to 4.0.0 which will change/improve the typing and performance of
Span.set_tag
Testing
Risks
Additional Notes