Merge pull request #3979 from DataDog/ivoanjo/fix-profiler-specs-ruby…

…-head

[NO-TICKET] Profiling: Minor cleanup to error messages

lib/datadog/profiling/http_transport.rb

@@ -139,7 +139,7 @@ def do_export(
       end
 
       def config_without_api_key
-        [exporter_configuration[0..1]].to_h
+        "#{exporter_configuration[0]}: #{exporter_configuration[1]}"
       end
     end
   end

sig/datadog/profiling/http_transport.rbs

@@ -61,7 +61,7 @@ module Datadog
         ::String info_json,
       ) -> [:ok | :error, ::Integer | ::String]
 
-      def config_without_api_key: () -> ::Hash[:agent | :agentless, ::String]
+      def config_without_api_key: () -> ::String
     end
   end
 end

spec/datadog/profiling/http_transport_spec.rb

@@ -226,7 +226,7 @@
 
         it "logs an error message" do
           expect(Datadog.logger).to receive(:error).with(
-            'Failed to report profiling data ({:agent=>"http://192.168.0.1:12345/"}): ' \
+            "Failed to report profiling data (agent: http://192.168.0.1:12345/): " \
             "server returned unexpected HTTP 500 status code"
           )
 
@@ -252,7 +252,7 @@
 
         it "logs an error message" do
           expect(Datadog.logger).to receive(:error)
-            .with('Failed to report profiling data ({:agent=>"http://192.168.0.1:12345/"}): Some error message')
+            .with("Failed to report profiling data (agent: http://192.168.0.1:12345/): Some error message")
 
           export
         end
@@ -270,31 +270,6 @@
     end
   end
 
-  describe "#config_without_api_key" do
-    subject(:config_without_api_key) { http_transport.send(:config_without_api_key) }
-
-    context "when using agentless mode" do
-      let(:site) { "test.datadoghq.com" }
-      let(:api_key) { SecureRandom.uuid }
-
-      around do |example|
-        ClimateControl.modify("DD_PROFILING_AGENTLESS" => "true") do
-          example.run
-        end
-      end
-
-      it "returns the mode and site, but not the api key" do
-        is_expected.to eq(agentless: "test.datadoghq.com")
-      end
-    end
-
-    context "when using agent mode" do
-      it "returns the mode the agent url" do
-        is_expected.to eq(agent: "http://192.168.0.1:12345/")
-      end
-    end
-  end
-
   describe "#exporter_configuration" do
     it "returns the current exporter configuration" do
       expect(http_transport.exporter_configuration).to eq [:agent, "http://192.168.0.1:12345/"]