Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sarahchen6 committed Oct 30, 2024
1 parent dc959a3 commit ae203b9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -104,5 +104,5 @@ gem 'ffi', '~> 1.16.3', require: false

# Ruby 3.4 should be supported by strscan v3.1.1. However, the latest release of strscan is v3.1.0.
#
# TODO: Remove this v3.1.0 requirement once v3.1.1 is released.
gem 'strscan', '3.1.0' if RUBY_VERSION.start_with?('3.4.')
# TODO: Remove this once v3.1.1 is released.
gem 'strscan', git: 'https://github.com/ruby/strscan' if RUBY_VERSION.start_with?('3.4.')
3 changes: 2 additions & 1 deletion spec/datadog/core/environment/execution_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,8 @@ def test_it_does_something_useful
Open3.capture3('ruby', stdin_data: script)
end

skip('DEBUG')
# Ruby 3.4 outputs an exception instead of the information to be asserted because of the forked process.
pending('Pending for Ruby 3.4.') if RUBY_VERSION.start_with?('3.4.')
expect(err).to include('ACTUAL:true')
end
end
Expand Down
2 changes: 2 additions & 0 deletions spec/datadog/core/error_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ def call
expect(error.message).to eq('wrapper layer')

# Outer-most error first, inner-most last
# Ruby 3.4 adjusts the format of error messages and Hash#inspect renderings
# https://www.ruby-lang.org/en/news/2024/10/07/ruby-3-4-0-preview2-released/
wrapper_error_message = /in.*wrapper': wrapper layer \(RuntimeError\)/
wrapper_caller = /from.*in ['`]call'/
middle_error_message = /in.*middle': middle cause \(RuntimeError\)/
Expand Down

0 comments on commit ae203b9

Please sign in to comment.