Improve integration testing for dynamic configuration #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
commented
Jul 28, 2023
| after do | ||
| # Ensure RC background worker is stopped before we disable webmock | ||
| # to avoid failed HTTP requests, trying to make a real remote call. | ||
| Datadog.shutdown! |
There was a problem hiding this comment.
This currently generates an error in a background thread, after the test assertions finish, because the RC worker thread tries to make an unmocked RC call after we call WebMock.disable!. This PR ensures the RC worker is closed before WebMock.disable! is called.
marcotc
commented
Jul 28, 2023
| after { SemanticLogger.remove_appender(appender) } | ||
| after do | ||
| SemanticLogger.remove_appender(appender) | ||
| SemanticLogger::Logger.processor.thread.kill |
There was a problem hiding this comment.
This is a leaky thread, emitting warnings on test run.
ekump
approved these changes
Jul 28, 2023
TonyCTHsu
approved these changes
Jul 28, 2023
Codecov Report
@@ Coverage Diff @@
## master #3012 +/- ##
==========================================
+ Coverage 98.08% 98.09% +0.01%
==========================================
Files 1316 1317 +1
Lines 73819 74281 +462
Branches 3385 3387 +2
==========================================
+ Hits 72403 72865 +462
Misses 1416 1416
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the integration tests for dynamic configuration a bit less noisy and a bit less flaky.
The tests only fail for JRuby 9.2, but the noisy threads is for all versions of Ruby.