Register the OpenSearch contrib integration #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, attempting to use the integration gives the following error: `/Users/segiddins/.gem/ruby/3.2.2/gems/ddtrace-1.13.0/lib/datadog/tracing/contrib/extensions.rb:210:in `fetch_integration': 'opensearch' is not a valid integration. (Datadog::Tracing::Contrib::Extensions::Configuration::Settings::InvalidIntegrationError)`
|
@segiddins Sorry about the slip up; good catch! Seems pretty straightforward. We're under code freeze for the week, but we will work this into a bugfix release shortly after. Thank you! |
|
(The CI issue is fixed by #3021 -- there was a new release of the rake-compiler gem which we don't pin since it's only a development dependency, and broke older Rubies) |
TonyCTHsu
approved these changes
Aug 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, attempting to use the integration gives the following error:
What does this PR do?
Motivation
Failures on rubygems/rubygems.org#3976
Additional Notes
How to test the change?