Remove profiler_submission.rb benchmark #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: This PR removes the `profiler_submission.rb` benchmark. **Motivation**: This benchmark is no longer relevant, as it only tested the old Ruby profiler, and not the new CPU Profiling 2.0 profiler. The old profiler is no longer in use and will be removed soon, and I spotted this benchmark failing in the benchmarking platform and rather than fix it, I decided to remove it instead. In the future, we may want to add a benchmark to replace it, but the new profiler internals are different enough that it's non-trivial to update the existing benchmark. **Additional Notes**: Update to benchmarking platform is at DataDog/benchmarking-platform#16 (Datadog internal link). **How to test the change?**: Validate that CI is still green.
Codecov Report
@@ Coverage Diff @@
## master #3028 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 1317 1317
Lines 74362 74359 -3
Branches 3402 3402
=======================================
- Hits 72943 72942 -1
+ Misses 1419 1417 -2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TonyCTHsu
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR removes the
profiler_submission.rbbenchmark.Motivation:
This benchmark is no longer relevant, as it only tested the old Ruby profiler, and not the new CPU Profiling 2.0 profiler.
The old profiler is no longer in use and will be removed soon, and I spotted this benchmark failing in the benchmarking platform and rather than fix it, I decided to remove it instead.
In the future, we may want to add a benchmark to replace it, but the new profiler internals are different enough that it's non-trivial to update the existing benchmark.
Additional Notes:
Update to benchmarking platform is at
https://github.com/DataDog/benchmarking-platform/pull/16 (Datadog internal link).
How to test the change?:
Validate that CI is still green.