Update Elasticsearch patcher from using alias method to prepend method #3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3030 +/- ##
=======================================
Coverage 98.08% 98.09%
=======================================
Files 1301 1301
Lines 72468 72472 +4
Branches 3349 3348 -1
=======================================
+ Hits 71082 71089 +7
+ Misses 1386 1383 -3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sarahchen6
force-pushed
the
feature/elasticsearch_update
branch
3 times, most recently
from
32d301c
to
93a4e9b
Compare
…riable, passing rubocop and original unit tests.
sarahchen6
force-pushed
the
feature/elasticsearch_update
branch
from
93a4e9b
to
8c7e11f
Compare
marcotc
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the Elasticsearch patcher. Originally, the patcher was using an alias and remove method to instrument the
perform_requestmethod; now it uses the more modern prepend technique.Motivation
In an effort to update the codebase, the new patcher should be cleaner and clearer.
Additional Notes
No changes were made to the patcher_spec file.
How to test the change?
These changes can be tested by running the unit tests in
spec/datadog/tracing/contrib/elasticsearch/patcher_spec.rb, by passing Github tests, and by checking CircleCI.