Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test:Fix minor test warning #3059

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Test:Fix minor test warning #3059

merged 1 commit into from
Aug 21, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Aug 17, 2023

Addresses the warning /app/spec/datadog/tracing/contrib/support/tracer_helpers.rb:32: warning: instance variable @traces not initialized.

@marcotc marcotc requested a review from a team August 17, 2023 22:34
@marcotc marcotc self-assigned this Aug 17, 2023
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Aug 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3059 (c4f1ed9) into master (0e7da21) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3059   +/-   ##
=======================================
  Coverage   98.11%   98.12%           
=======================================
  Files        1328     1328           
  Lines       75076    75076           
  Branches     3410     3410           
=======================================
+ Hits        73662    73666    +4     
+ Misses       1414     1410    -4     
Files Changed Coverage Δ
.../datadog/tracing/contrib/support/tracer_helpers.rb 98.33% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@marcotc marcotc merged commit 13f4732 into master Aug 21, 2023
163 checks passed
@marcotc marcotc deleted the test-warn branch August 21, 2023 15:09
@github-actions github-actions bot added this to the 1.14.0 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants