Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPSEC-11052] Fix a bug with ASM span tags reporting the number of WAF failed loaded rules #3106

Merged

Conversation

GustavoCaso
Copy link
Member

@GustavoCaso GustavoCaso commented Sep 4, 2023

What does this PR do?

Fix a bug introduced on #3087

Reported the loaded rules count on the _dd.appsec.event_rules.error_count tag.

I also, added a new system test scenario on our GH actions to avoid introducing a regression again.

Motivation:

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@GustavoCaso GustavoCaso requested a review from a team September 4, 2023 15:31
@github-actions github-actions bot added appsec Application Security monitoring product integrations Involves tracing integrations labels Sep 4, 2023
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #3106 (43d2564) into master (f2c8241) will decrease coverage by 0.01%.
Report is 14 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3106      +/-   ##
==========================================
- Coverage   98.16%   98.15%   -0.01%     
==========================================
  Files        1323     1323              
  Lines       75155    75155              
  Branches     3428     3428              
==========================================
- Hits        73773    73772       -1     
- Misses       1382     1383       +1     
Files Changed Coverage Δ
.../datadog/appsec/contrib/rack/request_middleware.rb 95.55% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GustavoCaso GustavoCaso merged commit f9c30b2 into master Sep 4, 2023
165 checks passed
@GustavoCaso GustavoCaso deleted the fix-issue-with-reporting-failed-loaded-waf-rules branch September 4, 2023 15:47
@github-actions github-actions bot added this to the 1.15.0 milestone Sep 4, 2023
@GustavoCaso GustavoCaso changed the title Fix a bug with ASM span tags reporting the number of WAF failed loaded rules [APPSEC-11052] Fix a bug with ASM span tags reporting the number of WAF failed loaded rules Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants