remove variable helpers module from our configuration DSL #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
force-pushed
the
remove-variable-helpers-module-from-configuration-dsl
branch
from
31ee55a
to
a469483
Compare
GustavoCaso
force-pushed
the
remove-variable-helpers-module-from-configuration-dsl
branch
from
a469483
to
ff288e5
Compare
marcotc
approved these changes
Sep 25, 2023
GustavoCaso
deleted the
remove-variable-helpers-module-from-configuration-dsl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After adding our new configuration option DSL to support env variables and parsing them (#2987, #2988) we no longer need to include the ENV variables helpers as part of the configuration base class.
Motivation:
Keep the codebase clean and up to date
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!