Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address graphql test failure in 3.3 preview #3174

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Address graphql test failure in 3.3 preview #3174

merged 2 commits into from
Sep 29, 2023

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Sep 29, 2023 •
edited
Loading

What does this PR do?

Add racc for graphql test with Ruby 3.3 preview 2

rmosolgo/graphql-ruby#4650

@TonyCTHsu TonyCTHsu marked this pull request as ready for review September 29, 2023 12:51
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 29, 2023 12:51
@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Sep 29, 2023
ivoanjo
ivoanjo approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I think another alternative could be to add racc to the appraisal group (since that fixes the issue as I showed in the ticket), but I think this one is fine as well to "stop the bleeding" and bring our CI back to green.

@github-actions github-actions bot removed the dev/testing Involves testing processes (e.g. RSpec) label Sep 29, 2023
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/temp-disable-graphql-in-3.3 branch from e161e54 to 2a34c29 Compare September 29, 2023 13:16
@TonyCTHsu TonyCTHsu changed the title Disable graphql test in 3.3 preview Address graphql test failure in 3.3 preview Sep 29, 2023
@TonyCTHsu TonyCTHsu merged commit 1ef3cf5 into master Sep 29, 2023
176 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/temp-disable-graphql-in-3.3 branch September 29, 2023 13:42
@github-actions github-actions bot added this to the 1.15.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TonyCTHsu @ivoanjo