Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROF-9263] Add experimental support for profiling code hotspots when used with opentelemetry ruby gem #3510

Merged
10 commits merged into from
Oct 10, 2024
Merged

[PROF-9263] Add experimental support for profiling code hotspots when used with opentelemetry ruby gem #3510

10 commits merged into from
Oct 10, 2024

Commits on Sep 25, 2024

  1. [PROF-9263] First working version of getting trace identifiers from o… 

    …tel gem

Things missing:

* Specs conflict with ddtrace otel specs (need to poke at appraisals)
* Missing endpoint support
    @ivoanjo
    ivoanjo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c579077 View commit details
    Browse the repository at this point in the history

  2. Refactor otel_span_context_from to also return span 

    While we don't need the actual span object to read the span ids, we
will need it to read the endpoint names.
    @ivoanjo
    ivoanjo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    538aed9 View commit details
    Browse the repository at this point in the history

  3. Add support for collecting trace endpoint from otel spans

    @ivoanjo
    ivoanjo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1c8a9a7 View commit details
    Browse the repository at this point in the history

  4. Add coverage for trace with invalid span

    @ivoanjo
    ivoanjo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fc26465 View commit details
    Browse the repository at this point in the history

  5. Allow specs for otel sdk without ddtrace to co-exist with the ddtrace… 

    … specs

I'm... unhappy about this, but couldn't think of anything better that
wouldn't involve refactoring the ddtrace tracing otel support and
that seems even worse.
    @ivoanjo
    ivoanjo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a6164bd View commit details
    Browse the repository at this point in the history

  6. Fix specs breaking on Ruby 2.3 due to missing String#unpack1 

    Sigh old rubies...
    @ivoanjo
    ivoanjo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5dcec3f View commit details
    Browse the repository at this point in the history

  7. Add appraisal gemfiles/lockfiles for opentelemetry_otlp configuration

    @ivoanjo
    ivoanjo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    468cb13 View commit details
    Browse the repository at this point in the history

  8. Remove unneeded Rubocop config

    @ivoanjo
    ivoanjo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dd865ee View commit details
    Browse the repository at this point in the history

  9. Apply standardrb code style fixes

    @ivoanjo
    ivoanjo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    19646f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Support running in situations where Gem.loaded_specs is not available

    @ivoanjo
    ivoanjo committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6b67c03 View commit details
    Browse the repository at this point in the history