[SDTEST-409] Automatically avoid webmock stubs when sending telemetry events

lib/datadog/core/telemetry/http/adapters/net.rb

@@ -25,7 +25,7 @@ def initialize(hostname:, port: nil, timeout: DEFAULT_TIMEOUT, ssl: true)
             end
 
             def open(&block)
-              req = ::Net::HTTP.new(@hostname, @port)
+              req = net_http_client.new(@hostname, @port)
 
               req.use_ssl = @ssl
               req.open_timeout = req.read_timeout = @timeout
@@ -34,19 +34,17 @@ def open(&block)
             end
 
             def post(env)
-              begin
-                post = ::Net::HTTP::Post.new(env.path, env.headers)
-                post.body = env.body
-
-                http_response = open do |http|
-                  http.request(post)
-                end
-
-                Response.new(http_response)
-              rescue StandardError => e
-                Datadog.logger.debug("Unable to send telemetry event to agent: #{e}")
-                Telemetry::Http::InternalErrorResponse.new(e)
+              post = ::Net::HTTP::Post.new(env.path, env.headers)
+              post.body = env.body
+
+              http_response = open do |http|
+                http.request(post)
               end
+
+              Response.new(http_response)
+            rescue StandardError => e
+              Datadog.logger.debug("Unable to send telemetry event to agent: #{e}")
+              Telemetry::Http::InternalErrorResponse.new(e)
             end
 
             # Data structure for an HTTP Response
@@ -105,6 +103,14 @@ def inspect
                 "#{super}, http_response:#{http_response}"
               end
             end
+
+            private
+
+            def net_http_client
+              return ::Net::HTTP unless defined?(WebMock::HttpLibAdapters::NetHttpAdapter::OriginalNetHTTP)
+
+              WebMock::HttpLibAdapters::NetHttpAdapter::OriginalNetHTTP
+            end
           end
         end
       end

sig/datadog/core/telemetry/http/adapters/net.rbs

@@ -45,6 +45,10 @@ module Datadog
 
               def inspect: () -> ::String
             end
+
+            private
+
+            def net_http_client: () -> singleton(::Net::HTTP)
           end
         end
       end

spec/datadog/core/telemetry/http/adapters/net_spec.rb

@@ -14,7 +14,8 @@
     let(:http_connection) { instance_double(::Net::HTTP) }
 
     before do
-      allow(::Net::HTTP).to receive(:new)
+      # webmock stores real ::Net::HTTP in this constant
+      allow(::WebMock::HttpLibAdapters::NetHttpAdapter::OriginalNetHTTP).to receive(:new)
         .with(
           adapter.hostname,
           adapter.port,
@@ -90,25 +91,58 @@
   end
 
   describe '#post' do
-    include_context 'HTTP connection stub'
     include_context 'HTTP Env'
 
-    subject(:post) { adapter.post(env) }
+    context 'with stubbed Net::HTTP' do
+      include_context 'HTTP connection stub'
+
+      subject(:post) { adapter.post(env) }
+
+      let(:http_response) { double('http_response') }
 
-    let(:http_response) { double('http_response') }
+      context 'when request goes through' do
+        before { expect(http_connection).to receive(:request).and_return(http_response) }
 
-    context 'when request goes through' do
-      before { expect(http_connection).to receive(:request).and_return(http_response) }
+        it 'produces a response' do
+          is_expected.to be_a_kind_of(described_class::Response)
+          expect(post.http_response).to be(http_response)
+        end
+      end
 
-      it 'produces a response' do
-        is_expected.to be_a_kind_of(described_class::Response)
-        expect(post.http_response).to be(http_response)
+      context 'when error in connecting to agent' do
+        before { expect(http_connection).to receive(:request).and_raise(StandardError) }
+        it { expect(post).to be_a_kind_of(Datadog::Core::Telemetry::Http::InternalErrorResponse) }
       end
     end
 
-    context 'when error in connecting to agent' do
-      before { expect(http_connection).to receive(:request).and_raise(StandardError) }
-      it { expect(post).to be_a_kind_of(Datadog::Core::Telemetry::Http::InternalErrorResponse) }
+    context 'with real Net::HTTP' do
+      subject(:post) { adapter.post(env) }
+
+      let(:hostname) { 'hostname_that_doesnt_exist' }
+      let(:port) { 4444 }
+      let(:timeout) { 1 }
+      let(:expected_error) do
+        # Socket::ResolutionError is for Ruby 3.3+
+        if defined?(Socket::ResolutionError)
+          Socket::ResolutionError
+        else
+          SocketError
+        end
+      end
+
+      before do
+        WebMock.disable_net_connect!
+      end
+
+      after do
+        WebMock.allow_net_connect!
+      end
+
+      it 'makes real HTTP request and fails' do
+        response = post
+        expect(response).to be_a_kind_of(Datadog::Core::Telemetry::Http::InternalErrorResponse)
+        expect(response.error).to be_a_kind_of(expected_error)
+      end
     end
   end
 end

static-analysis.datadog.yml

@@ -2,4 +2,17 @@ schema-version: v1
 rulesets:
   - ruby-code-style
   - ruby-security
-  - ruby-best-practices
+  - ruby-best-practices:
+    rules:
+      symbols-as-keys:
+        ignore:
+          - "**"
+      hash-fetch:
+        ignore:
+          - "**"
+      percent-w:
+        ignore:
+          - spec/**/*
+      no-optional-hash-params:
+        ignore:
+          - "**"

vendor/rbs/webmock/0/webmock.rbs

@@ -4,6 +4,8 @@ module WebMock
       def self.enable!: -> void
 
       def self.disable!: -> void
+
+      OriginalNetHTTP: singleton(::Net::HTTP)
     end
   end
 end