fix(errors): revert breaking change

[mabdinur]

What does this PR do?

#3776 renamed the Error.set_error method to set_error_tags. Renaming a method in the public api is a breaking change. This PR reverts this breaking change and adds deprecation warning.

Motivation:

Additional Notes:

How to test the change?

Unsure? Have a question? Request a review!

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-07-19 15:11:43

Comparing candidate commit dcda9d0 in PR branch munir/revert-api-breaking-change with baseline commit 2f089cd in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 2 unstable metrics.

scenario:Tracing.log_correlation

• 🟩 throughput [+2637.583op/s; +2886.706op/s] or [+2.302%; +2.520%]

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 97.89%. Comparing base (2f089cd) to head (dcda9d0).

Files	Patch %	Lines
spec/datadog/tracing/metadata/errors_spec.rb	8.33%	11 Missing ⚠️
lib/datadog/tracing/metadata/errors.rb	25.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3796      +/-   ##
==========================================
- Coverage   97.91%   97.89%   -0.03%     
==========================================
  Files        1248     1248              
  Lines       75192    75197       +5     
  Branches     3638     3638              
==========================================
- Hits        73628    73615      -13     
- Misses       1564     1582      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marcotc]

Why is set_error deprecated?

[mabdinur]

Errors.set_error shadows SpanOperation.set_error. SpanOperation.set_error always sets the status on a Span to error. In OpenTelemetry we need to decouple setting error tags from setting error statuses. To do this I renamed Errors.set_error to Errors.set_error_tags in a previous PR. This was a breaking change. Here I am adding set_error_tags back but deprecating it to avoid maintaining two methods that do the exact same thing.