DEBUG-2657 remove benchmark dogstatsd reporting & run_forever #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-datadog
changed the title
ivoanjo
approved these changes
Aug 6, 2024
p-datadog
force-pushed
the
benchmark-remove-old-code
branch
from
814c8bf
to
1b93ea5
Compare
BenchmarksBenchmark execution time: 2024-08-06 17:04:22 Comparing candidate commit 1b93ea5 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 22 metrics, 2 unstable metrics. scenario:stack collector
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes benchmark reporting to dogstatsd and run_forever functionality. Both were used previously in profiling benchmarks but are not being used currently and are not planned to be used going forward.
Motivation:
In #3787 I attempted to reduce code duplication in benchmarks but I had to build support for both of the features that this PR proposes to remove. Since this functionality is not needed, it does not make sense to spend effort to maintain it.
Additional Notes:
How to test the change?
Micro-benchmark dashboard
Unsure? Have a question? Request a review!