Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport disable persist credentials #3877

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Backport disable persist credentials #3877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f37a23
Disable persist-credentials when checking out system tests
TonyCTHsu Aug 30, 2024
abc8342
Backport lib injection test
TonyCTHsu Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/lib-injection.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,20 +50,21 @@ jobs:
env:
TEST_LIBRARY: ruby
WEBLOG_VARIANT: ${{ matrix.weblog-variant }}
DOCKER_REGISTRY_IMAGES_PATH: ghcr.io/datadog
DOCKER_IMAGE_TAG: ${{ github.sha }}
LIB_INIT_IMAGE: ghcr.io/datadog/dd-trace-rb/dd-lib-ruby-init:${{ github.sha }}
LIBRARY_INJECTION_TEST_APP_IMAGE: ghcr.io/datadog/system-tests/${{ matrix.weblog-variant }}:latest
BUILDX_PLATFORMS: linux/amd64,linux/arm64/v8
steps:
- name: Checkout system tests
uses: actions/checkout@v4
with:
repository: 'DataDog/system-tests'
persist-credentials: false
TonyCTHsu marked this conversation as resolved.
Show resolved Hide resolved

- name: Install runner
uses: ./.github/actions/install_runner
uses: ./.github/actions/install_runner

- name: Run K8s Lib Injection Tests
run: ./run.sh K8S_LIB_INJECTION_BASIC
run: ./run.sh K8S_LIBRARY_INJECTION_BASIC

- name: Compress logs
id: compress_logs
Expand Down Expand Up @@ -91,6 +92,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: DataDog/system-tests
persist-credentials: false
path: system-tests
- name: Overwrite auto inject script with commit SHA
run: |
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/system-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: 'DataDog/system-tests'
persist-credentials: false
- name: Pull released image
run: |
if docker pull ${{ env.REPO }}/system-tests/${{ matrix.image.name }}:latest; then
Expand Down Expand Up @@ -104,6 +105,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: 'DataDog/system-tests'
persist-credentials: false
- name: Checkout ${{ matrix.library.repository }}
uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -250,6 +252,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: 'DataDog/system-tests'
persist-credentials: false
- name: Pull runner image
run: |
docker pull ${{ env.REPO }}/system-tests/runner:gha${{ github.run_id }}-g${{ github.sha }}
Expand Down Expand Up @@ -316,6 +319,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: 'DataDog/system-tests'
persist-credentials: false
- name: Retrieve logs
uses: actions/download-artifact@v4
with:
Expand Down
Loading