Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gemfiles #3889

Closed
wants to merge 1 commit into from
Closed

Update gemfiles #3889

wants to merge 1 commit into from

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Sep 4, 2024 •
edited
Loading

What does this PR do?

Automates updating all gemfiles with latest versions of gems, a rake task created by @TonyCTHsu in #3916.
This creates the workflow for automatically generated PRs.

Generated PR: #3923

Future items:

  • Expand the matrix in Matrixfile to include latest for all gems, beyond stripe, opensearch, elasticsearch.

Motivation:

Additional Notes:

How to test the change?

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-09-18 22:40:21

Comparing candidate commit 9e13dd5 in PR branch quinna/update-gemfiles with baseline commit 7f9ed24 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (7f9ed24) to head (9e13dd5).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3889   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files        1286     1286           
  Lines       77059    77059           
  Branches     3807     3807           
=======================================
  Hits        75348    75348           
  Misses       1711     1711

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinna-h quinna-h added the dev/internal Other internal work that does not need to be included in the changelog label Sep 5, 2024
quinna-h
quinna-h commented Sep 9, 2024
View reviewed changes
.github/workflows/auto-update-gemfiles.yml Outdated
# Example command to create a tar.gz file of modified files
mkdir -p modified_gemfiles
VERSION=${{ matrix.engine.version }}
find . -name "*${VERSION}_rack_*.gemfile" -exec cp --parents {} modified_gemfiles/ \;
Copy link
Contributor Author

@quinna-h quinna-h Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hardcoded for now, but will have to modify to loop through list of gems

quinna-h
quinna-h commented Sep 11, 2024
View reviewed changes
tasks/edge.rake Outdated Show resolved Hide resolved
@quinna-h quinna-h marked this pull request as ready for review September 18, 2024 18:54
@quinna-h quinna-h requested a review from a team as a code owner September 18, 2024 18:54
bouwkast
bouwkast reviewed Sep 18, 2024
View reviewed changes
Copy link

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I'm wondering if we can delete the version_updater.rb as I think all of that is handled in the edge.rake file?

.github/workflows/auto-update-gemfiles.yml Outdated Show resolved Hide resolved
.github/scripts/version_updater.rb Outdated Show resolved Hide resolved
tasks/edge.rake Outdated Show resolved Hide resolved
.github/workflows/auto-update-gemfiles.yml Outdated Show resolved Hide resolved
.github/workflows/auto-update-gemfiles.yml Show resolved Hide resolved
.github/workflows/auto-update-gemfiles.yml Outdated Show resolved Hide resolved
@bouwkast
Copy link

With respect to:

TODO:

Expand the matrix in Matrixfile to include latest for all gems, beyond stripe, opensearch, elasticsearch.

I would say hold off on getting additional gems working for latest. Neither of us know enough about the Ruby ecosystem to be able to approach this effectively or efficiently IMO.
I'd like someone from dd-trace-rb who has enough knowledge to either lead this or work very closely with you or I on this as some of the gems have been out of date for a while.

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Sep 18, 2024
bouwkast
bouwkast reviewed Sep 18, 2024
View reviewed changes
.github/workflows/auto-update-gemfiles.yml
# Instead we conditionally skip it at job level, instead of workflow level.
on:
schedule:
- cron: '0 0 * * 0' # Every Sunday at midnight
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to note to the other Ruby people here that this automation will start running

bouwkast
bouwkast approved these changes Sep 18, 2024
View reviewed changes
Copy link

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@github-actions github-actions bot removed the dev/github Github repository maintenance and automation label Sep 18, 2024
@quinna-h quinna-h closed this Sep 19, 2024
@quinna-h quinna-h requested review from a team as code owners September 19, 2024 01:44
@github-actions github-actions bot added appsec Application Security monitoring product core Involves Datadog core libraries integrations Involves tracing integrations labels Sep 19, 2024
@github-actions github-actions bot added otel OpenTelemetry-related changes profiling Involves Datadog profiling single-step Single Step APM Instrumentation tracing labels Sep 19, 2024
@quinna-h quinna-h deleted the quinna/update-gemfiles branch September 19, 2024 01:46
@quinna-h quinna-h removed core Involves Datadog core libraries integrations Involves tracing integrations profiling Involves Datadog profiling appsec Application Security monitoring product tracing dev/internal Other internal work that does not need to be included in the changelog otel OpenTelemetry-related changes single-step Single Step APM Instrumentation labels Sep 19, 2024
@quinna-h quinna-h removed request for a team September 19, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyCTHsu TonyCTHsu TonyCTHsu left review comments

@ivoanjo ivoanjo ivoanjo left review comments

@bouwkast bouwkast bouwkast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@quinna-h @codecov-commenter @bouwkast @ivoanjo @TonyCTHsu