Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-2334 Dynamic instrumentation configuration #3917

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

p-datadog
Copy link
Contributor

What does this PR do?

Adds dynamic instrumentation configuration settings.

Motivation:
Initial DI implementation in Ruby.

Additional Notes:

How to test the change?
Unit tests at this time.

@pr-commenter
Copy link

pr-commenter bot commented Sep 17, 2024

Benchmarks

Benchmark execution time: 2024-09-17 15:16:24

Comparing candidate commit bb28c2e in PR branch di-settings with baseline commit 06aa9ac in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (06aa9ac) to head (bb28c2e).
Report is 55 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3917   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files        1281     1286    +5     
  Lines       76657    76747   +90     
  Branches     3758     3761    +3     
=======================================
+ Hits        75017    75109   +92     
+ Misses       1640     1638    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-datadog
Copy link
Contributor Author

Note that this PR does not require datadog/di from anywhere, hence the added code will not be loaded by any applications/customers yet.

@p-datadog p-datadog merged commit f6ec8b7 into master Sep 18, 2024
189 of 191 checks passed
@p-datadog p-datadog deleted the di-settings branch September 18, 2024 16:57
@github-actions github-actions bot added this to the 2.4.0 milestone Sep 18, 2024
p-datadog pushed a commit to p-datadog/dd-trace-rb that referenced this pull request Sep 18, 2024
* master:
  DEBUG-2334 Dynamic instrumentation configuration (DataDog#3917)
  Update Gemfiles
  Set both permission for milestone action (DataDog#3920)
  Rename variable
  Lint
  Add tools to excluded test
  Update gemfiles
  Extract yard
  Comment
  Task for updating latest group
  Allow GraphQL integration reconfiguration
  Change the way how login tracking is disabled for Rememberable strategy
  Rename __validate alias to __validate_datadog_authenticatable
  Add sig file for RememberablePatch
  Add test for Devise::Strategies::Rememberable patch
  Add AppSec patcher for Devise Rememberable strategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants