chore: sample before digest #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-09-25 17:58:42 Comparing candidate commit e9b2cd7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3945 +/- ##
==========================================
- Coverage 97.85% 97.84% -0.01%
==========================================
Files 1303 1303
Lines 78139 78141 +2
Branches 3894 3895 +1
==========================================
- Hits 76462 76457 -5
- Misses 1677 1684 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ZStriker19
commented
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR causes a trace to be sampled upon digest creation with the intent of making sampling lazy. The benefit of this approach is that we only create digests right before either propagation or context changes like forking or threading. Therefore it covers multiple exits. The downside is having sampling run as a side effect of creating a digest.
Additional Notes:
How to test the change?
Unsure? Have a question? Request a review!