Retry apt-get install for memory-leaks config

[p-datadog]

What does this PR do?

This configuration is frequently failing due to HTTP 503 error when installing valgrind. Retry the installation one time after a short break to see if this would make the configuration less flaky.

Motivation:
Repeated test failures

Additional Notes:

How to test the change?

Unsure? Have a question? Request a review!

[ivoanjo]

👍 I'm not sure if this will fix it, but it's cheap to try

[ivoanjo]

Minor: Modern versions of apt don't need apt-get (they're mostly aliases)

Suggested change

	- run: sudo apt-get update && (sudo apt-get install -y valgrind || sleep 5 && sudo apt-get install -y valgrind) && valgrind --version
	- run: sudo apt update && (sudo apt install -y valgrind || sleep 5 && sudo apt install -y valgrind) && valgrind --version

[p-datadog]

While apt and apt-get do overlap in functionality, apt is not intended for script usage and makes fewer/no interface compatibility guarantees compared to underlying tools like apt-get (https://unix.stackexchange.com/questions/590699/should-i-use-apt-or-apt-get-in-shell-scripting, https://serverfault.com/questions/958003/how-to-disable-warning-apt-does-not-have-a-stable-cli-interface, https://manpages.ubuntu.com/manpages/xenial/man8/apt.8.html).

[ivoanjo]

Interesting, thanks for sharing! I definitely did not know this, and I guess have been making the mistake of using apt in scripts for a while now. Oops 😅

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (2209a7c) to head (b8e4ea8).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3953   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files        1303     1303           
  Lines       78139    78140    +1     
  Branches     3894     3894           
=======================================
+ Hits        76461    76463    +2     
+ Misses       1678     1677    -1     

Flag	Coverage Δ
	97.85% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-09-25 17:33:25

Comparing candidate commit b8e4ea8 in PR branch retry-memory-leaks with baseline commit 2209a7c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.