DEBUG-2334 run all existing DI tests only on supported configurations #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic instrumentation will not work on Ruby 2.5 and JRuby. Some unit tests will pass on those configurations, but there is no reason to run them there because they run on all of the supported configurations already.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3955 +/- ##
=======================================
Coverage 97.83% 97.84%
=======================================
Files 1303 1303
Lines 78139 78128 -11
Branches 3894 3888 -6
=======================================
- Hits 76451 76443 -8
+ Misses 1688 1685 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anmarchenko
approved these changes
Sep 26, 2024
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Sep 27, 2024
* master: Delete #body method from Rack request gateway and fixed content-length [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/11052224020 Remove `builder` DEBUG-2334 run all existing DI tests only on supported configurations (DataDog#3955) run ci Skip appsec:rack Retry apt-get install for memory-leaks config [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/11035048086 Expand rack matrix with latest Add tests Rescue instrumentation errors add comment that get_time_provider setting is internal remove get_time_provider option from the public docs correct my lambda syntax usage Remove obsolete test that never ran change the default get_time_provider value, add test for Tracing::SpanOperation when get_time_provider is set documentation for the new configuration option add new setting `get_time_provider` that allows redefining Core::Utils::Time.get_time method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic instrumentation will not work on Ruby 2.5 and JRuby. Some unit tests will pass on those configurations, but there is no reason to run them there because they run on all of the supported configurations already.
What does this PR do?
Add
di_testdeclaration to all existing DI tests that do not have it.Motivation:
Faster CI runs.
Additional Notes:
How to test the change?
Unsure? Have a question? Request a review!