Integrate catadog image as proxy service between agent and library #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahchen6
force-pushed
the
sarahchen6/integrate-catadog-as-proxy
branch
2 times, most recently
from
4c5b6cc
to
821b829
Compare
…he tracer and testagent
sarahchen6
force-pushed
the
sarahchen6/integrate-catadog-as-proxy
branch
from
e96e051
to
ef0682f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3958 +/- ##
==========================================
- Coverage 97.87% 97.86% -0.01%
==========================================
Files 1313 1313
Lines 78352 78352
Branches 3886 3886
==========================================
- Hits 76684 76681 -3
- Misses 1668 1671 +3 ☔ View full report in Codecov by Sentry. |
sarahchen6
force-pushed
the
sarahchen6/integrate-catadog-as-proxy
branch
from
4791100
to
68da931
Compare
BenchmarksBenchmark execution time: 2024-10-03 14:55:56 Comparing candidate commit 68da931 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 22 metrics, 2 unstable metrics. scenario:tracing - Propagation - Datadog
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR integrates the catadog image in the
docker-compose.ymlas a proxy service between the library andtestagent.Motivation:
Catadog is a tool for development, testing, and diagnosis. By integrating
catadog, developers can customize the proxy to suit their development needs.Additional Notes:
In the
docker-compose.yml,catadogacts as a proxy between thetestagentandddagentso that it can access relevant trace information. However,catadogis not involved in the CircleCI workflow because it is a development, rather than testing, tool.How to test the change?
You can confirm trace information is correctly passed by running the
docker-compose.ymland observingcatadog,testagent, andddagentlogs throughdocker logs <container_id>.Unsure? Have a question? Request a review!