Fix spec:appsec:rack for Rack 3.1 (latest)
#3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3960 +/- ##
==========================================
+ Coverage 97.85% 97.87% +0.01%
==========================================
Files 1305 1305
Lines 78224 78219 -5
Branches 3887 3886 -1
==========================================
+ Hits 76549 76553 +4
+ Misses 1675 1666 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-09-27 13:42:05 Comparing candidate commit 304e43f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
y9v
approved these changes
Sep 27, 2024
TonyCTHsu
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fix
spec:appsec:rackby deleting the#bodymethod from the Rack request gateway (as this method is not used anywhere in our code, and the reactive engine uses#form_hashto send the body to the WAF) and sets a default value of'0'toheaders['content-length']Motivation:
spec:appsec:rackwas failing for Rack 3.1+. Rack is used by most, if not all of our clients, we must be sure to support the latest version (hopefully these failing tests were not critical)Unsure? Have a question? Request a review!