[PROF-10589] Add more details to flaky profiler spec #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** I've been hunting down a flaky profiler test that was added as part of the new GVL profiling feature. Here's how it looks: https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/16712/workflows/f2e30fe0-c1e5-4e87-b228-4eec53d41017/jobs/599762 I haven't been able to reproduce the issue locally, so I'm adding more information that will hopefully point the way the next time the spec is flaky again. **Motivation:** Hunt down flaky spec. **Additional Notes:** Thanks for the patience for the other folks on the team. If I really can't figure this one, I'll disable the spec, but I'm hoping this extra info points the way to solving the issue and keeping the spec (since I do believe this spec offers value -- as it tests the GVL profiling feature end-to-end, profiling a real Ruby thread during the testcase). **How to test the change?** This change only shows up once the test fails. So for now a green CI is good, and a red CI with the flaky issue is even better.
ivoanjo
added
dev/testing
AlexJF
approved these changes
Oct 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3980 +/- ##
==========================================
- Coverage 97.86% 97.85% -0.01%
==========================================
Files 1313 1313
Lines 78369 78370 +1
Branches 3888 3888
==========================================
- Hits 76694 76692 -2
- Misses 1675 1678 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I've been hunting down a flaky profiler test that was added as part of the new GVL profiling feature.
Here's how it looks:
https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/16712/workflows/f2e30fe0-c1e5-4e87-b228-4eec53d41017/jobs/599762
I haven't been able to reproduce the issue locally, so I'm adding more information that will hopefully point the way the next time the spec is flaky again.
Motivation:
Hunt down flaky spec.
Additional Notes:
Thanks for the patience for the other folks on the team. If I really can't figure this one, I'll disable the spec, but I'm hoping this extra info points the way to solving the issue and keeping the spec (since I do believe this spec offers value -- as it tests the GVL profiling feature end-to-end, profiling a real Ruby thread during the testcase).
How to test the change?
This change only shows up once the test fails. So for now a green CI is good, and a red CI with the flaky issue is even better.